Skip to content

Commit aa52b7c

Browse files
Add comment explaining version comparison approach
Co-authored-by: AbhishekBhaskar <[email protected]>
1 parent 765da75 commit aa52b7c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

updater/lib/dependabot/updater/group_update_refreshing.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,9 @@ def dependency_still_needs_update?(pr_dep, group)
137137

138138
# If current version equals PR target, dependencies were updated externally
139139
# The PR is no longer needed and should be closed
140+
# Note: String comparison is used here to match the PR data format
141+
# which stores versions as strings. This is consistent with how versions
142+
# are compared elsewhere in the codebase (e.g., dependency_change_builder.rb:84)
140143
return false if current_dep.version.to_s == pr_target_version
141144

142145
# The dependency is still at an older version, so the PR is still needed

0 commit comments

Comments
 (0)