chore: Replace deprecated lucene methods (#8079)

Author: leonard-

core/src/main/java/org/owasp/dependencycheck/data/cpe/AbstractMemoryIndex.java

@@ -39,7 +39,6 @@
 import org.apache.lucene.index.IndexWriterConfig;
 import org.apache.lucene.queryparser.classic.ParseException;
 import org.apache.lucene.queryparser.classic.QueryParser;
-import org.apache.lucene.search.BooleanQuery;
 import org.apache.lucene.search.IndexSearcher;
 import org.apache.lucene.search.Query;
 import org.apache.lucene.search.TopDocs;
@@ -282,15 +281,15 @@ public synchronized Query parseQuery(String searchString) throws ParseException,
         Query query;
         try {
             query = queryParser.parse(searchString);
-        } catch (BooleanQuery.TooManyClauses ex) {
-            BooleanQuery.setMaxClauseCount(Integer.MAX_VALUE);
+        } catch (IndexSearcher.TooManyClauses ex) {
+            IndexSearcher.setMaxClauseCount(Integer.MAX_VALUE);
             query = queryParser.parse(searchString);
         } catch (ParseException ex) {
             if (ex.getMessage() != null && ex.getMessage().contains("too many boolean clauses")) {
-                BooleanQuery.setMaxClauseCount(Integer.MAX_VALUE);
+                IndexSearcher.setMaxClauseCount(Integer.MAX_VALUE);
                 query = queryParser.parse(searchString);
             } else {
-                LOGGER.debug("Parse Excepction", ex);
+                LOGGER.debug("Parse Exception", ex);
                 throw ex;
             }
         }
@@ -325,7 +324,7 @@ public synchronized TopDocs search(Query query, int maxQueryResults) throws Corr
      */
     @Override
     public synchronized Document getDocument(int documentId) throws IOException {
-        return indexSearcher.doc(documentId);
+        return indexSearcher.storedFields().document(documentId);
     }
 
     /**

core/src/test/java/org/owasp/dependencycheck/data/lucene/FieldAnalyzerTest.java

@@ -31,7 +31,8 @@
 import org.apache.lucene.search.IndexSearcher;
 import org.apache.lucene.search.Query;
 import org.apache.lucene.search.ScoreDoc;
-import org.apache.lucene.search.TopScoreDocCollector;
+import org.apache.lucene.search.TopDocs;
+import org.apache.lucene.search.TopScoreDocCollectorManager;
 import org.apache.lucene.store.Directory;
 import org.apache.lucene.store.MMapDirectory;
 import org.junit.jupiter.api.Test;
@@ -88,13 +89,15 @@ void testAnalyzers() throws Exception {
 
         IndexReader reader = DirectoryReader.open(index);
         IndexSearcher searcher = new IndexSearcher(reader);
-        TopScoreDocCollector collector = TopScoreDocCollector.create(hitsPerPage, hitsThreshold);
-        searcher.search(q, collector);
-        ScoreDoc[] hits = collector.topDocs().scoreDocs;
+        TopScoreDocCollectorManager manager =
+                new TopScoreDocCollectorManager(hitsPerPage, null, hitsThreshold, false);
+
+        TopDocs topDocs = searcher.search(q, manager);
+        ScoreDoc[] hits = topDocs.scoreDocs;
 
         assertEquals(1, hits.length, "Did not find 1 document?");
-        assertEquals("springframework", searcher.doc(hits[0].doc).get(field1));
-        assertEquals("springsource", searcher.doc(hits[0].doc).get(field2));
+        assertEquals("springframework", searcher.storedFields().document(hits[0].doc).get(field1));
+        assertEquals("springsource", searcher.storedFields().document(hits[0].doc).get(field2));
 
         querystr = "product:(Apache Struts) vendor:(Apache)";
 
@@ -105,11 +108,11 @@ void testAnalyzers() throws Exception {
         querystr = "product:(  x-stream^5 )  AND  vendor:(  thoughtworks.xstream )";
         reset(searchAnalyzerProduct, searchAnalyzerVendor);
         Query q3 = parser.parse(querystr);
-        collector = TopScoreDocCollector.create(hitsPerPage, hitsThreshold);
-        searcher.search(q3, collector);
-        hits = collector.topDocs().scoreDocs;
-        assertEquals("x-stream", searcher.doc(hits[0].doc).get(field1));
-        assertEquals("xstream", searcher.doc(hits[0].doc).get(field2));
+        manager = new TopScoreDocCollectorManager(hitsPerPage, null, hitsThreshold, false);
+        topDocs = searcher.search(q3, manager);
+        hits = topDocs.scoreDocs;
+        assertEquals("x-stream", searcher.storedFields().document(hits[0].doc).get(field1));
+        assertEquals("xstream", searcher.storedFields().document(hits[0].doc).get(field2));
     }
 
     private IndexWriter createIndex(Analyzer analyzer, Directory index) throws IOException {

pom.xml

@@ -118,7 +118,7 @@ Copyright (c) 2012 - Jeremy Long
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <github.global.server>github</github.global.server>
 
-        <apache.lucene.version>9.12.0</apache.lucene.version>
+        <apache.lucene.version>9.12.3</apache.lucene.version>
         <apache.ant.version>1.10.15</apache.ant.version>
 
         <!-- upgrading slf4j and logback can cause issues ;) https://github.com/dependency-check/DependencyCheck/issues/4846 -->