refactor: #7510 make change non-breaking at public API level

Author: nhumblot

core/src/main/java/org/owasp/dependencycheck/analyzer/CentralAnalyzer.java

@@ -310,16 +310,16 @@ public void analyzeDependency(Dependency dependency, Engine engine) throws Analy
             LOGGER.info("invalid sha1-hash on {}", dependency.getFileName());
         } catch (FileNotFoundException fnfe) {
             LOGGER.debug("Artifact not found in repository: '{}", dependency.getFileName());
-        } catch (IOException ioe) {
-            final String message = "Could not connect to Central search. Analysis failed.";
-            LOGGER.error(message, ioe);
-            throw new AnalysisException(message, ioe);
         } catch (ForbiddenException e) {
             final String message = "Connection to Central search refused. This is most likely not a problem with " +
                     "Dependency-Check itself and is related to network connectivity. Please check " +
                     "https://central.sonatype.org/faq/403-error-central/.";
             LOGGER.error(message);
             throw new AnalysisException(message, e);
+        } catch (IOException ioe) {
+            final String message = "Could not connect to Central search. Analysis failed.";
+            LOGGER.error(message, ioe);
+            throw new AnalysisException(message, ioe);
         }
     }
 
@@ -338,7 +338,7 @@ public void analyzeDependency(Dependency dependency, Engine engine) throws Analy
      * requests.
      */
     protected List<MavenArtifact> fetchMavenArtifacts(Dependency dependency) throws IOException,
-            TooManyRequestsException, ForbiddenException {
+            TooManyRequestsException {
         IOException lastException = null;
         long sleepingTimeBetweenRetriesInMillis = BASE_RETRY_WAIT;
         int triesLeft = numberOfRetries;

core/src/main/java/org/owasp/dependencycheck/data/nexus/NexusV2Search.java

@@ -164,7 +164,7 @@ public boolean preflightRequest() {
                 LOGGER.warn("Pre-flight request to Nexus failed; expected root node name of status, got {}", doc.getDocumentElement().getNodeName());
                 return false;
             }
-        } catch (IOException | TooManyRequestsException | ResourceNotFoundException | URISyntaxException | ForbiddenException e) {
+        } catch (IOException | TooManyRequestsException | ResourceNotFoundException | URISyntaxException e) {
             LOGGER.warn("Pre-flight request to Nexus failed: ", e);
             return false;
         }

core/src/main/java/org/owasp/dependencycheck/data/update/KnownExploitedDataSource.java

@@ -35,7 +35,6 @@
 import org.owasp.dependencycheck.data.update.exception.CorruptedDatastreamException;
 import org.owasp.dependencycheck.data.update.exception.UpdateException;
 import org.owasp.dependencycheck.utils.Downloader;
-import org.owasp.dependencycheck.utils.ForbiddenException;
 import org.owasp.dependencycheck.utils.ResourceNotFoundException;
 import org.owasp.dependencycheck.utils.Settings;
 import org.owasp.dependencycheck.utils.TooManyRequestsException;
@@ -103,7 +102,7 @@ public KnownExploitedVulnerabilitiesSchema handleEntity(HttpEntity entity) throw
                 dbProperties.save(DatabaseProperties.KEV_LAST_CHECKED, Long.toString(System.currentTimeMillis() / 1000));
                 return true;
             } catch (TooManyRequestsException | ResourceNotFoundException | IOException | DatabaseException
-                     | SQLException | URISyntaxException | ForbiddenException ex) {
+                     | SQLException | URISyntaxException ex) {
                 throw new UpdateException(ex);
             }
         }

utils/src/main/java/org/owasp/dependencycheck/utils/ForbiddenException.java

@@ -18,7 +18,9 @@
  */
 package org.owasp.dependencycheck.utils;
 
-public class ForbiddenException extends Exception {
+import java.io.IOException;
+
+public class ForbiddenException extends IOException {
 
     public ForbiddenException(String message) {
         super(message);