feat: add noTypeDefinitions option

Author: Noah Hummel

index.js

@@ -109,7 +109,8 @@ module.exports._getDependencies = function(config) {
       config: config.requireConfig,
       webpackConfig: config.webpackConfig,
       nodeModulesConfig: config.nodeModulesConfig,
-      tsConfig: config.tsConfig
+      tsConfig: config.tsConfig,
+      noTypeDefinitions: config.noTypeDefinitions
     });
 
     if (!result) {

lib/Config.js

@@ -15,6 +15,7 @@ class Config {
     this.nodeModulesConfig = options.nodeModulesConfig;
     this.detectiveConfig = options.detective || options.detectiveConfig || {};
     this.tsConfig = options.tsConfig;
+    this.noTypeDefinitions = options.noTypeDefinitions;
 
     this.filter = options.filter;
 

test/example/noTypeDefinitions/entrypoint.ts

@@ -0,0 +1 @@
+import { theAnswer } from './required';

test/example/noTypeDefinitions/required.d.ts

@@ -0,0 +1 @@
+export const theAnswer: number;

test/example/noTypeDefinitions/required.js

@@ -0,0 +1,3 @@
+module.exports = {
+  theAnswer: 42
+};

test/test.js

@@ -205,6 +205,16 @@ describe('dependencyTree', function() {
     assert(tree.length === 3);
   });
 
+  it('resolves TypeScript imports to their type definition files by default', function() {
+    const directory = path.join(__dirname, 'example', 'noTypeDefinitions');
+    const filename = path.join(directory, 'entrypoint.ts');
+
+    const list = dependencyTree.toList({filename, directory});
+
+    assert(list.includes(path.join(directory, 'required.d.ts')));
+    assert(!list.includes(path.join(directory, 'required.js')));
+  });
+
   describe('when given a detective configuration', function() {
     it('passes it through to precinct', function() {
       const spy = sinon.spy(precinct, 'paperwork');
@@ -903,6 +913,32 @@ describe('dependencyTree', function() {
     });
   });
 
+  describe('when noTypeDefinitions is set', function() {
+    describe('and it is set to false', function() {
+      it('resolves TypeScript imports to their definition files', function() {
+        const directory = path.join(__dirname, 'example', 'noTypeDefinitions');
+        const filename = path.join(directory, 'entrypoint.ts');
+
+        const list = dependencyTree.toList({filename, directory, noTypeDefinitions: false});
+
+        assert(list.includes(path.join(directory, 'required.d.ts')));
+        assert(!list.includes(path.join(directory, 'required.js')));
+      });
+    });
+
+    describe('and it is set to true', function() {
+      it('resolves TypeScript imports to their JavaScript implementation files', function() {
+        const directory = path.join(__dirname, 'example', 'noTypeDefinitions');
+        const filename = path.join(directory, 'entrypoint.ts');
+
+        const list = dependencyTree.toList({filename, directory, noTypeDefinitions: true});
+
+        assert(list.includes(path.join(directory, 'required.js')));
+        assert(!list.includes(path.join(directory, 'required.d.ts')));
+      });
+    });
+  });
+
   describe('Config', function() {
     describe('when given a path to a typescript config', function() {
       it('pre-parses the config for performance', function() {