Skip to content

Commit f7b4239

Browse files
fix: force page reload on logout (#5)
* style registration page Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com> * dont query pipelines if no namespace is selected Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com> * force page reload on logout link Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com> --------- Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
1 parent 01060f3 commit f7b4239

File tree

3 files changed

+14
-9
lines changed

3 files changed

+14
-9
lines changed

dashboard/public/components/logout-button.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,9 @@ import '@polymer/paper-button/paper-button.js';
1111
export class LogoutButton extends PolymerElement {
1212
static get template() {
1313
return html`
14-
<a href="{{logoutUrl}}">
15-
<paper-button id="logout-button">
16-
<iron-icon icon='kubeflow:logout' title="Logout"></iron-icon>
17-
</paper-button>
18-
</a>
14+
<paper-button id="logout-button" on-tap="logout">
15+
<iron-icon icon='kubeflow:logout' title="Logout"></iron-icon>
16+
</paper-button>
1917
`;
2018
}
2119

@@ -26,6 +24,13 @@ export class LogoutButton extends PolymerElement {
2624
},
2725
};
2826
}
27+
28+
/**
29+
* Redirects to the logout url.
30+
*/
31+
logout() {
32+
window.top.location.href = this.logoutUrl;
33+
}
2934
}
3035

3136
customElements.define('logout-button', LogoutButton);

dashboard/public/components/pipelines-card.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ export class PipelinesCard extends utilitiesMixin(PolymerElement) {
9696
*/
9797
_getListPipelinesUrl(artifactType, namespace) {
9898
if (!VALID_ARTIFACT_TYPES.has(artifactType)) return null;
99+
if (namespace === undefined) return null;
99100
let link = `/pipeline/apis/v1beta1/${artifactType}?`
100101
+ 'page_size=5&sort_by=created_at%20desc';
101102
if (artifactType === RUNS) {

dashboard/public/components/registration-page.pug

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ paper-card#MainCard
88
exit-animation='fade-out-animation')
99
neon-animatable
1010
h2 Welcome
11-
aside In order to use Kubeflow, a namespace for your account must be created. Follow the steps to get started
11+
aside In order to use deployKF, a namespace for your account must be created. Follow the steps to get started
1212
.actions
1313
paper-button(on-click='nextPage') Start Setup
1414
neon-animatable
@@ -23,6 +23,5 @@ paper-card#MainCard
2323
carousel-indicator(size=2, selected='{{page}}')
2424

2525
nav#Links
26-
a(href='https://github.com/kubeflow/kubeflow', tabindex='-1', target="_blank") GitHub
27-
a(href='https://www.kubeflow.org/docs/about/kubeflow/', tabindex='-1', target="_blank") Documentation
28-
a(href='https://policies.google.com/privacy', tabindex='-1', target="_blank") Privacy
26+
a(href='https://www.deploykf.org/', tabindex='-1', target="_blank") deployKF Website
27+
a(href='https://github.com/deployKF/deployKF', tabindex='-1', target="_blank") deployKF GitHub

0 commit comments

Comments
 (0)