Skip to content

Commit fb0386a

Browse files
thesuperzapperthesuperzapper
committed
FORK: add GHA to build image
Signed-off-by: Mathew Wicks <[email protected]>
1 parent cad0c56 commit fb0386a

File tree

4 files changed

+192
-126
lines changed

4 files changed

+192
-126
lines changed

‎.github/workflows/build-commit.yml‎

Lines changed: 0 additions & 61 deletions
This file was deleted.

‎.github/workflows/build_commit.yml‎

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
name: Build Commit
2+
3+
on:
4+
push:
5+
branches:
6+
- fork-*
7+
8+
permissions:
9+
packages: write
10+
11+
jobs:
12+
build__ml_metadata_server:
13+
name: Build - ML Metadata Server
14+
uses: ./.github/workflows/build_image_TEMPLATE.yml
15+
secrets: inherit
16+
with:
17+
image_names: ghcr.io/${{ github.repository_owner }}/ci/ml_metadata_store_server
18+
19+
metadata_title: "ML-Metadata Server"
20+
metadata_description: "Google ML Metadata Server"
21+
22+
tag_with_latest: false
23+
tag_with_semver: false
24+
tag_with_sha: true
25+
26+
build_file: ./ml_metadata/tools/docker_server/Dockerfile
27+
build_context: .
28+
build_platforms: |-
29+
linux/amd64
30+
linux/arm64
31+
build_registry_cache: ghcr.io/${{ github.repository_owner }}/ci/ml_metadata_store_server:build-cache
32+
33+
login_to_ghcr: true
34+
login_to_docker: false

‎.github/workflows/build_image_TEMPLATE.yml‎

Lines changed: 128 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,128 @@
1+
name: Build Image (TEMPLATE)
2+
on:
3+
workflow_call:
4+
inputs:
5+
image_names:
6+
required: true
7+
description: "the images to push, including registry prefix, whitespace separated"
8+
type: string
9+
10+
metadata_title:
11+
required: true
12+
description: "the title of the image"
13+
type: string
14+
metadata_description:
15+
required: true
16+
description: "the description of the image"
17+
type: string
18+
19+
tag_with_latest:
20+
default: false
21+
description: "if true, image tags will include 'latest'"
22+
type: boolean
23+
tag_with_semver:
24+
default: false
25+
description: "if true, image tags will include the version (from git tag event, without 'v' prefix)"
26+
type: boolean
27+
tag_with_sha:
28+
default: false
29+
description: "if true, image tags will include the commit SHA (both short and long)"
30+
type: boolean
31+
32+
build_file:
33+
required: true
34+
description: "path to Dockerfile"
35+
type: string
36+
build_context:
37+
required: true
38+
description: "path to build context folder"
39+
type: string
40+
build_platforms:
41+
required: true
42+
description: "docker buildx platforms to build for, whitespace separated"
43+
type: string
44+
build_registry_cache:
45+
required: true
46+
description: "an image to use as a registry-type build cache (registry + image + tag)"
47+
type: string
48+
49+
login_to_ghcr:
50+
default: false
51+
description: "if true, login to GitHub Container Registry with the GITHUB_TOKEN"
52+
type: boolean
53+
login_to_docker:
54+
default: false
55+
description: "if true, login to DockerHub using the DOCKER_USERNAME and DOCKER_PASSWORD secrets in the repository"
56+
type: boolean
57+
58+
jobs:
59+
build_image:
60+
name: Build '${{ inputs.metadata_title }}' Image
61+
runs-on: ubuntu-latest
62+
steps:
63+
## We need to sanitize some inputs before we can use them:
64+
## - the `build_registry_cache` must be lowercase so we can safely use
65+
## it in `cache-from` and `cache-to` options
66+
- name: Sanitize Inputs
67+
id: sanitize_inputs
68+
env:
69+
build_registry_cache: ${{ inputs.build_registry_cache }}
70+
run: |
71+
echo "build_registry_cache=${build_registry_cache@L}" >> "$GITHUB_OUTPUT"
72+
73+
- name: Checkout
74+
uses: actions/checkout@v4
75+
76+
- name: Install QEMU
77+
uses: docker/setup-qemu-action@v3
78+
79+
- name: Install Docker Buildx
80+
uses: docker/setup-buildx-action@v3
81+
82+
- name: Login to GitHub Container Registry
83+
uses: docker/login-action@v3
84+
if: ${{ inputs.login_to_ghcr }}
85+
with:
86+
registry: ghcr.io
87+
username: ${{ github.actor }}
88+
password: ${{ secrets.GITHUB_TOKEN }}
89+
90+
- name: Login to DockerHub
91+
uses: docker/login-action@v3
92+
if: ${{ inputs.login_to_docker }}
93+
with:
94+
registry: docker.io
95+
username: ${{ secrets.DOCKER_USERNAME }}
96+
password: ${{ secrets.DOCKER_PASSWORD }}
97+
98+
- name: Generate Image Metadata
99+
id: meta
100+
uses: docker/metadata-action@v5
101+
with:
102+
images: ${{ inputs.image_names }}
103+
flavor: |
104+
latest=${{ inputs.tag_with_latest }}
105+
tags: |
106+
type=semver,priority=1000,pattern={{version}},enable=${{ inputs.tag_with_semver }}
107+
type=semver,priority=900,pattern={{major}}.{{minor}},enable=${{ inputs.tag_with_semver }}
108+
type=sha,priority=200,prefix=sha-,format=short,enable=${{ inputs.tag_with_sha }}
109+
type=sha,priority=100,prefix=sha-,format=long,enable=${{ inputs.tag_with_sha }}
110+
labels: |
111+
org.opencontainers.image.title=${{ inputs.metadata_title }}
112+
org.opencontainers.image.description=${{ inputs.metadata_description }}
113+
annotations: |
114+
org.opencontainers.image.title=${{ inputs.metadata_title }}
115+
org.opencontainers.image.description=${{ inputs.metadata_description }}
116+
117+
- name: Build and Push Image
118+
uses: docker/build-push-action@v5
119+
with:
120+
annotations: ${{ steps.meta.outputs.annotations }}
121+
cache-from: type=registry,ref=${{ steps.sanitize_inputs.outputs.build_registry_cache }}
122+
cache-to: type=registry,ref=${{ steps.sanitize_inputs.outputs.build_registry_cache }},mode=max
123+
context: ${{ inputs.build_context }}
124+
file: ${{ inputs.build_file }}
125+
labels: ${{ steps.meta.outputs.labels }}
126+
platforms: ${{ inputs.build_platforms }}
127+
push: true
128+
tags: ${{ steps.meta.outputs.tags }}

‎.github/workflows/release.yml‎

Lines changed: 30 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -9,73 +9,37 @@ permissions:
99
contents: write
1010
packages: write
1111

12-
env:
13-
IMAGE_OWNER: "deploykf"
14-
IMAGE_TITLE: "ml_metadata_store_server"
15-
IMAGE_DESCRIPTION: "Google ML Metadata Server"
16-
IMAGE_FOLDER: "ml_metadata/tools/docker_server"
17-
IMAGE_PLATFORMS: |-
18-
linux/amd64
19-
linux/arm64
20-
2112
jobs:
22-
build_and_push_image:
13+
build__ml_metadata_server:
14+
name: Build - ML Metadata Server
15+
uses: ./.github/workflows/build_image_TEMPLATE.yml
16+
secrets: inherit
17+
with:
18+
image_names: ghcr.io/${{ github.repository_owner }}/ml_metadata_store_server
19+
20+
metadata_title: "ML-Metadata Server"
21+
metadata_description: "Google ML Metadata Server"
22+
23+
tag_with_latest: false
24+
tag_with_semver: true
25+
tag_with_sha: false
26+
27+
build_file: ./ml_metadata/tools/docker_server/Dockerfile
28+
build_context: .
29+
build_platforms: |-
30+
linux/amd64
31+
linux/arm64
32+
build_registry_cache: ghcr.io/${{ github.repository_owner }}/ci/ml_metadata_store_server:build-cache
33+
34+
login_to_ghcr: true
35+
login_to_docker: false
36+
37+
create_release:
2338
runs-on: ubuntu-latest
39+
needs: [ build__ml_metadata_server ]
2440
steps:
25-
- name: Check out code
26-
uses: actions/checkout@v3
27-
28-
- name: Install QEMU
29-
uses: docker/setup-qemu-action@v2
30-
31-
- name: Install Docker Buildx
32-
uses: docker/setup-buildx-action@v2
33-
34-
- name: Login to GitHub Container Registry
35-
uses: docker/login-action@v2
36-
with:
37-
registry: ghcr.io
38-
username: ${{ github.actor }}
39-
password: ${{ secrets.GITHUB_TOKEN }}
40-
41-
- name: Login to DockerHub
42-
uses: docker/login-action@v2
43-
with:
44-
username: ${{ secrets.DOCKERHUB_USERNAME }}
45-
password: ${{ secrets.DOCKERHUB_TOKEN }}
46-
47-
- name: Generate Image Tags/Labels
48-
id: meta
49-
uses: docker/metadata-action@v4
50-
with:
51-
images: |
52-
ghcr.io/${{ env.IMAGE_OWNER }}/${{ env.IMAGE_TITLE }}
53-
docker.io/${{ env.IMAGE_OWNER }}/${{ env.IMAGE_TITLE }}
54-
flavor: |
55-
latest=true
56-
tags: |
57-
type=semver,priority=200,pattern={{major}}.{{minor}}
58-
type=semver,priority=100,pattern={{version}}
59-
labels: |
60-
org.opencontainers.image.title=${{ env.IMAGE_TITLE }}
61-
org.opencontainers.image.description=${{ env.IMAGE_DESCRIPTION }}
62-
org.opencontainers.image.url=https://github.com/${{ github.repository }}
63-
org.opencontainers.image.source=https://github.com/${{ github.repository }}/tree/${{ github.ref_name }}/${{ env.IMAGE_FOLDER }}
64-
65-
- name: Build and Push Image
66-
uses: docker/build-push-action@v4
67-
with:
68-
context: .
69-
file: ./${{ env.IMAGE_FOLDER }}/Dockerfile
70-
push: true
71-
platforms: ${{ env.IMAGE_PLATFORMS }}
72-
tags: ${{ steps.meta.outputs.tags }}
73-
labels: ${{ steps.meta.outputs.labels }}
74-
cache-from: type=registry,ref=ghcr.io/${{ env.IMAGE_OWNER }}/ci/${{ env.IMAGE_TITLE }}:build-cache
75-
cache-to: type=registry,ref=ghcr.io/${{ env.IMAGE_OWNER }}/ci/${{ env.IMAGE_TITLE }}:build-cache,mode=max
76-
7741
- name: Create GitHub Release
78-
uses: actions/github-script@v6
42+
uses: actions/github-script@v7
7943
with:
8044
script: |
8145
const { repo: { owner, repo }, ref: tag_ref } = context;
@@ -89,5 +53,6 @@ jobs:
8953
tag_name: tag_name,
9054
name: `ML Metadata Server - ${tag_version}`,
9155
draft: false,
92-
prerelease: tag_name.includes('-'),
93-
});
56+
// NOTE: for this repo, we always have '-patch.X' in the tag name
57+
//prerelease: tag_name.includes('-'),
58+
});

0 commit comments

Comments
 (0)