ecs-web/background: remove outdated github_anonymous var

- expose github_webhook_events var

Author: joe-niland

modules/ecs-background/variables.tf

@@ -481,17 +481,12 @@ variable "codepipeline_skip_deploy_step" {
   default     = false
 }
 
-variable "github_anonymous" {
-  type        = bool
-  description = "Github Anonymous API (if `true`, token must not be set as GITHUB_TOKEN or `github_token`)"
-  default     = false
-}
-
 variable "codepipeline_github_oauth_token" {
   type        = string
   description = "GitHub OAuth Token with permissions to access private repositories"
   default     = ""
 }
+
 variable "codepipeline_github_webhook_events" {
   type        = list(string)
   description = "A list of events which should trigger the webhook. See a list of [available events](https://developer.github.com/v3/activity/events/types/)"

modules/ecs-web/main.tf

@@ -575,16 +575,22 @@ module "ecs_codepipeline" {
   repo_owner                      = var.codepipeline_repo_owner
   repo_name                       = var.codepipeline_repo_name
   branch                          = var.codepipeline_branch
-  build_image                     = var.codepipeline_build_image
-  build_timeout                   = var.codepipeline_build_timeout
-  build_compute_type              = "BUILD_GENERAL1_SMALL"
   poll_source_changes             = false
+  webhook_enabled                 = var.codepipeline_webhook_enabled
+  github_oauth_token              = var.codepipeline_github_oauth_token
+  github_webhook_events           = var.codepipeline_github_webhook_events
+
+  build_image        = var.codepipeline_build_image
+  build_timeout      = var.codepipeline_build_timeout
+  build_compute_type = "BUILD_GENERAL1_SMALL"
   // True required to build docker containers
-  privileged_mode         = true
-  image_repo_name         = split("/", module.ecr.repository_url)[0]
-  image_tag               = "latest" // var.image_tag
-  webhook_enabled         = var.codepipeline_webhook_enabled
+  privileged_mode = true
+
+  image_repo_name = split("/", module.ecr.repository_url)[0]
+  image_tag       = "latest" // var.image_tag
+
   s3_bucket_force_destroy = true
+
   environment_variables = concat(
     var.codepipeline_environment_variables,
     var.codepipeline_add_queue_env_vars ?
@@ -622,12 +628,10 @@ module "ecs_codepipeline" {
       }
     ]
   )
-  ecs_cluster_name  = var.ecs_cluster_name
-  service_name      = module.ecs_task.service_name
-  cache_type        = var.codebuild_cache_type
-  local_cache_modes = var.codebuild_local_cache_modes
-  # github_anonymous        = true
-  github_oauth_token   = ""
+  ecs_cluster_name     = var.ecs_cluster_name
+  service_name         = module.ecs_task.service_name
+  cache_type           = var.codebuild_cache_type
+  local_cache_modes    = var.codebuild_local_cache_modes
   codebuild_vpc_config = var.codebuild_vpc_config
 
   context = module.this.context