Don't modify state inside set callback

Author: antonmedv

docs/recipe/deploy/release.md

@@ -18,35 +18,35 @@ The name of the release.
 
 
 ### releases_log
-[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/release.php#L16)
+[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/release.php#L14)
 
 Holds releases log from `.dep/releases_log` file.
 
 
 
 ### releases_list
-[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/release.php#L41)
+[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/release.php#L39)
 
 Return list of release names on host.
 
 
 
 ### release_path
-[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/release.php#L68)
+[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/release.php#L66)
 
 Return release path.
 
 
 
 ### release_revision
-[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/release.php#L79)
+[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/release.php#L77)
 
 Current release revision. Usually a git hash.
 
 
 
 ### release_or_current_path
-[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/release.php#L85)
+[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/release.php#L83)
 
 Return the release path during a deployment
 but fallback to the current path otherwise.
@@ -57,15 +57,15 @@ but fallback to the current path otherwise.
 ## Tasks
 
 ### deploy:release
-[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/release.php#L92)
+[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/release.php#L90)
 
 Prepare release.
 
 Clean up unfinished releases and prepare next release
 
 
 ### releases
-[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/release.php#L141)
+[Source](https://github.com/deployphp/deployer/blob/master/recipe/deploy/release.php#L144)
 
 Show releases list.
 

recipe/deploy/release.php

@@ -7,9 +7,7 @@
 // The name of the release.
 set('release_name', function () {
     $latest = run('cat .dep/latest_release || echo 0');
-    $releaseName = strval(intval($latest) + 1);
-    run("echo $releaseName > .dep/latest_release");
-    return $releaseName;
+    return strval(intval($latest) + 1);
 });
 
 // Holds releases log from `.dep/releases_log` file.
@@ -110,6 +108,11 @@
         throw new Exception("Release name \"$releaseName\" already exists.\nRelease name can be overridden via:\n dep deploy -o release_name=$releaseName");
     }
 
+    // Save release_name.
+    if (is_numeric($releaseName) && is_integer(intval($releaseName))) {
+        run("echo $releaseName > .dep/latest_release");
+    }
+
     // Metainfo.
     $timestamp = timestamp();
     $metainfo = [
@@ -155,6 +158,8 @@
         if (in_array($release, $releasesList, true)) {
             if (test("[ -f releases/$release/BAD_RELEASE ]")) {
                 $status = "<error>$release</error> (bad)";
+            } else if (test("[ -f releases/$release/DIRTY_RELEASE ]")) {
+                $status = "<error>$release</error> (dirty)";
             } else {
                 $status = "<info>$release</info>";
             }