Skip to content

Commit 1896108

Browse files
author
Lasim
committed
fix(satellite): adjust shutdown notification handling during tool discovery
1 parent b5317e2 commit 1896108

File tree

1 file changed

+2
-20
lines changed

1 file changed

+2
-20
lines changed

services/satellite/src/services/stdio-tool-discovery-manager.ts

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -85,26 +85,8 @@ export class StdioToolDiscoveryManager {
8585
full_response: JSON.stringify(response)
8686
}, `Received response from ${installationName}`);
8787

88-
// FIXED: Send shutdown notification for clean completion (per MCP spec)
89-
// This ensures the server flushes all tool definitions before we finish discovery
90-
try {
91-
await this.processManager.sendMessage(processInfo, {
92-
jsonrpc: '2.0',
93-
method: 'notifications/shutdown'
94-
}, 5000);
95-
96-
this.logger.debug({
97-
operation: 'stdio_tool_discovery_shutdown_sent',
98-
installation_name: installationName
99-
}, `Sent shutdown notification to ${installationName}`);
100-
} catch (error) {
101-
// Ignore shutdown notification errors - not all servers support it
102-
this.logger.debug({
103-
operation: 'stdio_tool_discovery_shutdown_ignored',
104-
installation_name: installationName,
105-
error: error instanceof Error ? error.message : String(error)
106-
}, `Shutdown notification not supported by ${installationName}`);
107-
}
88+
// The process should remain running for tool execution.
89+
// Shutdown is only sent when the process is being intentionally terminated.
10890

10991
if (!response || !response.tools || !Array.isArray(response.tools)) {
11092
this.logger.warn({

0 commit comments

Comments
 (0)