feat(plugin): enhance onDatabaseInit to include logger for better debugging

Author: Lasim

services/backend/src/db/index.ts

@@ -520,7 +520,7 @@ export function executeDbOperation<T>(
 interface DatabaseExtensionWithTables extends DatabaseExtension {
 
   tableDefinitions?: Record<string, Record<string, (columnBuilder: any) => any>>;
-  onDatabaseInit?: (db: AnyDatabase, schema: AnySchema) => Promise<void>;
+  onDatabaseInit?: (db: AnyDatabase, schema: AnySchema, logger: FastifyBaseLogger) => Promise<void>;
 }
 
 export function registerPluginTables(plugins: Plugin[], logger?: FastifyBaseLogger) {
@@ -560,7 +560,7 @@ export async function initializePluginDatabases(db: AnyDatabase, plugins: Plugin
       }
       try {
         // Create a child logger for this plugin
-        logger.child({ pluginId: plugin.meta.id });
+        const pluginLogger = logger.child({ pluginId: plugin.meta.id });
         // Get the current schema - use dbSchema directly if available, otherwise generate one
         let schema: AnySchema;
         try {
@@ -569,7 +569,7 @@ export async function initializePluginDatabases(db: AnyDatabase, plugins: Plugin
           // If getSchema fails, generate a basic schema for the plugin
           schema = generateSchema();
         }
-        await ext.onDatabaseInit(db, schema);
+        await ext.onDatabaseInit(db, schema, pluginLogger);
         if (!isTestMode()) {
           logger.info({
             operation: 'initialize_plugin_databases',

services/backend/src/plugin-system/types.ts

@@ -77,7 +77,7 @@ export interface DatabaseExtension {
    * Can be used for seeding or additional setup.
    * This is called only if the main database initializes successfully.
    */
-  onDatabaseInit?: (db: AnyDatabase, logger: FastifyBaseLogger) => Promise<void>; // db here will be non-null
+  onDatabaseInit?: (db: AnyDatabase, schema: any, logger: FastifyBaseLogger) => Promise<void>; // db here will be non-null
 }
 
 /**

services/backend/src/plugins/example-plugin/index.ts

@@ -97,20 +97,23 @@ class ExamplePlugin implements Plugin {
     tableDefinitions: examplePluginTableDefinitions, // Use tableDefinitions
 
     // Optional initialization function
-    onDatabaseInit: async (db: AnyDatabase, schema: AnySchema) => {
-      // Note: The function signature expects (db, schema) not (db, logger)
-      // We'll use console.log for now since logger is not available
-      console.log('Initializing example plugin database...');
+    onDatabaseInit: async (db: AnyDatabase, schema: AnySchema, logger: FastifyBaseLogger) => {
+      logger.debug({
+        operation: 'plugin_database_init',
+        pluginId: 'example-plugin'
+      }, 'Initializing example plugin database...');
 
       // Use hardcoded plugin ID since 'this' is not available in arrow function
       const tableNameInSchema = `example-plugin_example_entities`; 
       const table = schema[tableNameInSchema];
 
       if (!table) {
-        console.error('Critical: Table not found in global schema! Cannot initialize database for plugin.', {
+        logger.error({
+          operation: 'plugin_database_init',
+          pluginId: 'example-plugin',
           tableNameInSchema,
           availableTables: Object.keys(schema)
-        });
+        }, 'Critical: Table not found in global schema! Cannot initialize database for plugin.');
         return;
       }
 
@@ -130,7 +133,10 @@ class ExamplePlugin implements Plugin {
       }
 
       if (currentCount === 0) {
-        console.log('Seeding initial data for example plugin...');
+        logger.debug({
+          operation: 'plugin_database_seed',
+          pluginId: 'example-plugin'
+        }, 'Seeding initial data for example plugin...');
         const dataToSeed = {
           id: 'example1',
           name: 'Example Entity',
@@ -142,7 +148,10 @@ class ExamplePlugin implements Plugin {
           // Assume NodePgDatabase-like behavior
           await (db as NodePgDatabase).insert(table as PgTable).values(dataToSeed);
         }
-        console.log('Seeded initial data for example plugin');
+        logger.info({
+          operation: 'plugin_database_seed',
+          pluginId: 'example-plugin'
+        }, 'Seeded initial data for example plugin');
       }
     },
   };