Skip to content

Commit 3ae3fed

Browse files
author
Lasim
committed
refactor(frontend): remove runtime_min_version from MCP forms and views
1 parent 2d13921 commit 3ae3fed

File tree

8 files changed

+2
-36
lines changed

8 files changed

+2
-36
lines changed

services/frontend/src/components/admin/mcp-catalog/McpServerAddFormWizard.vue

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,6 @@ const compatibleFormData = computed((): McpServerFormData => ({
204204
technical: {
205205
language: '',
206206
runtime: 'node',
207-
runtime_min_version: '18.0.0',
208207
installation_methods: [],
209208
dependencies: '',
210209
transport_type: 'auto'
@@ -380,7 +379,6 @@ const submitForm = async () => {
380379
const claudeConfig = formData.value.claudeConfig.claude_desktop_config as any;
381380
let extractedInstallationMethods: any[] = [];
382381
let extractedTransportType = 'stdio';
383-
let extractedTools: any[] = [];
384382
385383
if (claudeConfig && claudeConfig.mcpServers) {
386384
const serverKey = Object.keys(claudeConfig.mcpServers)[0];
@@ -420,11 +418,6 @@ const submitForm = async () => {
420418
extractedTransportType = 'stdio';
421419
}
422420
423-
// Extract tools from configuration schema or create default
424-
extractedTools = [{
425-
name: formData.value.basic.name || 'MCP Tool',
426-
description: formData.value.basic.description || 'MCP Server Tool'
427-
}];
428421
}
429422
}
430423
@@ -461,7 +454,6 @@ const submitForm = async () => {
461454
runtime: extractedTransportType === 'http' || extractedTransportType === 'sse' ? 'http' : 'node',
462455
transport_type: extractedTransportType,
463456
installation_methods: extractedInstallationMethods,
464-
tools: extractedTools,
465457
};
466458
467459
await emit('submit', finalPayload)

services/frontend/src/components/admin/mcp-catalog/McpServerEditFormWizard.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,6 @@ const formData = ref<McpServerFormData>({
262262
technical: {
263263
language: '',
264264
runtime: '',
265-
runtime_min_version: '',
266265
installation_methods: [],
267266
dependencies: '',
268267
transport_type: 'auto'
@@ -452,7 +451,6 @@ const autoPopulateFromGitHub = (githubData: any) => {
452451
technical: {
453452
language: githubData.language || '',
454453
runtime: 'node',
455-
runtime_min_version: githubData.runtime_min_version || '18.0.0',
456454
installation_methods: githubData.installation_methods || [],
457455
dependencies: githubData.dependencies || '',
458456
transport_type: githubData.transport_type || 'auto'

services/frontend/src/components/admin/mcp-catalog/ReviewStep.vue

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -249,12 +249,6 @@ const formatJson = (jsonString: string) => {
249249
</dd>
250250
</div>
251251

252-
<div class="px-4 py-6 sm:grid sm:grid-cols-3 sm:gap-4 sm:px-0">
253-
<dt class="text-sm/6 font-medium text-gray-900">{{ t('mcpCatalog.form.review.fields.minimumVersion') }}</dt>
254-
<dd class="mt-1 text-sm/6 text-gray-700 sm:col-span-2 sm:mt-0">
255-
{{ getTechnicalData().runtime_min_version || t('mcpCatalog.form.review.values.notSpecified') }}
256-
</dd>
257-
</div>
258252

259253
<div v-if="claudeConfig || (getTechnicalData().installation_methods && getTechnicalData().installation_methods.length > 0)" class="px-4 py-6 sm:grid sm:grid-cols-3 sm:gap-4 sm:px-0">
260254
<dt class="text-sm/6 font-medium text-gray-900">{{ t('mcpCatalog.form.review.fields.claudeDesktopConfiguration') }}</dt>

services/frontend/src/components/admin/mcp-catalog/TechnicalStep.vue

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ const isEditMode = computed(() => props.mode === 'edit')
4242
const localData = ref<TechnicalFormData>({
4343
language: '',
4444
runtime: '',
45-
runtime_min_version: '',
4645
installation_methods: [],
4746
dependencies: '',
4847
transport_type: isEditMode.value ? 'stdio' : 'auto'

services/frontend/src/views/admin/mcp-server-catalog/edit/[id].vue

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,6 @@ const convertServerToFormData = (server: McpServer): Partial<McpServerFormData>
211211
technical: {
212212
language: server.language || '',
213213
runtime: server.runtime || '',
214-
runtime_min_version: server.runtime_min_version || '',
215214
installation_methods: convertedInstallationMethods,
216215
dependencies: server.dependencies ? JSON.stringify(server.dependencies, null, 2) : '',
217216
transport_type: server.transport_type || 'auto'
@@ -232,8 +231,7 @@ const handleSubmit = async (formData: McpServerFormData) => {
232231
const server = serverData.value
233232
if (!server) return
234233
235-
// Parse tools, resources, and prompts from server data
236-
const parsedTools = parseJsonField(server.tools, [])
234+
// Parse resources and prompts from server data
237235
const parsedResources = parseJsonField(server.resources, [])
238236
const parsedPrompts = parseJsonField(server.prompts, [])
239237
@@ -305,7 +303,6 @@ const handleSubmit = async (formData: McpServerFormData) => {
305303
// Technical
306304
language: formData.technical.language,
307305
runtime: formData.technical.runtime,
308-
runtime_min_version: formData.technical.runtime_min_version || undefined,
309306
installation_methods: formData.technical.installation_methods,
310307
dependencies: formData.technical.dependencies ? JSON.parse(formData.technical.dependencies) : undefined,
311308
@@ -320,8 +317,7 @@ const handleSubmit = async (formData: McpServerFormData) => {
320317
user_env_schema: finalConfigurationSchema.user_env_schema,
321318
user_headers_schema: finalConfigurationSchema.user_headers_schema,
322319
323-
// Tools, resources, and prompts (from server data)
324-
tools: parsedTools,
320+
// Resources and prompts (from server data)
325321
resources: parsedResources.length > 0 ? parsedResources : undefined,
326322
prompts: parsedPrompts.length > 0 ? parsedPrompts : undefined,
327323
transport_type: formData.technical.transport_type !== 'auto' ? formData.technical.transport_type as 'stdio' | 'http' | 'sse' : undefined

services/frontend/src/views/admin/mcp-server-catalog/types.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ export interface McpServer {
1111
homepage_url?: string
1212
language: string
1313
runtime: string
14-
runtime_min_version?: string
1514
installation_methods: InstallationMethod[]
16-
tools: McpTool[]
1715
resources?: McpResource[]
1816
prompts?: McpPrompt[]
1917
visibility: 'global' | 'team'
@@ -178,9 +176,7 @@ export interface CreateMcpServerRequest {
178176
homepage_url?: string
179177
language?: string
180178
runtime?: string
181-
runtime_min_version?: string
182179
installation_methods?: InstallationMethod[]
183-
tools?: McpTool[]
184180
resources?: McpResource[]
185181
prompts?: McpPrompt[]
186182
visibility: 'global' | 'team'
@@ -219,9 +215,7 @@ export interface UpdateMcpServerRequest {
219215
homepage_url?: string
220216
language?: string
221217
runtime?: string
222-
runtime_min_version?: string
223218
installation_methods?: InstallationMethod[]
224-
tools?: McpTool[]
225219
resources?: McpResource[]
226220
prompts?: McpPrompt[]
227221
author_name?: string
@@ -283,7 +277,6 @@ export interface RepositoryFormData {
283277
export interface TechnicalFormData {
284278
language: string
285279
runtime: string
286-
runtime_min_version: string
287280
installation_methods: InstallationMethod[]
288281
dependencies: string
289282
transport_type: string

services/frontend/src/views/admin/mcp-server-catalog/view/[id].vue

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -392,9 +392,6 @@ const goBack = () => {
392392
</Badge>
393393
</div>
394394
<div><span class="font-medium">{{ t('mcpCatalog.edit.values.runtime') }}</span> {{ server.runtime }}</div>
395-
<div v-if="server.runtime_min_version">
396-
<span class="font-medium">{{ t('mcpCatalog.edit.values.minVersion') }}</span> {{ server.runtime_min_version }}
397-
</div>
398395
<div><span class="font-medium">{{ t('mcpCatalog.edit.values.license') }}</span> {{ server.license || t('mcpCatalog.edit.values.notProvided') }}</div>
399396
</div>
400397
</dd>

services/frontend/src/views/mcp-server/view/[id].vue

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -300,9 +300,6 @@ const installServer = () => {
300300
</Badge>
301301
</div>
302302
<div><span class="font-medium">{{ t('mcpInstallations.view.values.runtime') }}</span> {{ server.runtime }}</div>
303-
<div v-if="server.runtime_min_version">
304-
<span class="font-medium">{{ t('mcpInstallations.view.values.minVersion') }}</span> {{ server.runtime_min_version }}
305-
</div>
306303
<div><span class="font-medium">{{ t('mcpInstallations.view.values.license') }}</span> {{ server.license || t('mcpInstallations.view.values.notProvided') }}</div>
307304
</div>
308305
</dd>

0 commit comments

Comments
 (0)