feat(backend): add email notifications for MCP installation events

Lasim · Lasim · commit 448e68710730 · 2025-12-04T12:58:23.000+01:00
diff --git a/services/backend/src/email/templates/mcp-installation-created.pug b/services/backend/src/email/templates/mcp-installation-created.pug
@@ -0,0 +1,32 @@
+//- @description Email notification when an MCP server is installed to a team
+//- @variables userName, serverName, serverDescription, teamName, dashboardUrl
+extends layouts/base.pug
+
+block content
+  h1 MCP Server Installed
+
+  p Hi #{userName},
+
+  p
+    | The MCP server
+    strong #{serverName}
+    |  has been successfully installed to team
+    strong #{teamName}
+    | .
+
+  if serverDescription
+    .server-info
+      p
+        strong About this server:
+      p= serverDescription
+
+  p You can now use this MCP server in your AI coding assistant.
+
+  if dashboardUrl
+    .text-center
+      a.button(href=dashboardUrl) View in Dashboard
+
+  p.text-muted
+    | Best regards,
+    br
+    | The DeployStack Team
diff --git a/services/backend/src/email/templates/mcp-installation-deleted.pug b/services/backend/src/email/templates/mcp-installation-deleted.pug
@@ -0,0 +1,28 @@
+//- @description Email notification when an MCP server is removed from a team
+//- @variables userName, serverName, serverDescription, teamName
+extends layouts/base.pug
+
+block content
+  h1 MCP Server Removed
+
+  p Hi #{userName},
+
+  p
+    | The MCP server
+    strong #{serverName}
+    |  has been removed from team
+    strong #{teamName}
+    | .
+
+  if serverDescription
+    .server-info
+      p
+        strong Server that was removed:
+      p= serverDescription
+
+  p This MCP server is no longer available for use in your team. If you need to use it again, a team administrator can reinstall it from the MCP catalog.
+
+  p.text-muted
+    | Best regards,
+    br
+    | The DeployStack Team
diff --git a/services/backend/src/email/types.ts b/services/backend/src/email/types.ts
@@ -137,6 +137,21 @@ export interface TestEmailVariables {
   supportEmail?: string;
 }
 
+export interface McpInstallationCreatedEmailVariables {
+  userName: string;
+  serverName: string;
+  serverDescription?: string;
+  teamName: string;
+  dashboardUrl?: string;
+}
+
+export interface McpInstallationDeletedEmailVariables {
+  userName: string;
+  serverName: string;
+  serverDescription?: string;
+  teamName: string;
+}
+
 // Template registry for type safety
 export interface TemplateVariableMap {
   welcome: WelcomeEmailVariables;
@@ -145,6 +160,8 @@ export interface TemplateVariableMap {
   'email-verification': EmailVerificationVariables;
   'password-changed': PasswordChangedEmailVariables;
   test: TestEmailVariables;
+  'mcp-installation-created': McpInstallationCreatedEmailVariables;
+  'mcp-installation-deleted': McpInstallationDeletedEmailVariables;
 }
 
 export type TemplateNames = keyof TemplateVariableMap;
diff --git a/services/backend/src/routes/mcp/installations/create.ts b/services/backend/src/routes/mcp/installations/create.ts
@@ -4,6 +4,7 @@ import { requireTeamPermission } from '../../../middleware/roleMiddleware';
 import { McpInstallationService } from '../../../services/mcpInstallationService';
 import { McpUserConfigurationService } from '../../../services/mcpUserConfigurationService';
 import { SatelliteCommandService } from '../../../services/satelliteCommandService';
+import { McpInstallationNotificationService } from '../../../services/mcpInstallationNotificationService';
 import { getDb } from '../../../db';
 import {
   TEAM_ID_PARAM_SCHEMA,
@@ -203,6 +204,18 @@ export default async function createInstallationRoute(server: FastifyInstance) {
         // Don't fail installation creation if event emission fails
       }
 
+      // Queue email notifications to all team members
+      try {
+        const notificationService = new McpInstallationNotificationService(db, request.log);
+        await notificationService.notifyInstallationCreated(
+          installationData.server_id,
+          teamId
+        );
+      } catch (notificationError) {
+        request.log.error(notificationError, `Failed to queue installation notification emails for installation ${installation.id}:`);
+        // Don't fail installation creation if notification fails
+      }
+
       const response: InstallationSuccessResponse = {
         success: true,
         data: formatInstallationResponse(installation)
diff --git a/services/backend/src/services/mcpInstallationNotificationService.ts b/services/backend/src/services/mcpInstallationNotificationService.ts
@@ -0,0 +1,203 @@
+import { eq } from 'drizzle-orm';
+import type { AnyDatabase } from '../db';
+import type { FastifyBaseLogger } from 'fastify';
+import { getSchema } from '../db';
+import { JobQueueService } from './jobQueueService';
+
+/**
+ * Service for sending email notifications when MCP servers are installed or removed
+ */
+export class McpInstallationNotificationService {
+  private readonly db: AnyDatabase;
+  private readonly logger: FastifyBaseLogger;
+  private readonly jobQueueService: JobQueueService;
+
+  constructor(db: AnyDatabase, logger: FastifyBaseLogger) {
+    this.db = db;
+    this.logger = logger;
+    this.jobQueueService = new JobQueueService(db, logger);
+  }
+
+  /**
+   * Send installation created notifications to all team members
+   */
+  async notifyInstallationCreated(
+    serverId: string,
+    teamId: string
+  ): Promise<void> {
+    try {
+      const serverInfo = await this.getServerInfo(serverId);
+      const teamInfo = await this.getTeamInfo(teamId);
+      const teamMembers = await this.getTeamMembers(teamId);
+
+      if (!serverInfo || !teamInfo) {
+        this.logger.warn({
+          operation: 'mcp_installation_notification',
+          serverId,
+          teamId,
+          serverFound: !!serverInfo,
+          teamFound: !!teamInfo
+        }, 'Cannot send notification: server or team not found');
+        return;
+      }
+
+      if (teamMembers.length === 0) {
+        this.logger.warn({
+          operation: 'mcp_installation_notification',
+          teamId
+        }, 'No team members found to notify');
+        return;
+      }
+
+      // Queue email for each team member
+      for (const member of teamMembers) {
+        await this.jobQueueService.createJob('send_email', {
+          to: member.email,
+          subject: `MCP Server Installed - ${serverInfo.name}`,
+          template: 'mcp-installation-created',
+          variables: {
+            userName: member.username || member.email,
+            serverName: serverInfo.name,
+            serverDescription: serverInfo.description || '',
+            teamName: teamInfo.name,
+            dashboardUrl: 'https://cloud.deploystack.io/dashboard'
+          }
+        });
+      }
+
+      this.logger.info({
+        operation: 'mcp_installation_notification',
+        event: 'created',
+        serverName: serverInfo.name,
+        teamName: teamInfo.name,
+        recipientCount: teamMembers.length
+      }, `Queued ${teamMembers.length} installation notification emails`);
+
+    } catch (error) {
+      this.logger.error({
+        operation: 'mcp_installation_notification',
+        event: 'created',
+        error: error instanceof Error ? error.message : String(error)
+      }, 'Failed to queue installation notification emails');
+    }
+  }
+
+  /**
+   * Send installation deleted notifications to all team members
+   */
+  async notifyInstallationDeleted(
+    serverName: string,
+    serverDescription: string,
+    teamId: string
+  ): Promise<void> {
+    try {
+      const teamInfo = await this.getTeamInfo(teamId);
+      const teamMembers = await this.getTeamMembers(teamId);
+
+      if (!teamInfo) {
+        this.logger.warn({
+          operation: 'mcp_installation_notification',
+          teamId
+        }, 'Cannot send notification: team not found');
+        return;
+      }
+
+      if (teamMembers.length === 0) {
+        this.logger.warn({
+          operation: 'mcp_installation_notification',
+          teamId
+        }, 'No team members found to notify');
+        return;
+      }
+
+      // Queue email for each team member
+      for (const member of teamMembers) {
+        await this.jobQueueService.createJob('send_email', {
+          to: member.email,
+          subject: `MCP Server Removed - ${serverName}`,
+          template: 'mcp-installation-deleted',
+          variables: {
+            userName: member.username || member.email,
+            serverName: serverName,
+            serverDescription: serverDescription || '',
+            teamName: teamInfo.name
+          }
+        });
+      }
+
+      this.logger.info({
+        operation: 'mcp_installation_notification',
+        event: 'deleted',
+        serverName: serverName,
+        teamName: teamInfo.name,
+        recipientCount: teamMembers.length
+      }, `Queued ${teamMembers.length} removal notification emails`);
+
+    } catch (error) {
+      this.logger.error({
+        operation: 'mcp_installation_notification',
+        event: 'deleted',
+        error: error instanceof Error ? error.message : String(error)
+      }, 'Failed to queue removal notification emails');
+    }
+  }
+
+  /**
+   * Get server information from database
+   */
+  private async getServerInfo(
+    serverId: string
+  ): Promise<{ name: string; description: string | null } | null> {
+    const schema = getSchema();
+    const result = await this.db
+      .select({
+        name: schema.mcpServers.name,
+        description: schema.mcpServers.description
+      })
+      .from(schema.mcpServers)
+      .where(eq(schema.mcpServers.id, serverId))
+      .limit(1);
+
+    return result[0] || null;
+  }
+
+  /**
+   * Get team information from database
+   */
+  private async getTeamInfo(
+    teamId: string
+  ): Promise<{ name: string } | null> {
+    const schema = getSchema();
+    const result = await this.db
+      .select({
+        name: schema.teams.name
+      })
+      .from(schema.teams)
+      .where(eq(schema.teams.id, teamId))
+      .limit(1);
+
+    return result[0] || null;
+  }
+
+  /**
+   * Get all team members with their email addresses
+   */
+  private async getTeamMembers(
+    teamId: string
+  ): Promise<Array<{ email: string; username: string | null }>> {
+    const schema = getSchema();
+    const result = await this.db
+      .select({
+        email: schema.authUser.email,
+        username: schema.authUser.username
+      })
+      .from(schema.teamMemberships)
+      .innerJoin(
+        schema.authUser,
+        eq(schema.teamMemberships.user_id, schema.authUser.id)
+      )
+      .where(eq(schema.teamMemberships.team_id, teamId));
+
+    return result;
+  }
+}
diff --git a/services/backend/src/workers/mcpServerCascadeDeletionWorker.ts b/services/backend/src/workers/mcpServerCascadeDeletionWorker.ts
@@ -7,6 +7,7 @@ import { EVENT_NAMES } from '../events';
 import { McpInstallationService } from '../services/mcpInstallationService';
 import { McpCatalogService } from '../services/mcpCatalogService';
 import { SatelliteCommandService } from '../services/satelliteCommandService';
+import { McpInstallationNotificationService } from '../services/mcpInstallationNotificationService';
 
 /**
  * Payload interface for MCP server cascade deletion jobs
@@ -40,6 +41,7 @@ export class McpServerCascadeDeletionWorker implements Worker {
   private installationService: McpInstallationService;
   private catalogService: McpCatalogService;
   private satelliteCommandService: SatelliteCommandService;
+  private notificationService: McpInstallationNotificationService;
 
   constructor(
     private readonly db: AnyDatabase,
@@ -49,6 +51,7 @@ export class McpServerCascadeDeletionWorker implements Worker {
     this.installationService = new McpInstallationService(this.db, this.logger);
     this.catalogService = new McpCatalogService(this.db, this.logger);
     this.satelliteCommandService = new SatelliteCommandService(this.db, this.logger);
+    this.notificationService = new McpInstallationNotificationService(this.db, this.logger);
   }
 
   async execute(payload: unknown, jobId: string): Promise<WorkerResult> {
@@ -106,6 +109,7 @@ export class McpServerCascadeDeletionWorker implements Worker {
             installation,
             serverId,
             serverName,
+            serverDescription,
             deletedBy,
             metadata,
             jobId
@@ -203,6 +207,7 @@ export class McpServerCascadeDeletionWorker implements Worker {
     },
     serverId: string,
     serverName: string,
+    serverDescription: string,
     deletedBy: { id: string; email: string },
     metadata: { ip: string },
     jobId: string
@@ -226,6 +231,24 @@ export class McpServerCascadeDeletionWorker implements Worker {
       metadata
     );
 
+    // Queue email notifications to all team members
+    try {
+      await this.notificationService.notifyInstallationDeleted(
+        serverName,
+        serverDescription,
+        teamId
+      );
+    } catch (notificationError) {
+      this.logger.warn({
+        jobId,
+        installationId,
+        teamId,
+        error: notificationError instanceof Error ? notificationError.message : String(notificationError),
+        operation: 'mcp_server_cascade_delete_notification_error'
+      }, 'Failed to queue notification emails, continuing with deletion');
+      // Don't fail the installation deletion if notification fails
+    }
+
     // Notify satellites to refresh configuration
     try {
       const commands = await this.satelliteCommandService.notifyMcpInstallation(
