refactor: update parameter schemas to use type-only definitions for consistency

Author: Lasim

services/backend/src/routes/mcp/categories/delete.ts

@@ -5,10 +5,10 @@ import { requirePermission } from '../../../middleware/roleMiddleware';
 import { McpCategoriesService } from '../../../services/mcpCategoriesService';
 import { getDb } from '../../../db';
 
-// Path parameter schema
-const deleteCategoryParamsSchema = z.object({
-  id: z.string().min(1, 'Category ID is required')
-});
+// Path parameter schema (type-only)
+type DeleteCategoryParams = {
+  id: string;
+};
 
 // Response schemas
 const deleteCategoryResponseSchema = z.object({
@@ -47,7 +47,7 @@ export default async function deleteCategory(server: FastifyInstance) {
       }
     }
   }, async (request, reply) => {
-    const { id } = request.params as z.infer<typeof deleteCategoryParamsSchema>;
+    const { id } = request.params as DeleteCategoryParams;
 
     request.log.info({
       operation: 'delete_mcp_category',

services/backend/src/routes/mcp/categories/update.ts

@@ -5,10 +5,10 @@ import { requirePermission } from '../../../middleware/roleMiddleware';
 import { McpCategoriesService } from '../../../services/mcpCategoriesService';
 import { getDb } from '../../../db';
 
-// Path parameter schema
-const updateCategoryParamsSchema = z.object({
-  id: z.string().min(1, 'Category ID is required')
-});
+// Path parameter schema (type-only)
+type UpdateCategoryParams = {
+  id: string;
+};
 
 // Request schema
 const updateCategoryRequestSchema = z.object({
@@ -83,7 +83,7 @@ export default async function updateCategory(server: FastifyInstance) {
       }
     }
   }, async (request, reply) => {
-    const { id } = request.params as z.infer<typeof updateCategoryParamsSchema>;
+    const { id } = request.params as UpdateCategoryParams;
     const updateData = request.body as z.infer<typeof updateCategoryRequestSchema>;
 
     request.log.info({

services/backend/src/routes/mcp/installations/create.ts

@@ -5,13 +5,13 @@ import { requireTeamPermission } from '../../../middleware/roleMiddleware';
 import { McpInstallationService } from '../../../services/mcpInstallationService';
 import { getDb } from '../../../db';
 
-// Request schema
-const createInstallationSchema = z.object({
-  server_id: z.string().min(1, 'Server ID is required'),
-  installation_name: z.string().min(1, 'Installation name is required').max(100, 'Installation name too long'),
-  installation_type: z.enum(['local', 'cloud']).optional().default('local'),
-  user_environment_variables: z.record(z.string(), z.string()).optional()
-});
+// Request schema (type-only)
+type CreateInstallationRequest = {
+  server_id: string;
+  installation_name: string;
+  installation_type?: 'local' | 'cloud';
+  user_environment_variables?: Record<string, string>;
+};
 
 // Response schemas
 const successResponseSchema = z.object({
@@ -46,7 +46,7 @@ const errorResponseSchema = z.object({
 export default async function createInstallationRoute(fastify: FastifyInstance) {
   fastify.post<{
     Params: { teamId: string };
-    Body: z.infer<typeof createInstallationSchema>;
+    Body: CreateInstallationRequest;
   }>('/teams/:teamId/mcp/installations', {
     schema: {
       tags: ['MCP Installations'],

services/backend/src/routes/mcp/servers/search.ts

@@ -7,17 +7,6 @@ import { getUserRole, requirePermission } from '../../../middleware/roleMiddlewa
 import { getDb } from '../../../db';
 
 
-// Query parameters schema for documentation (without transforms)
-const searchServersQuerySchemaDoc = z.object({
-  q: z.string().min(1, 'Search query is required').max(255, 'Search query must be 255 characters or less'),
-  category: z.string().optional(),
-  language: z.string().optional(),
-  runtime: z.string().optional(),
-  status: z.enum(['active', 'deprecated', 'maintenance']).optional(),
-  featured: z.enum(['true', 'false']).optional().describe('Filter by featured status'),
-  limit: z.string().regex(/^\d+$/).optional().describe('Limit must be a number between 1 and 100'),
-  offset: z.string().regex(/^\d+$/).optional().describe('Offset must be non-negative')
-});
 
 // Response schema for search results
 const searchServersResponseSchema = z.object({