fix(gateway): simplify error handling in login command

Author: Lasim

services/gateway/src/commands/login.ts

@@ -60,7 +60,7 @@ export function registerLoginCommand(program: Command) {
             spinner.succeed('Credentials stored securely');
             console.log(chalk.yellow('⚠️  No default team found - you may need to select a team manually'));
           }
-        } catch (teamError) {
+        } catch {
           spinner.succeed('Credentials stored securely');
           console.log(chalk.yellow('⚠️  Could not auto-select default team - you can select one later'));
         }

services/gateway/src/core/auth/api-client.ts

@@ -1,5 +1,6 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import fetch from 'node-fetch';
-import { StoredCredentials, UserInfo, TokenInfo, Team, TeamsResponse, AuthError, AuthenticationError } from '../../types/auth';
+import { StoredCredentials, UserInfo, TokenInfo, Team, AuthError, AuthenticationError } from '../../types/auth';
 import { buildAuthConfig } from '../../utils/auth-config';
 
 export class DeployStackAPI {
@@ -128,7 +129,7 @@ export class DeployStackAPI {
       } else {
         errorData = { error: await response.text() };
       }
-    } catch (parseError) {
+    } catch {
       errorData = { error: 'Unknown error' };
     }
 

services/gateway/src/core/auth/browser.ts

@@ -60,7 +60,7 @@ export class BrowserManager {
     try {
       await this.openBrowser(url);
       console.log(chalk.green('🌐 Opened browser to authorization page'));
-    } catch (error) {
+    } catch {
       this.displayUrlForManualOpening(url);
     }
   }

services/gateway/src/core/auth/oauth.ts

@@ -70,6 +70,7 @@ export class OAuth2Client {
             'Authentication timeout - no response received within the specified time'
           )), timeout)
         )
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
       ]) as any;
 
       if (callbackResult.error) {
@@ -173,6 +174,7 @@ export class OAuth2Client {
       });
 
       if (!response.ok) {
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
         const errorData = await response.json().catch(() => ({ error: 'unknown_error' })) as any;
         throw new AuthenticationError(
           AuthError.INVALID_GRANT,
@@ -250,6 +252,7 @@ export class OAuth2Client {
       });
 
       if (!response.ok) {
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
         const errorData = await response.json().catch(() => ({ error: 'unknown_error' })) as any;
         throw new AuthenticationError(
           AuthError.INVALID_GRANT,

services/gateway/src/core/auth/storage.ts

@@ -1,4 +1,4 @@
-import { keyring } from '@zowe/secrets-for-zowe-sdk';
+ import { keyring } from '@zowe/secrets-for-zowe-sdk';
 import { writeFileSync, readFileSync, existsSync, unlinkSync } from 'fs';
 import { join } from 'path';
 import { homedir } from 'os';
@@ -70,7 +70,7 @@ export class CredentialStorage {
       } else {
         // REMOVED: console.log('⚠ No credentials found in encrypted file');
       }
-    } catch (error) {
+    } catch {
       // REMOVED: console.log('❌ Error reading encrypted file:', (error as Error)?.message);
     }
 
@@ -90,15 +90,15 @@ export class CredentialStorage {
               // REMOVED: console.log('✓ Found credentials in OS keychain for:', account);
               return credentials;
             }
-          } catch (error) {
+          } catch {
             // REMOVED: console.log('⚠ Failed to retrieve credentials for account:', account);
             continue;
           }
         }
       } else {
         // REMOVED: console.log('⚠ No accounts found in keychain');
       }
-    } catch (error) {
+    } catch {
       // REMOVED: console.log('❌ Error accessing keychain:', (error as Error)?.message);
     }
 
@@ -152,13 +152,13 @@ export class CredentialStorage {
         for (const account of accounts) {
           try {
             await keyring.deletePassword(this.serviceName, account);
-          } catch (error) {
+          } catch {
             // Continue clearing other accounts even if one fails
           }
         }
         await this.clearAccountsList();
       }
-    } catch (error) {
+    } catch {
       // Continue to clear encrypted file even if keychain fails
     }
 
@@ -183,7 +183,7 @@ export class CredentialStorage {
       const buffer = 5 * 60 * 1000; // 5 minutes
 
       return expiresAt > (now + buffer);
-    } catch (error) {
+    } catch {
       return false;
     }
   }
@@ -199,7 +199,7 @@ export class CredentialStorage {
         const accounts = JSON.parse(data);
         return Array.isArray(accounts) ? accounts : [];
       }
-    } catch (error) {
+    } catch {
       // If we can't read the accounts file, return empty array
     }
     return [];
@@ -215,7 +215,7 @@ export class CredentialStorage {
       const { mkdirSync } = await import('fs');
       try {
         mkdirSync(this.fallbackDir, { recursive: true });
-      } catch (error) {
+      } catch {
         // Directory might already exist
       }
 
@@ -241,7 +241,7 @@ export class CredentialStorage {
       if (filtered.length !== accounts.length) {
         writeFileSync(this.accountsFile, JSON.stringify(filtered, null, 2));
       }
-    } catch (error) {
+    } catch {
       // Non-critical error, don't throw
     }
   }
@@ -254,7 +254,7 @@ export class CredentialStorage {
       if (existsSync(this.accountsFile)) {
         unlinkSync(this.accountsFile);
       }
-    } catch (error) {
+    } catch {
       // Non-critical error, don't throw
     }
   }
@@ -269,7 +269,7 @@ export class CredentialStorage {
       const { mkdirSync } = await import('fs');
       try {
         mkdirSync(this.fallbackDir, { recursive: true });
-      } catch (error) {
+      } catch {
         // Directory might already exist
       }
 
@@ -311,11 +311,11 @@ export class CredentialStorage {
       decrypted += decipher.final('utf8');
 
       return JSON.parse(decrypted);
-    } catch (error) {
+    } catch {
       // If we can't decrypt, the file might be corrupted
       try {
         unlinkSync(this.fallbackFile);
-      } catch (unlinkError) {
+      } catch {
         // Ignore unlink errors
       }
       return null;
@@ -330,7 +330,7 @@ export class CredentialStorage {
       if (existsSync(this.fallbackFile)) {
         unlinkSync(this.fallbackFile);
       }
-    } catch (error) {
+    } catch {
       // Ignore errors when clearing
     }
   }

services/gateway/src/index.ts

@@ -1,7 +1,6 @@
 #!/usr/bin/env node
 
 import { Command } from 'commander';
-import chalk from 'chalk';
 import { getVersionString } from './config/version';
 import {
   registerLoginCommand,

services/gateway/src/types/mcp.ts

@@ -8,10 +8,12 @@ export interface MCPServer {
   env?: Record<string, string>;
 }
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 export interface MCPRequest {
   // Placeholder for MCP request types
 }
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 export interface MCPResponse {
   // Placeholder for MCP response types
 }