refactor(backend): separate team settings into dedicated settings group

Move team-related settings from global settings group to new team settings group. Changes setting keys from global.team_* to team.* format for better organization.

- Create team.ts settings file with 4 team settings
- Remove team settings from global.ts
- Update references in teamService.ts and createTeam.ts

Author: Lasim

services/backend/src/global-settings/global.ts

@@ -63,24 +63,6 @@ export const globalSettings: GlobalSettingsModule = {
       encrypted: false,
       required: false
     },
-    {
-      key: 'global.team_member_limit',
-      name: 'Team Member Limit',
-      defaultValue: 3,
-      type: 'number',
-      description: 'Maximum number of members allowed in non-default teams. Default teams are always limited to 1 member (the owner).',
-      encrypted: false,
-      required: false
-    },
-    {
-      key: 'global.team_creation_limit',
-      name: 'Team Creation Limit',
-      defaultValue: 3,
-      type: 'number',
-      description: 'Maximum number of teams a user can create, including both default and custom teams.',
-      encrypted: false,
-      required: false
-    },
     {
       key: 'global.send_welcome_email',
       name: 'Send Welcome Email',
@@ -98,24 +80,6 @@ export const globalSettings: GlobalSettingsModule = {
       description: 'Display onboarding walkthrough for users who have not completed or cancelled it.',
       encrypted: false,
       required: false
-    },
-    {
-      key: 'global.default_non_http_mcp_limit',
-      name: 'Default Non-HTTP MCP Limit',
-      defaultValue: 1,
-      type: 'number',
-      description: 'Maximum number of non-HTTP (stdio) MCP servers per team. Applied when a new team is created. HTTP and SSE servers are not affected.',
-      encrypted: false,
-      required: false
-    },
-    {
-      key: 'global.default_mcp_server_limit',
-      name: 'Default MCP Server Limit',
-      defaultValue: 5,
-      type: 'number',
-      description: 'Maximum total number of MCP server installations per team. Applied when a new team is created. Includes all transport types (HTTP, SSE, stdio).',
-      encrypted: false,
-      required: false
     }
   ]
 };

services/backend/src/global-settings/team.ts

@@ -0,0 +1,49 @@
+import type { GlobalSettingsModule } from './types';
+
+export const teamSettings: GlobalSettingsModule = {
+  group: {
+    id: 'team',
+    name: 'Team Settings',
+    description: 'Team management and limit configuration',
+    icon: 'users',
+    sort_order: 2
+  },
+  settings: [
+    {
+      key: 'team.member_limit',
+      name: 'Team Member Limit',
+      defaultValue: 3,
+      type: 'number',
+      description: 'Maximum number of members allowed in non-default teams. Default teams are always limited to 1 member (the owner).',
+      encrypted: false,
+      required: false
+    },
+    {
+      key: 'team.creation_limit',
+      name: 'Team Creation Limit',
+      defaultValue: 3,
+      type: 'number',
+      description: 'Maximum number of teams a user can create, including both default and custom teams.',
+      encrypted: false,
+      required: false
+    },
+    {
+      key: 'team.default_non_http_mcp_limit',
+      name: 'Default Non-HTTP MCP Limit',
+      defaultValue: 1,
+      type: 'number',
+      description: 'Maximum number of non-HTTP (stdio) MCP servers per team. Applied when a new team is created. HTTP and SSE servers are not affected.',
+      encrypted: false,
+      required: false
+    },
+    {
+      key: 'team.default_mcp_server_limit',
+      name: 'Default MCP Server Limit',
+      defaultValue: 5,
+      type: 'number',
+      description: 'Maximum total number of MCP server installations per team. Applied when a new team is created. Includes all transport types (HTTP, SSE, stdio).',
+      encrypted: false,
+      required: false
+    }
+  ]
+};

services/backend/src/routes/teams/createTeam.ts

@@ -78,7 +78,7 @@ export default async function createTeamRoute(server: FastifyInstance) {
       if (!canCreate) {
         // Get the current team limit for a proper error message
         const { GlobalSettings } = await import('../../global-settings/helpers');
-        const teamLimit = await GlobalSettings.getNumber('global.team_creation_limit', 3);
+        const teamLimit = await GlobalSettings.getNumber('team.creation_limit', 3);
         const errorResponse: ErrorResponse = {
           success: false,
           error: `You have reached the maximum limit of ${teamLimit} teams`

services/backend/src/services/teamService.ts

@@ -134,11 +134,11 @@ export class TeamService {
     // Get the default MCP limits from global settings if not provided
     const nonHttpMcpLimit = data.non_http_mcp_limit !== undefined
       ? data.non_http_mcp_limit
-      : await GlobalSettings.getNumber('global.default_non_http_mcp_limit', 1);
+      : await GlobalSettings.getNumber('team.default_non_http_mcp_limit', 1);
 
     const mcpServerLimit = data.mcp_server_limit !== undefined
       ? data.mcp_server_limit
-      : await GlobalSettings.getNumber('global.default_mcp_server_limit', 5);
+      : await GlobalSettings.getNumber('team.default_mcp_server_limit', 5);
 
     // Create the team
     const teamData = {
@@ -253,7 +253,7 @@ export class TeamService {
    */
   static async canUserCreateTeam(userId: string): Promise<boolean> {
     const teamCount = await this.getUserTeamCount(userId);
-    const teamLimit = await GlobalSettings.getNumber('global.team_creation_limit', 3);
+    const teamLimit = await GlobalSettings.getNumber('team.creation_limit', 3);
     return teamCount < teamLimit;
   }
 
@@ -722,8 +722,8 @@ export class TeamService {
     }
 
     // Get team member limit from global settings
-    const memberLimit = await GlobalSettings.getNumber('global.team_member_limit', 3);
-    
+    const memberLimit = await GlobalSettings.getNumber('team.member_limit', 3);
+
     // Check if team has less than the configured limit
     const memberCount = await this.getTeamMemberCount(teamId);
     return memberCount < memberLimit;
@@ -829,7 +829,7 @@ export class TeamService {
         throw new Error('Cannot add members to default teams');
       } else {
         // Get the actual limit for the error message
-        const memberLimit = await GlobalSettings.getNumber('global.team_member_limit', 3);
+        const memberLimit = await GlobalSettings.getNumber('team.member_limit', 3);
         throw new Error(`Team has reached maximum capacity (${memberLimit} members)`);
       }
     }