feat: enhance global settings handling with proper type conversion for boolean and number values

Author: Lasim

services/backend/src/routes/globalSettings/index.ts

@@ -665,9 +665,17 @@ export default async function globalSettingsRoute(fastify: FastifyInstance) {
 
       for (const settingData of settings) {
         try {
+          // Convert value to proper type if needed
+          let processedValue = settingData.value;
+          if (settingData.type === 'boolean' && typeof settingData.value === 'string') {
+            processedValue = settingData.value.toLowerCase() === 'true';
+          } else if (settingData.type === 'number' && typeof settingData.value === 'string') {
+            processedValue = Number(settingData.value);
+          }
+          
           const setting = await GlobalSettingsService.setTyped(
             settingData.key,
-            settingData.value,
+            processedValue,
             settingData.type,
             {
               description: settingData.description,
@@ -677,6 +685,7 @@ export default async function globalSettingsRoute(fastify: FastifyInstance) {
           );
           results.push(setting);
         } catch (error) {
+          fastify.log.error(`Error processing setting ${settingData.key}:`, error);
           errors.push({
             key: settingData.key,
             error: error instanceof Error ? error.message : 'Unknown error',

services/backend/src/services/passwordResetService.ts

@@ -121,7 +121,7 @@ export class PasswordResetService {
         return { success: false, error: 'User not found or not eligible for password reset' };
       }
 
-      const user = users[0];
+      // const user = users[0];
 
       // Hash new password
       const hashedNewPassword = await hash(newPassword, {

services/frontend/src/views/admin/GlobalSettings.vue

@@ -140,9 +140,20 @@ async function handleSubmit(event: Event) {
   // Convert form values to API format
   const settingsToUpdate = Object.entries(formValues.value).map(([key, value]) => {
     const setting = selectedGroup.value?.settings?.find(s => s.key === key)
+
+    // Ensure proper type conversion based on setting type
+    let typedValue = value
+    if (setting?.type === 'boolean') {
+      typedValue = Boolean(value)
+    } else if (setting?.type === 'number') {
+      typedValue = Number(value)
+    } else {
+      typedValue = String(value)
+    }
+
     return {
       key,
-      value: value, // API expects typed values (string, number, boolean)
+      value: typedValue, // API expects typed values (string, number, boolean)
       type: setting?.type,
       group_id: selectedGroup.value?.id,
       description: setting?.description,
@@ -274,7 +285,10 @@ async function handleSubmit(event: Event) {
                     <div v-else-if="setting.type === 'boolean'">
                       <Switch
                         :id="`setting-${setting.key}`"
-                        v-model="formValues[setting.key] as boolean"
+                        :model-value="formValues[setting.key] as boolean"
+                        @update:model-value="(value: boolean) => {
+                          formValues[setting.key] = value
+                        }"
                       />
                     </div>