Skip to content

Commit b476825

Browse files
author
Lasim
committed
refactor(backend): remove unnecessary permissions from user config routes
1 parent e5367c3 commit b476825

File tree

4 files changed

+10
-21
lines changed

4 files changed

+10
-21
lines changed

services/backend/src/routes/mcp/user-configurations/create.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { type FastifyInstance } from 'fastify';
22
import { requireAuthenticationAny } from '../../../middleware/oauthMiddleware';
3-
import { requireTeamPermission } from '../../../middleware/roleMiddleware';
43
import { McpUserConfigurationService } from '../../../services/mcpUserConfigurationService';
54
import { getDb } from '../../../db';
65
import {
@@ -22,13 +21,12 @@ export default async function createUserConfigRoute(server: FastifyInstance) {
2221
Body: CreateUserConfigRequest;
2322
}>('/teams/:teamId/mcp/installations/:installationId/user-configs', {
2423
preValidation: [
25-
requireAuthenticationAny(),
26-
requireTeamPermission('mcp.installations.edit')
24+
requireAuthenticationAny()
2725
],
2826
schema: {
2927
tags: ['MCP User Configurations'],
3028
summary: 'Create user configuration for MCP installation',
31-
description: 'Creates a new user-specific configuration for an MCP server installation. This allows individual users to customize arguments and environment variables for their personal use. Requires Content-Type: application/json header when sending request body. Supports both cookie-based authentication (for web users) and OAuth2 Bearer token authentication (for CLI users). Requires mcp:read scope for OAuth2 access.',
29+
description: 'Creates a new user-specific configuration for an MCP server installation. This allows individual users to customize arguments and environment variables for their personal use. Requires Content-Type: application/json header when sending request body. Supports both cookie-based authentication (for web users) and OAuth2 Bearer token authentication (for CLI users).',
3230
security: DUAL_AUTH_SECURITY,
3331

3432
// Fastify validation schema

services/backend/src/routes/mcp/user-configurations/update.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { type FastifyInstance } from 'fastify';
2-
import { requireAuthenticationAny, requireOAuthScope } from '../../../middleware/oauthMiddleware';
3-
import { requireTeamPermission } from '../../../middleware/roleMiddleware';
2+
import { requireAuthenticationAny } from '../../../middleware/oauthMiddleware';
43
import { McpUserConfigurationService } from '../../../services/mcpUserConfigurationService';
54
import { getDb } from '../../../db';
65
import {
@@ -16,9 +15,7 @@ export default async function updateUserConfigurationRoute(server: FastifyInstan
1615
'/teams/:teamId/mcp/installations/:installationId/user-configs/:configId',
1716
{
1817
preValidation: [
19-
requireAuthenticationAny(),
20-
requireOAuthScope('mcp:read'),
21-
requireTeamPermission('mcp.installations.manage')
18+
requireAuthenticationAny()
2219
],
2320
schema: updateUserConfigurationSchema
2421
},

services/backend/src/routes/mcp/user-configurations/updateArgs.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { type FastifyInstance } from 'fastify';
2-
import { requireAuthenticationAny, requireOAuthScope } from '../../../middleware/oauthMiddleware';
3-
import { requireTeamPermission } from '../../../middleware/roleMiddleware';
2+
import { requireAuthenticationAny } from '../../../middleware/oauthMiddleware';
43
import { McpUserConfigurationService } from '../../../services/mcpUserConfigurationService';
54
import { getDb } from '../../../db';
65
import {
@@ -16,15 +15,13 @@ export default async function updateUserArgsRoute(server: FastifyInstance) {
1615
'/teams/:teamId/mcp/installations/:installationId/user-configs/:configId/args',
1716
{
1817
preValidation: [
19-
requireAuthenticationAny(),
20-
requireOAuthScope('mcp:read'),
21-
requireTeamPermission('mcp.installations.manage')
18+
requireAuthenticationAny()
2219
],
2320
schema: {
2421
...updateUserArgsSchema,
2522
tags: ['MCP User Configurations'],
2623
summary: 'Update user configuration arguments',
27-
description: 'Updates the user-specific arguments for an MCP server installation configuration. Requires Content-Type: application/json header when sending request body. Supports both cookie-based authentication (for web users) and OAuth2 Bearer token authentication (for CLI users). Requires mcp:read scope for OAuth2 access.'
24+
description: 'Updates the user-specific arguments for an MCP server installation configuration. Requires Content-Type: application/json header when sending request body. Supports both cookie-based authentication (for web users) and OAuth2 Bearer token authentication (for CLI users).'
2825
}
2926
},
3027
async (request, reply) => {

services/backend/src/routes/mcp/user-configurations/updateEnv.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { type FastifyInstance } from 'fastify';
2-
import { requireAuthenticationAny, requireOAuthScope } from '../../../middleware/oauthMiddleware';
3-
import { requireTeamPermission } from '../../../middleware/roleMiddleware';
2+
import { requireAuthenticationAny } from '../../../middleware/oauthMiddleware';
43
import { McpUserConfigurationService } from '../../../services/mcpUserConfigurationService';
54
import { getDb } from '../../../db';
65
import {
@@ -16,15 +15,13 @@ export default async function updateUserEnvRoute(server: FastifyInstance) {
1615
'/teams/:teamId/mcp/installations/:installationId/user-configs/:configId/env',
1716
{
1817
preValidation: [
19-
requireAuthenticationAny(),
20-
requireOAuthScope('mcp:read'),
21-
requireTeamPermission('mcp.installations.manage')
18+
requireAuthenticationAny()
2219
],
2320
schema: {
2421
...updateUserEnvSchema,
2522
tags: ['MCP User Configurations'],
2623
summary: 'Update user configuration environment variables',
27-
description: 'Updates the user-specific environment variables for an MCP server installation configuration. Requires Content-Type: application/json header when sending request body. Supports both cookie-based authentication (for web users) and OAuth2 Bearer token authentication (for CLI users). Requires mcp:read scope for OAuth2 access.'
24+
description: 'Updates the user-specific environment variables for an MCP server installation configuration. Requires Content-Type: application/json header when sending request body. Supports both cookie-based authentication (for web users) and OAuth2 Bearer token authentication (for CLI users).'
2825
}
2926
},
3027
async (request, reply) => {

0 commit comments

Comments
 (0)