refactor: update error handling to use 'issues' instead of 'errors' in validation responses

Lasim · Lasim · commit d73802718eea · 2025-07-19T08:07:00.000+02:00
diff --git a/services/backend/src/routes/cloud-credentials/index.ts b/services/backend/src/routes/cloud-credentials/index.ts
@@ -198,7 +198,7 @@ export default async function cloudCredentialsRoutes(fastify: FastifyInstance) {
         return reply.status(400).send({
           success: false,
           error: 'Validation failed',
-          details: validationResult.error.errors.map(err => err.message)
+          details: validationResult.error.issues.map(err => err.message)
         });
       }
 
@@ -337,7 +337,7 @@ export default async function cloudCredentialsRoutes(fastify: FastifyInstance) {
         return reply.status(400).send({
           success: false,
           error: 'Validation failed',
-          details: validationResult.error.errors.map(err => err.message)
+          details: validationResult.error.issues.map(err => err.message)
         });
       }
 
@@ -567,7 +567,7 @@ export default async function cloudCredentialsRoutes(fastify: FastifyInstance) {
         return reply.status(400).send({
           success: false,
           error: 'Validation failed',
-          details: validationResult.error.errors.map(err => err.message)
+          details: validationResult.error.issues.map(err => err.message)
         });
       }
 
diff --git a/services/backend/src/routes/cloud-credentials/schemas.ts b/services/backend/src/routes/cloud-credentials/schemas.ts
@@ -47,7 +47,7 @@ export const CloudCredentialResponseSchema = z.object({
     name: z.string(),
     description: z.string(),
   }),
-  fields: z.record(CredentialFieldResponseSchema),
+  fields: z.record(z.string(), CredentialFieldResponseSchema),
   createdBy: z.union([UserInfoSchema, z.string()]).describe('User object when available, fallback to user ID'),
   createdAt: z.string(),
   updatedAt: z.string(),
@@ -73,7 +73,7 @@ export const CreateCloudCredentialSchema = z.object({
   providerId: z.string().min(1, 'Provider ID is required'),
   name: z.string().min(1, 'Name is required').max(100, 'Name must be 100 characters or less'),
   comment: z.string().max(500, 'Comment must be 500 characters or less').optional(),
-  credentials: z.record(z.string()).refine(
+  credentials: z.record(z.string(), z.string()).refine(
     (data) => Object.keys(data).length > 0,
     'At least one credential field is required'
   ),
@@ -82,7 +82,7 @@ export const CreateCloudCredentialSchema = z.object({
 export const UpdateCloudCredentialSchema = z.object({
   name: z.string().min(1, 'Name is required').max(100, 'Name must be 100 characters or less').optional(),
   comment: z.string().max(500, 'Comment must be 500 characters or less').optional(),
-  credentials: z.record(z.string()).optional(),
+  credentials: z.record(z.string(), z.string()).optional(),
 });
 
 export const SearchCredentialsQuerySchema = z.object({
diff --git a/services/backend/src/routes/db/setup.ts b/services/backend/src/routes/db/setup.ts
@@ -131,7 +131,7 @@ async function setupDbHandler(
     if (!parseResult.success) {
       return reply.status(400).send({ 
         error: 'Invalid request body',
-        details: parseResult.error.errors
+        details: parseResult.error.issues
       });
     }
 
diff --git a/services/backend/src/routes/globalSettings/settings/bulk.ts b/services/backend/src/routes/globalSettings/settings/bulk.ts
@@ -123,7 +123,7 @@ export default async function bulkGlobalSettingsRoute(fastify: FastifyInstance)
         return reply.status(400).send({
           success: false,
           error: 'Validation error',
-          details: error.errors,
+          details: error.issues,
         });
       }
       
diff --git a/services/backend/src/routes/globalSettings/settings/create.ts b/services/backend/src/routes/globalSettings/settings/create.ts
@@ -98,7 +98,7 @@ export default async function createGlobalSettingRoute(fastify: FastifyInstance)
         return reply.status(400).send({
           success: false,
           error: 'Validation error',
-          details: error.errors,
+          details: error.issues,
         });
       }
       
diff --git a/services/backend/src/routes/globalSettings/settings/search.ts b/services/backend/src/routes/globalSettings/settings/search.ts
@@ -74,7 +74,7 @@ export default async function searchGlobalSettingsRoute(fastify: FastifyInstance
         return reply.status(400).send({
           success: false,
           error: 'Validation error',
-          details: error.errors,
+          details: error.issues,
         });
       }
       
diff --git a/services/backend/src/routes/globalSettings/settings/update.ts b/services/backend/src/routes/globalSettings/settings/update.ts
@@ -96,7 +96,7 @@ export default async function updateGlobalSettingRoute(fastify: FastifyInstance)
         return reply.status(400).send({
           success: false,
           error: 'Validation error',
-          details: error.errors,
+          details: error.issues,
         });
       }
       
diff --git a/services/backend/src/routes/mcp/installations/config.ts b/services/backend/src/routes/mcp/installations/config.ts
@@ -29,7 +29,7 @@ export default async function getClientConfigRoute(fastify: FastifyInstance) {
         teamId: z.string().min(1, 'Team ID is required'),
         installationId: z.string().min(1, 'Installation ID is required'),
         clientType: z.enum(['claude-desktop', 'vscode', 'cursor'], {
-          errorMap: () => ({ message: 'Client type must be one of: claude-desktop, vscode, cursor' })
+          error: () => ({ message: 'Client type must be one of: claude-desktop, vscode, cursor' })
         })
       }), {
         $refStrategy: 'none',
diff --git a/services/backend/src/routes/mcp/installations/create.ts b/services/backend/src/routes/mcp/installations/create.ts
@@ -10,7 +10,7 @@ const createInstallationSchema = z.object({
   server_id: z.string().min(1, 'Server ID is required'),
   installation_name: z.string().min(1, 'Installation name is required').max(100, 'Installation name too long'),
   installation_type: z.enum(['local', 'cloud']).optional().default('local'),
-  user_environment_variables: z.record(z.string()).optional()
+  user_environment_variables: z.record(z.string(), z.string()).optional()
 });
 
 // Response schemas
@@ -23,7 +23,7 @@ const successResponseSchema = z.object({
     user_id: z.string(),
     installation_name: z.string(),
     installation_type: z.enum(['local', 'cloud']),
-    user_environment_variables: z.record(z.string()).optional(),
+    user_environment_variables: z.record(z.string(), z.string()).optional(),
     created_at: z.string(),
     updated_at: z.string(),
     last_used_at: z.string().nullable(),
diff --git a/services/backend/src/routes/mcp/installations/list.ts b/services/backend/src/routes/mcp/installations/list.ts
@@ -13,7 +13,7 @@ const installationSchema = z.object({
   user_id: z.string(),
   installation_name: z.string(),
   installation_type: z.enum(['local', 'cloud']),
-  user_environment_variables: z.record(z.string()).optional(),
+  user_environment_variables: z.record(z.string(), z.string()).optional(),
   created_at: z.string(),
   updated_at: z.string(),
   last_used_at: z.string().nullable(),
diff --git a/services/backend/src/routes/mcp/servers/create-global.ts b/services/backend/src/routes/mcp/servers/create-global.ts
@@ -7,10 +7,10 @@ import { getDb } from '../../../db';
 
 // Claude Desktop configuration schema
 const claudeDesktopConfigSchema = z.object({
-  mcpServers: z.record(z.object({
+  mcpServers: z.record(z.string(), z.object({
     command: z.string().min(1, 'Command is required'),
     args: z.array(z.string()),
-    env: z.record(z.string()).optional()
+    env: z.record(z.string(), z.string()).optional()
   }))
 }).refine(
   (config) => Object.keys(config.mcpServers).length === 1,
@@ -48,7 +48,7 @@ const createGlobalServerRequestSchema = z.object({
   author_contact: z.string().optional(),
   organization: z.string().optional(),
   license: z.string().optional(),
-  dependencies: z.record(z.any()).optional(),
+  dependencies: z.record(z.string(), z.any()).optional(),
   category_id: z.string().optional(),
   tags: z.array(z.string()).optional(),
   featured: z.boolean().default(false)
@@ -116,9 +116,9 @@ const createGlobalServerResponseSchema = z.object({
     author_contact: z.string().nullable(),
     organization: z.string().nullable(),
     license: z.string().nullable(),
-    default_config: z.record(z.any()).nullable(),
+    default_config: z.record(z.string(), z.any()).nullable(),
     environment_variables: z.array(z.any()).nullable(),
-    dependencies: z.record(z.any()).nullable(),
+    dependencies: z.record(z.string(), z.any()).nullable(),
     category_id: z.string().nullable(),
     tags: z.array(z.string()).nullable(),
     status: z.enum(['active', 'deprecated', 'maintenance']),
diff --git a/services/backend/src/routes/mcp/servers/get.ts b/services/backend/src/routes/mcp/servers/get.ts
@@ -37,9 +37,9 @@ const getServerResponseSchema = z.object({
     author_contact: z.string().nullable(),
     organization: z.string().nullable(),
     license: z.string().nullable(),
-    default_config: z.record(z.any()).nullable(),
+    default_config: z.record(z.string(), z.any()).nullable(),
     environment_variables: z.array(z.any()).nullable(),
-    dependencies: z.record(z.any()).nullable(),
+    dependencies: z.record(z.string(), z.any()).nullable(),
     category_id: z.string().nullable(),
     tags: z.array(z.string()).nullable(),
     status: z.enum(['active', 'deprecated', 'maintenance']),
diff --git a/services/backend/src/routes/mcp/servers/list.ts b/services/backend/src/routes/mcp/servers/list.ts
@@ -15,8 +15,8 @@ const querySchema = z.object({
   featured: z.boolean().optional(),
   search: z.string().optional(),
   // Pagination parameters
-  limit: z.string().regex(/^\d+$/, 'Limit must be a number').transform(Number).refine(n => n > 0 && n <= 100, 'Limit must be between 1 and 100').optional().default('20'),
-  offset: z.string().regex(/^\d+$/, 'Offset must be a number').transform(Number).refine(n => n >= 0, 'Offset must be non-negative').optional().default('0')
+  limit: z.string().regex(/^\d+$/, 'Limit must be a number').transform(Number).refine(n => n > 0 && n <= 100, 'Limit must be between 1 and 100').optional().default(20),
+  offset: z.string().regex(/^\d+$/, 'Offset must be a number').transform(Number).refine(n => n >= 0, 'Offset must be non-negative').optional().default(0)
 });
 
 // Response schema
diff --git a/services/backend/src/routes/mcp/servers/search.ts b/services/backend/src/routes/mcp/servers/search.ts
@@ -14,8 +14,8 @@ const searchServersQuerySchema = z.object({
   runtime: z.string().optional(),
   status: z.enum(['active', 'deprecated', 'maintenance']).optional(),
   featured: z.enum(['true', 'false']).optional().transform((val) => val === 'true'),
-  limit: z.string().regex(/^\d+$/, 'Limit must be a number').transform(Number).refine(n => n > 0 && n <= 100, 'Limit must be between 1 and 100').optional().default('20'),
-  offset: z.string().regex(/^\d+$/, 'Offset must be a number').transform(Number).refine(n => n >= 0, 'Offset must be non-negative').optional().default('0')
+  limit: z.string().regex(/^\d+$/, 'Limit must be a number').transform(Number).refine(n => n > 0 && n <= 100, 'Limit must be between 1 and 100').optional().default(20),
+  offset: z.string().regex(/^\d+$/, 'Offset must be a number').transform(Number).refine(n => n >= 0, 'Offset must be non-negative').optional().default(0)
 });
 
 // Response schema for search results
@@ -45,9 +45,9 @@ const searchServersResponseSchema = z.object({
       author_contact: z.string().nullable(),
       organization: z.string().nullable(),
       license: z.string().nullable(),
-      default_config: z.record(z.any()).nullable(),
+      default_config: z.record(z.string(), z.any()).nullable(),
       environment_variables: z.array(z.any()).nullable(),
-      dependencies: z.record(z.any()).nullable(),
+      dependencies: z.record(z.string(), z.any()).nullable(),
       category_id: z.string().nullable(),
       tags: z.array(z.string()).nullable(),
       status: z.enum(['active', 'deprecated', 'maintenance']),
diff --git a/services/backend/src/routes/mcp/servers/update-global.ts b/services/backend/src/routes/mcp/servers/update-global.ts
@@ -43,14 +43,14 @@ const updateGlobalServerRequestSchema = z.object({
   author_contact: z.string().optional(),
   organization: z.string().optional(),
   license: z.string().optional(),
-  default_config: z.record(z.any()).optional(),
+  default_config: z.record(z.string(), z.any()).optional(),
   environment_variables: z.array(z.object({
     name: z.string().min(1, 'Environment variable name is required'),
     description: z.string().min(1, 'Environment variable description is required'),
     required: z.boolean().default(false),
     default_value: z.string().optional()
   })).optional(),
-  dependencies: z.record(z.any()).optional(),
+  dependencies: z.record(z.string(), z.any()).optional(),
   category_id: z.string().optional(),
   tags: z.array(z.string()).optional(),
   status: z.enum(['active', 'deprecated', 'maintenance']).optional(),
@@ -83,9 +83,9 @@ const updateGlobalServerResponseSchema = z.object({
     author_contact: z.string().nullable(),
     organization: z.string().nullable(),
     license: z.string().nullable(),
-    default_config: z.record(z.any()).nullable(),
+    default_config: z.record(z.string(), z.any()).nullable(),
     environment_variables: z.array(z.any()).nullable(),
-    dependencies: z.record(z.any()).nullable(),
+    dependencies: z.record(z.string(), z.any()).nullable(),
     category_id: z.string().nullable(),
     tags: z.array(z.string()).nullable(),
     status: z.enum(['active', 'deprecated', 'maintenance']),
diff --git a/services/backend/src/routes/roles/index.ts b/services/backend/src/routes/roles/index.ts
@@ -223,7 +223,7 @@ export default async function rolesRoute(fastify: FastifyInstance) {
         return reply.status(400).send({
           success: false,
           error: 'Validation error',
-          details: error.errors,
+          details: error.issues,
         });
       }
       
@@ -327,7 +327,7 @@ export default async function rolesRoute(fastify: FastifyInstance) {
         return reply.status(400).send({
           success: false,
           error: 'Validation error',
-          details: error.errors,
+          details: error.issues,
         });
       }
       
diff --git a/services/backend/src/routes/teams/index.ts b/services/backend/src/routes/teams/index.ts
@@ -279,7 +279,7 @@ export default async function teamsRoute(fastify: FastifyInstance) {
         return reply.status(400).send({
           success: false,
           error: 'Validation error',
-          details: error.errors,
+          details: error.issues,
         });
       }
 
@@ -398,7 +398,7 @@ export default async function teamsRoute(fastify: FastifyInstance) {
         return reply.status(400).send({
           success: false,
           error: 'Validation error',
-          details: error.errors,
+          details: error.issues,
         });
       }
 
@@ -704,7 +704,7 @@ export default async function teamsRoute(fastify: FastifyInstance) {
         return reply.status(400).send({
           success: false,
           error: 'Validation error',
-          details: error.errors,
+          details: error.issues,
         });
       }
 
@@ -820,7 +820,7 @@ export default async function teamsRoute(fastify: FastifyInstance) {
         return reply.status(400).send({
           success: false,
           error: 'Validation error',
-          details: error.errors,
+          details: error.issues,
         });
       }
 
@@ -1026,7 +1026,7 @@ export default async function teamsRoute(fastify: FastifyInstance) {
         return reply.status(400).send({
           success: false,
           error: 'Validation error',
-          details: error.errors,
+          details: error.issues,
         });
       }
 
diff --git a/services/backend/src/routes/users/index.ts b/services/backend/src/routes/users/index.ts
@@ -250,7 +250,7 @@ export default async function usersRoute(fastify: FastifyInstance) {
         return reply.status(400).send({
           success: false,
           error: 'Validation error',
-          details: error.errors,
+          details: error.issues,
         });
       }
       
@@ -432,7 +432,7 @@ export default async function usersRoute(fastify: FastifyInstance) {
         return reply.status(400).send({
           success: false,
           error: 'Validation error',
-          details: error.errors,
+          details: error.issues,
         });
       }
       

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ async function setupDbHandler(`
`131`	`131`	`if (!parseResult.success) {`
`132`	`132`	`return reply.status(400).send({`
`133`	`133`	`error: 'Invalid request body',`
`134`		`- details: parseResult.error.errors`
	`134`	`+ details: parseResult.error.issues`
`135`	`135`	`});`
`136`	`136`	`}`
`137`	`137`
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ export default async function bulkGlobalSettingsRoute(fastify: FastifyInstance)`
`123`	`123`	`return reply.status(400).send({`
`124`	`124`	`success: false,`
`125`	`125`	`error: 'Validation error',`
`126`		`- details: error.errors,`
	`126`	`+ details: error.issues,`
`127`	`127`	`});`
`128`	`128`	`}`
`129`	`129`
Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ export default async function createGlobalSettingRoute(fastify: FastifyInstance)`
`98`	`98`	`return reply.status(400).send({`
`99`	`99`	`success: false,`
`100`	`100`	`error: 'Validation error',`
`101`		`- details: error.errors,`
	`101`	`+ details: error.issues,`
`102`	`102`	`});`
`103`	`103`	`}`
`104`	`104`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ export default async function searchGlobalSettingsRoute(fastify: FastifyInstance`
`74`	`74`	`return reply.status(400).send({`
`75`	`75`	`success: false,`
`76`	`76`	`error: 'Validation error',`
`77`		`- details: error.errors,`
	`77`	`+ details: error.issues,`
`78`	`78`	`});`
`79`	`79`	`}`
`80`	`80`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ export default async function updateGlobalSettingRoute(fastify: FastifyInstance)`
`96`	`96`	`return reply.status(400).send({`
`97`	`97`	`success: false,`
`98`	`98`	`error: 'Validation error',`
`99`		`- details: error.errors,`
	`99`	`+ details: error.issues,`
`100`	`100`	`});`
`101`	`101`	`}`
`102`	`102`