[PHPStanRules] Remove NoFactoryInConstructorRule as not possible to resolve caller types (#4130)

Author: TomasVotruba

packages/phpstan-rules/config/static-rules.neon

@@ -16,7 +16,6 @@ rules:
     - Symplify\PHPStanRules\Rules\ForbiddenParamTypeRemovalRule
     - Symplify\PHPStanRules\Rules\NoNestedFuncCallRule
     - Symplify\PHPStanRules\Rules\RequireStringRegexMatchKeyRule
-    - Symplify\PHPStanRules\Rules\NoFactoryInConstructorRule
     - Symplify\PHPStanRules\Rules\PreventParentMethodVisibilityOverrideRule
 
     # paths

packages/phpstan-rules/docs/rules_overview.md

@@ -1,4 +1,4 @@
-# 108 Rules Overview
+# 107 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -1832,44 +1832,6 @@ class SomeClass
 
 <br>
 
-## NoFactoryInConstructorRule
-
-Do not use factory/method call in constructor. Put factory in config and get service with dependency injection
-
-- class: [`Symplify\PHPStanRules\Rules\NoFactoryInConstructorRule`](../src/Rules/NoFactoryInConstructorRule.php)
-
-```php
-class SomeClass
-{
-    private $someDependency;
-
-    public function __construct(SomeFactory $factory)
-    {
-        $this->someDependency = $factory->build();
-    }
-}
-```
-
-:x:
-
-<br>
-
-```php
-class SomeClass
-{
-    private $someDependency;
-
-    public function __construct(SomeDependency $someDependency)
-    {
-        $this->someDependency = $someDependency;
-    }
-}
-```
-
-:+1:
-
-<br>
-
 ## NoFuncCallInMethodCallRule
 
 Separate function `"%s()"` in method call to standalone row to improve readability

packages/phpstan-rules/src/Reflection/MethodNodeAnalyser.php

@@ -7,7 +7,6 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\MethodReflection;
-use Symplify\PackageBuilder\ValueObject\MethodName;
 
 final class MethodNodeAnalyser
 {
@@ -44,14 +43,4 @@ public function matchFirstParentClassMethod(Scope $scope, string $methodName): ?
 
         return null;
     }
-
-    public function isInConstructor(Scope $scope): bool
-    {
-        $reflectionFunction = $scope->getFunction();
-        if (! $reflectionFunction instanceof MethodReflection) {
-            return false;
-        }
-
-        return $reflectionFunction->getName() === MethodName::CONSTRUCTOR;
-    }
 }