remove ParentParamTypeGuard (#4132)

Author: TomasVotruba

packages/phpstan-rules/config/configurable-rules.neon

@@ -37,7 +37,6 @@ services:
         tags: [phpstan.rules.rule]
         arguments:
             oldToPreferredClasses:
-                SplFileInfo: 'Symplify\SmartFileSystem\SmartFileInfo'
                 DateTime: 'Nette\Utils\DateTime'
                 'PhpCsFixer\Finder': 'Symfony\Component\Finder\Finder'
                 # smart file system

packages/phpstan-rules/config/services/generated-services.neon

@@ -41,7 +41,6 @@ services:
     - Symplify\PHPStanRules\ParentGuard\ParentClassMethodGuard
     - Symplify\PHPStanRules\ParentGuard\ParentElementResolver\ParentMethodResolver
     - Symplify\PHPStanRules\ParentGuard\ParentElementResolver\ParentMethodReturnTypeResolver
-    - Symplify\PHPStanRules\ParentGuard\ParentParamTypeGuard
     - Symplify\PHPStanRules\ParentGuard\ParentPropertyGuard
     - Symplify\PHPStanRules\ParentMethodAnalyser
     - Symplify\PHPStanRules\PhpDoc\AnnotationAttributeDetector

packages/phpstan-rules/src/ParentGuard/ParentParamTypeGuard.php

@@ -14,7 +14,6 @@
 use PHPStan\Analyser\Scope;
 use SplFileInfo;
 use Symplify\Astral\Naming\SimpleNameResolver;
-use Symplify\PHPStanRules\ParentGuard\ParentParamTypeGuard;
 use Symplify\RuleDocGenerator\Contract\ConfigurableRuleInterface;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -35,7 +34,6 @@ final class PreferredClassRule extends AbstractSymplifyRule implements Configura
      */
     public function __construct(
         private SimpleNameResolver $simpleNameResolver,
-        private ParentParamTypeGuard $parentParamTypeGuard,
         private array $oldToPreferredClasses
     ) {
     }
@@ -55,18 +53,18 @@ public function getNodeTypes(): array
     public function process(Node $node, Scope $scope): array
     {
         if ($node instanceof New_) {
-            return $this->processNew($node, $scope);
+            return $this->processNew($node);
         }
 
         if ($node instanceof Class_) {
             return $this->processClass($node);
         }
 
         if ($node instanceof StaticCall) {
-            return $this->processStaticCall($node, $scope);
+            return $this->processStaticCall($node);
         }
 
-        return $this->processClassName($node->toString(), $node, $scope);
+        return $this->processClassName($node->toString());
     }
 
     public function getRuleDefinition(): RuleDefinition
@@ -107,14 +105,14 @@ public function run()
     /**
      * @return string[]
      */
-    private function processNew(New_ $new, Scope $scope): array
+    private function processNew(New_ $new): array
     {
         $className = $this->simpleNameResolver->getName($new->class);
         if ($className === null) {
             return [];
         }
 
-        return $this->processClassName($className, $new, $scope);
+        return $this->processClassName($className);
     }
 
     /**
@@ -149,12 +147,8 @@ private function processClass(Class_ $class): array
     /**
      * @return string[]
      */
-    private function processClassName(string $className, Node $node, Scope $scope): array
+    private function processClassName(string $className): array
     {
-        if ($this->parentParamTypeGuard->isRequiredByContract($node, $scope)) {
-            return [];
-        }
-
         foreach ($this->oldToPreferredClasses as $oldClass => $prefferedClass) {
             if ($className !== $oldClass) {
                 continue;
@@ -170,14 +164,14 @@ private function processClassName(string $className, Node $node, Scope $scope):
     /**
      * @return string[]
      */
-    private function processStaticCall(StaticCall $staticCall, Scope $scope): array
+    private function processStaticCall(StaticCall $staticCall): array
     {
         if ($staticCall->class instanceof Expr) {
             return [];
         }
 
         $className = (string) $staticCall->class;
 
-        return $this->processClassName($className, $staticCall, $scope);
+        return $this->processClassName($className);
     }
 }

packages/phpstan-rules/src/Rules/PreferredClassRule.php

@@ -34,7 +34,6 @@ public function provideData(): Iterator
         yield [__DIR__ . '/Fixture/SomeStaticCall.php', [[$errorMessage, 13]]];
 
         yield [__DIR__ . '/Fixture/SkipPreferredExtendingTheOldOne.php', []];
-        yield [__DIR__ . '/Fixture/SkipRequiredByContract.php', []];
     }
 
     /**