[Bug] Fix #296

derailed · derailed · commit f43ad347bb16 · 2024-03-16T11:01:32.000-06:00
diff --git a/internal/lint/svc.go b/internal/lint/svc.go
@@ -115,7 +115,11 @@ func (s *Service) checkEndpoints(ctx context.Context, fqn string, kind v1.Servic
 		s.AddCode(ctx, 1110)
 		return
 	}
-	if len(ep.Subsets) == 1 {
+	var eps int
+	for _, s := range ep.Subsets {
+		eps += len(s.Addresses)
+	}
+	if eps == 1 {
 		s.AddCode(ctx, 1109)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,11 @@ func (s *Service) checkEndpoints(ctx context.Context, fqn string, kind v1.Servic`
`115`	`115`	`s.AddCode(ctx, 1110)`
`116`	`116`	`return`
`117`	`117`	`}`
`118`		`- if len(ep.Subsets) == 1 {`
	`118`	`+ var eps int`
	`119`	`+ for _, s := range ep.Subsets {`
	`120`	`+ eps += len(s.Addresses)`
	`121`	`+ }`
	`122`	`+ if eps == 1 {`
`119`	`123`	`s.AddCode(ctx, 1109)`
`120`	`124`	`}`
`121`	`125`	`}`