Skip to content

Commit dbcfb9c

Browse files
committed
update docs and release log
1 parent 4261fe5 commit dbcfb9c

File tree

3 files changed

+37
-10
lines changed

3 files changed

+37
-10
lines changed

CONTRIBUTING.md

Lines changed: 35 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,25 +4,34 @@ Contributing
44
Development Environment Setup
55
--------------------------------
66

7-
The project has no external dependencies so your environment setup is pretty much up to you. If you are running Python 2.6 you will need to `pip install unitest2` in order to run the tests.
7+
There are some exernal dependencies required in order to run the
8+
tests, located in the dev-requirements.txt file.
9+
10+
pip install -r dev-requirements.txt
11+
12+
If you are running Python 2.6 you will also need to `pip install unitest2`
13+
in order to run the tests.
814

915
Travis CI
1016
---------
1117

1218
[![Build Status](https://travis-ci.org/derek73/python-nameparser.svg?branch=master)](https://travis-ci.org/derek73/python-nameparser)
1319

14-
The GitHub project is set up with Travis CI. Tests are run automatically against new code pushes to any branch in the main repository. Test results may be viewed here:
20+
The GitHub project is set up with Travis CI. Tests are run
21+
automatically against new code pushes to any branch in the main
22+
repository. Test results may be viewed here:
1523

1624
https://travis-ci.org/derek73/python-nameparser
1725

1826
Running Tests
1927
---------------
2028

21-
To run the tests locally, just run `python tests.py`.
29+
To run the tests locally, run `python tests.py`.
2230

2331

2432
python tests.py
2533

34+
2635
You can also pass a name string to `tests.py` to see how it will be parsed.
2736

2837
$ python tests.py "Secretary of State Hillary Rodham-Clinton"
@@ -38,20 +47,36 @@ You can also pass a name string to `tests.py` to see how it will be parsed.
3847
Writing Tests
3948
----------------
4049

41-
If you make changes, please make sure you include tests with example names that you want to be parsed correctly.
50+
If you make changes, please make sure you include tests with example
51+
names that you want to be parsed correctly.
52+
53+
It's a good idea to include tests of alternate comma placement formats
54+
of the name to ensure that the 3 code paths for the 3 formats work in
55+
the same way.
4256

43-
It's a good idea to include tests of alternate comma placement formats of the name to ensure that the 3 code paths for the 3 formats work in the same way.
57+
The tests could be MUCH better. If the spirit moves you to design or
58+
implement a much more intelligent test strategy, please know that your
59+
efforts will be welcome and appreciated.
4460

45-
The tests could be MUCH better. If the spirit moves you to design or implement a much more intelligent test strategy, please know that your efforts will be welcome and appreciated.
61+
Unless you add better coverage someplace else, add a few examples of
62+
your names to `TEST_NAMES`. A test attempts to try the 3 different
63+
comma variations of these names automatically and make sure things
64+
don't blow up, so it can be a helpful regression indicator.
4665

47-
Unless you add better coverage someplace else, add a few examples of your names to `TEST_NAMES`. A test attempts to try the 3 different comma variations of these names automatically and make sure things don't blow up, so it can be a helpful regression indicator.
4866

4967
Provide Example Data
5068
----------------------
5169

52-
We humans are the learning machine behind this code, and we can't do it without real world data. If it doesn't work, start a new issue because we probably don't know.
70+
We humans are the learning machine behind this code, and we can't do
71+
it without real world data. If it doesn't work, start a new issue
72+
because we probably don't know.
5373

54-
If you have a dataset that has lots of issues, add the data to a [gist](https://gist.github.com) and [create a new issue](https://github.com/derek73/python-nameparser/issues) so we can try to get it working as expected.
74+
If you have a dataset that has lots of issues, add the data to a
75+
[gist](https://gist.github.com) and [create a new
76+
issue](https://github.com/derek73/python-nameparser/issues) so we can
77+
try to get it working as expected.
5578

56-
Feel free to update this documentation to address any questions that I missed. GitHub makes it pretty easy to edit it right on the web site now.
79+
Feel free to update this documentation to address any questions that I
80+
missed. GitHub makes it pretty easy to edit it right on the web site
81+
now.
5782

docs/customize.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ directly to the attribute.
3535
>>> hn = HumanName("Dr. John A. Kenneth Doe")
3636
>>> hn.title = ["Associate","Professor"]
3737
>>> hn.suffix = "Md."
38+
>>> hn.suffix
3839
<HumanName : [
3940
title: 'Associate Processor'
4041
first: 'John'

docs/release_log.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ Release Log
22
===========
33
* 0.3.7 - August 30, 2015
44
- Make HumanName instances pickleable
5+
- Speed improvement, 3x faster
56
* 0.3.6 - August 6, 2015
67
- Fix strings that start with conjunctions (#20)
78
- handle assigning lists of names to a name attribute

0 commit comments

Comments
 (0)