Skip to content

Feedback #8

@derekdowling

Description

@derekdowling
  • is_a() please use the language construct instanceof its faster.
  • Stubborn.php#L233 You want self:: I think rather than static::
  • Your using Exceptions for your events.. seems abit fugly.. quick fix solution might be a have an EventException, throw new EventException(Event::STOP_TIMING), rather than having a class called "StopEvent" which actually extends an Exception but doesn't live in the Exception folder or named "StopEventException".. even then this seems odd using Exceptions for Events. using the Symfony EventDispatcher would be Ideal.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions