Improve performance of queries.

Author: dereuromark

config/Migrations/20240307154751_MigrationQueueInitV8.php

@@ -9,9 +9,6 @@ class MigrationQueueInitV8 extends BaseMigration {
 	/**
 	 * Up Method.
 	 *
-	 * More information on this method is available here:
-	 * https://book.cakephp.org/phinx/0/en/migrations.html#the-up-method
-	 *
 	 * @return void
 	 */
 	public function up(): void {

config/Migrations/20250508121432_MigrationQueueMemory.php

@@ -8,9 +8,6 @@ class MigrationQueueMemory extends BaseMigration {
 	/**
 	 * Change Method.
 	 *
-	 * More information on this method is available here:
-	 * https://book.cakephp.org/migrations/4/en/migrations.html#the-change-method
-	 *
 	 * @return void
 	 */
 	public function change(): void {

config/Migrations/20251119005411_MigrationQueueIndexOptimization.php

@@ -0,0 +1,51 @@
+<?php
+declare(strict_types=1);
+
+use Migrations\BaseMigration;
+
+class MigrationQueueIndexOptimization extends BaseMigration {
+
+	/**
+	 * Change Method.
+	 *
+	 * @return void
+	 */
+	public function change(): void {
+		$this->table('queued_jobs')
+			// Main queue fetch optimization - CRITICAL
+			// Covers the primary requestJob() query which filters by completed IS NULL
+			// and orders by priority, age (calculated from notbefore), and id
+			->addIndex(
+				['completed', 'priority', 'notbefore', 'id'],
+				[
+					'name' => 'queue_fetch_optimization',
+				],
+			)
+			// Cleanup queries optimization
+			// Used by flushFailedJobs() which filters by fetched < threshold
+			->addIndex(
+				['fetched'],
+				[
+					'name' => 'fetched',
+				],
+			)
+			// Stats and job type queries optimization
+			// Used by getStats() and various job_task lookups
+			->addIndex(
+				['job_task', 'completed'],
+				[
+					'name' => 'job_task_completed',
+				],
+			)
+			// Worker tracking optimization
+			// Used in requestJob() for cost and unique constraints
+			->addIndex(
+				['workerkey'],
+				[
+					'name' => 'workerkey',
+				],
+			)
+			->update();
+	}
+
+}

src/Model/Table/QueuedJobsTable.php

@@ -613,7 +613,7 @@ public function requestJob(array $tasks, array $groups = [], array $types = []):
 
 						break;
 					case static::DRIVER_SQLITE:
-						//TODO
+						$tmp['strftime("%s", "now") >='] = $this->rateHistory[$tmp['job_task']] + $task['rate'];
 
 						break;
 				}
@@ -632,8 +632,10 @@ public function requestJob(array $tasks, array $groups = [], array $types = []):
 
 					break;
 				case static::DRIVER_SQLSERVER:
-					// the ORM does not support ROW locking at the moment
-					// TODO
+					// Row-level locking (ROWLOCK, UPDLOCK hints) not supported by CakePHP ORM.
+					// SQLServer uses default isolation level (READ COMMITTED) with automatic
+					// row locking on UPDATE. This may allow race conditions in high-concurrency
+					// scenarios. Consider using application-level locking or advisory locks if needed.
 
 					break;
 				case static::DRIVER_SQLITE:
@@ -925,8 +927,10 @@ public function cleanOldJobs(): int {
 			return 0;
 		}
 
+		$threshold = (new DateTime())->subSeconds((int)Configure::read('Queue.cleanuptimeout'));
+
 		return $this->deleteAll([
-			'completed <' => time() - (int)Configure::read('Queue.cleanuptimeout'),
+			'completed <' => $threshold,
 		]);
 	}