Skip to content

Commit 8ba303a

Browse files
committed
Fixed issue #2328: Stream resource references in stored stack traces don't hold
1 parent 34c02b1 commit 8ba303a

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/develop/stack.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ static void zval_from_stack_add_frame_parameters(zval *frame, function_stack_ent
373373
if (fse->var[j].name && !variadic_opened) {
374374
if (Z_TYPE(fse->var[j].data) == IS_UNDEF) {
375375
add_assoc_null_ex(params, ZSTR_VAL(fse->var[j].name), ZSTR_LEN(fse->var[j].name));
376-
} else {
376+
} else if (Z_TYPE(fse->var[j].data) != IS_RESOURCE) {
377377
Z_TRY_ADDREF(fse->var[j].data);
378378
add_assoc_zval_ex(params, ZSTR_VAL(fse->var[j].name), ZSTR_LEN(fse->var[j].name), &fse->var[j].data);
379379
}
@@ -383,11 +383,10 @@ static void zval_from_stack_add_frame_parameters(zval *frame, function_stack_ent
383383
/* Unnamed or Variadic parameters */
384384
if (Z_TYPE(fse->var[j].data) == IS_UNDEF) {
385385
add_index_null(params, j - variadic_opened);
386-
} else {
386+
} else if (Z_TYPE(fse->var[j].data) != IS_RESOURCE) {
387387
Z_TRY_ADDREF(fse->var[j].data);
388388
add_index_zval(params, j - variadic_opened, &fse->var[j].data);
389389
}
390-
391390
continue;
392391
} else {
393392
xdebug_str *argument = NULL;

0 commit comments

Comments
 (0)