Merge pull request #209 from derjust/enriquezrene-Issue-199

derjust · derjust · commit 9f4ba4a1f2cb · 2018-10-11T21:56:51.000-04:00
Enriquezrene issue 199
diff --git a/README.md b/README.md
@@ -88,6 +88,7 @@ Create a CRUD repository interface [UserRepository](https://github.com/derjust/s
 @EnableScan
 public interface UserRepository extends CrudRepository<User, String> {
   List<User> findByLastName(String lastName);
+  List<User> findByFirstName(String firstName);
 }
 ```
 
@@ -96,6 +97,7 @@ or for paging and sorting...
 ```java
 public interface PagingUserRepository extends PagingAndSortingRepository<User, String> {
 	Page<User> findByLastName(String lastName, Pageable pageable);
+	Page<User> findByFirstName(String firstName, Pageable pageable);
 
 	@EnableScan
 	@EnableScanCount
@@ -142,34 +144,8 @@ public static class DynamoDBConfig {
 }
 ```
 
-And finally write a test client [UserRepositoryIT](https://github.com/derjust/spring-data-dynamodb-examples/blob/master/src/test/java/com/github/derjust/spring_data_dynamodb_examples/simple/UserRepositoryIT.java):
+And finally write a test client [UserRepositoryIT](https://github.com/derjust/spring-data-dynamodb-examples/blob/master/src/test/java/com/github/derjust/spring_data_dynamodb_examples/simple/UserRepositoryIT.java) or start calling it from your existing Spring code.
 
-```java
-@RunWith(SpringRunner.class)
-@SpringBootTest(classes = { PropertyPlaceholderAutoConfiguration.class, DynamoDBConfig.class })
-public class UserRepositoryIT {
-	private static final Logger log = LoggerFactory.getLogger(UserRepositoryIT.class);
-	
-	@Autowired
-	private UserRepository repository;
-
-	@Test
-	public void sampleTestCase() {
-		User gosling = new User("James", "Gosling");
-		repository.save(gosling);
-
-		User hoeller = new User("Juergen", "Hoeller");
-		repository.save(hoeller);
-
-		List<User> result = repository.findByLastName("Gosling");
-		Assert.assertThat(result.size(), is(1));
-		Assert.assertThat(result, hasItem(gosling));
-		log.info("Found in table: {}", result.get(0));
-	}
-
-	// setup code
-}
-```
 
 The full source code is available at [spring-data-dynamodb-examples' simple example](https://github.com/derjust/spring-data-dynamodb-examples/blob/master/README-simple.md)
 
diff --git a/pom.xml b/pom.xml
@@ -790,6 +790,10 @@
             <name>Alex Simkin</name>
             <url>https://github.com/SimY4</url>
         </contributor>
+        <contributor>
+            <name>Rene Enriquez</name>
+            <url>enriquezrene</url>
+        </contributor>
     </contributors>
 
 
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -23,6 +23,11 @@
     <author email="zeeman@zeeman.de">derjust</author>
   </properties>
   <body>
+     <release version="5.0.4" date="" description="Maintenance &amp; security release">
+      <action dev="enriquezrene" issue="199" type="fix" date="2018-10-11">
+        Fix README.md examples
+      </action>
+    </release>
     <release version="5.0.3" date="2018-08-10" description="Maintenance &amp; security release">
       <action dev="derjust" type="fix" date="2018-03-05">
         Fix Javadoc and cast warnings
