Skip to content

Commit 67f2d44

Browse files
dschoderrickstolee
authored andcommitted
Merge core VFS features
These were done in private, before microsoft/git. Signed-off-by: Derrick Stolee <[email protected]>
2 parents ceee26d + 6d4b54b commit 67f2d44

24 files changed

+840
-13
lines changed

Documentation/config/core.txt

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -728,6 +728,48 @@ core.multiPackIndex::
728728
single index. See linkgit:git-multi-pack-index[1] for more
729729
information. Defaults to true.
730730

731+
core.gvfs::
732+
Enable the features needed for GVFS. This value can be set to true
733+
to indicate all features should be turned on or the bit values listed
734+
below can be used to turn on specific features.
735+
+
736+
--
737+
GVFS_SKIP_SHA_ON_INDEX::
738+
Bit value 1
739+
Disables the calculation of the sha when writing the index
740+
GVFS_MISSING_OK::
741+
Bit value 4
742+
Normally git write-tree ensures that the objects referenced by the
743+
directory exist in the object database. This option disables this check.
744+
GVFS_NO_DELETE_OUTSIDE_SPARSECHECKOUT::
745+
Bit value 8
746+
When marking entries to remove from the index and the working
747+
directory this option will take into account what the
748+
skip-worktree bit was set to so that if the entry has the
749+
skip-worktree bit set it will not be removed from the working
750+
directory. This will allow virtualized working directories to
751+
detect the change to HEAD and use the new commit tree to show
752+
the files that are in the working directory.
753+
GVFS_FETCH_SKIP_REACHABILITY_AND_UPLOADPACK::
754+
Bit value 16
755+
While performing a fetch with a virtual file system we know
756+
that there will be missing objects and we don't want to download
757+
them just because of the reachability of the commits. We also
758+
don't want to download a pack file with commits, trees, and blobs
759+
since these will be downloaded on demand. This flag will skip the
760+
checks on the reachability of objects during a fetch as well as
761+
the upload pack so that extraneous objects don't get downloaded.
762+
GVFS_BLOCK_FILTERS_AND_EOL_CONVERSIONS::
763+
Bit value 64
764+
With a virtual file system we only know the file size before any
765+
CRLF or smudge/clean filters processing is done on the client.
766+
To prevent file corruption due to truncation or expansion with
767+
garbage at the end, these filters must not run when the file
768+
is first accessed and brought down to the client. Git.exe can't
769+
currently tell the first access vs subsequent accesses so this
770+
flag just blocks them from occurring at all.
771+
--
772+
731773
core.sparseCheckout::
732774
Enable "sparse checkout" feature. See linkgit:git-sparse-checkout[1]
733775
for more information.
Lines changed: 102 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
1+
Read Object Process
2+
^^^^^^^^^^^^^^^^^^^^^^^^^^^
3+
4+
The read-object process enables Git to read all missing blobs with a
5+
single process invocation for the entire life of a single Git command.
6+
This is achieved by using a packet format (pkt-line, see technical/
7+
protocol-common.txt) based protocol over standard input and standard
8+
output as follows. All packets, except for the "*CONTENT" packets and
9+
the "0000" flush packet, are considered text and therefore are
10+
terminated by a LF.
11+
12+
Git starts the process when it encounters the first missing object that
13+
needs to be retrieved. After the process is started, Git sends a welcome
14+
message ("git-read-object-client"), a list of supported protocol version
15+
numbers, and a flush packet. Git expects to read a welcome response
16+
message ("git-read-object-server"), exactly one protocol version number
17+
from the previously sent list, and a flush packet. All further
18+
communication will be based on the selected version.
19+
20+
The remaining protocol description below documents "version=1". Please
21+
note that "version=42" in the example below does not exist and is only
22+
there to illustrate how the protocol would look with more than one
23+
version.
24+
25+
After the version negotiation Git sends a list of all capabilities that
26+
it supports and a flush packet. Git expects to read a list of desired
27+
capabilities, which must be a subset of the supported capabilities list,
28+
and a flush packet as response:
29+
------------------------
30+
packet: git> git-read-object-client
31+
packet: git> version=1
32+
packet: git> version=42
33+
packet: git> 0000
34+
packet: git< git-read-object-server
35+
packet: git< version=1
36+
packet: git< 0000
37+
packet: git> capability=get
38+
packet: git> capability=have
39+
packet: git> capability=put
40+
packet: git> capability=not-yet-invented
41+
packet: git> 0000
42+
packet: git< capability=get
43+
packet: git< 0000
44+
------------------------
45+
The only supported capability in version 1 is "get".
46+
47+
Afterwards Git sends a list of "key=value" pairs terminated with a flush
48+
packet. The list will contain at least the command (based on the
49+
supported capabilities) and the sha1 of the object to retrieve. Please
50+
note, that the process must not send any response before it received the
51+
final flush packet.
52+
53+
When the process receives the "get" command, it should make the requested
54+
object available in the git object store and then return success. Git will
55+
then check the object store again and this time find it and proceed.
56+
------------------------
57+
packet: git> command=get
58+
packet: git> sha1=0a214a649e1b3d5011e14a3dc227753f2bd2be05
59+
packet: git> 0000
60+
------------------------
61+
62+
The process is expected to respond with a list of "key=value" pairs
63+
terminated with a flush packet. If the process does not experience
64+
problems then the list must contain a "success" status.
65+
------------------------
66+
packet: git< status=success
67+
packet: git< 0000
68+
------------------------
69+
70+
In case the process cannot or does not want to process the content, it
71+
is expected to respond with an "error" status.
72+
------------------------
73+
packet: git< status=error
74+
packet: git< 0000
75+
------------------------
76+
77+
In case the process cannot or does not want to process the content as
78+
well as any future content for the lifetime of the Git process, then it
79+
is expected to respond with an "abort" status at any point in the
80+
protocol.
81+
------------------------
82+
packet: git< status=abort
83+
packet: git< 0000
84+
------------------------
85+
86+
Git neither stops nor restarts the process in case the "error"/"abort"
87+
status is set.
88+
89+
If the process dies during the communication or does not adhere to the
90+
protocol then Git will stop the process and restart it with the next
91+
object that needs to be processed.
92+
93+
After the read-object process has processed an object it is expected to
94+
wait for the next "key=value" list containing a command. Git will close
95+
the command pipe on exit. The process is expected to detect EOF and exit
96+
gracefully on its own. Git will wait until the process has stopped.
97+
98+
A long running read-object process demo implementation can be found in
99+
`contrib/long-running-read-object/example.pl` located in the Git core
100+
repository. If you develop your own long running process then the
101+
`GIT_TRACE_PACKET` environment variables can be very helpful for
102+
debugging (see linkgit:git[1]).

GIT-VERSION-GEN

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/bin/sh
22

33
GVF=GIT-VERSION-FILE
4-
DEF_VER=v2.40.1
4+
DEF_VER=v2.40.1.vfs.0.0
55

66
LF='
77
'
@@ -12,10 +12,15 @@ if test -f version
1212
then
1313
VN=$(cat version) || VN="$DEF_VER"
1414
elif test -d ${GIT_DIR:-.git} -o -f .git &&
15-
VN=$(git describe --match "v[0-9]*" HEAD 2>/dev/null) &&
15+
VN=$(git describe --match "v[0-9]*vfs*" HEAD 2>/dev/null) &&
1616
case "$VN" in
1717
*$LF*) (exit 1) ;;
1818
v[0-9]*)
19+
if test "${VN%%.vfs.*}" != "${DEF_VER%%.vfs.*}"
20+
then
21+
echo "Found version $VN, which is not based on $DEF_VER" >&2
22+
exit 1
23+
fi
1924
git update-index -q --refresh
2025
test -z "$(git diff-index --name-only HEAD --)" ||
2126
VN="$VN-dirty" ;;

cache-tree.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#include "cache.h"
2+
#include "gvfs.h"
23
#include "lockfile.h"
34
#include "tree.h"
45
#include "tree-walk.h"
@@ -252,7 +253,8 @@ static int update_one(struct cache_tree *it,
252253
int flags)
253254
{
254255
struct strbuf buffer;
255-
int missing_ok = flags & WRITE_TREE_MISSING_OK;
256+
int missing_ok = gvfs_config_is_set(GVFS_MISSING_OK) ?
257+
WRITE_TREE_MISSING_OK : (flags & WRITE_TREE_MISSING_OK);
256258
int dryrun = flags & WRITE_TREE_DRY_RUN;
257259
int repair = flags & WRITE_TREE_REPAIR;
258260
int to_invalidate = 0;

cache.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1054,6 +1054,7 @@ enum fsync_method {
10541054

10551055
extern enum fsync_method fsync_method;
10561056
extern int core_preload_index;
1057+
extern int core_gvfs;
10571058
extern int precomposed_unicode;
10581059
extern int protect_hfs;
10591060
extern int protect_ntfs;
@@ -1074,6 +1075,8 @@ int use_optional_locks(void);
10741075
extern char comment_line_char;
10751076
extern int auto_comment_line_char;
10761077

1078+
extern int core_virtualize_objects;
1079+
10771080
enum log_refs_config {
10781081
LOG_REFS_UNSET = -1,
10791082
LOG_REFS_NONE = 0,

commit.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#include "cache.h"
2+
#include "gvfs.h"
23
#include "tag.h"
34
#include "commit.h"
45
#include "commit-graph.h"
@@ -513,13 +514,17 @@ int repo_parse_commit_internal(struct repository *r,
513514
.sizep = &size,
514515
.contentp = &buffer,
515516
};
517+
int ret;
516518
/*
517519
* Git does not support partial clones that exclude commits, so set
518520
* OBJECT_INFO_SKIP_FETCH_OBJECT to fail fast when an object is missing.
519521
*/
520522
int flags = OBJECT_INFO_LOOKUP_REPLACE | OBJECT_INFO_SKIP_FETCH_OBJECT |
521-
OBJECT_INFO_DIE_IF_CORRUPT;
522-
int ret;
523+
OBJECT_INFO_DIE_IF_CORRUPT;
524+
525+
/* But the GVFS Protocol _does_ support missing commits! */
526+
if (gvfs_config_is_set(GVFS_MISSING_OK))
527+
flags ^= OBJECT_INFO_SKIP_FETCH_OBJECT;
523528

524529
if (!item)
525530
return -1;

config.c

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
*/
88
#include "cache.h"
99
#include "date.h"
10+
#include "gvfs.h"
1011
#include "branch.h"
1112
#include "config.h"
1213
#include "environment.h"
@@ -1743,6 +1744,11 @@ int git_default_core_config(const char *var, const char *value, void *cb)
17431744
return 0;
17441745
}
17451746

1747+
if (!strcmp(var, "core.gvfs")) {
1748+
gvfs_load_config_value(value);
1749+
return 0;
1750+
}
1751+
17461752
if (!strcmp(var, "core.sparsecheckout")) {
17471753
core_apply_sparse_checkout = git_config_bool(var, value);
17481754
return 0;
@@ -1773,6 +1779,11 @@ int git_default_core_config(const char *var, const char *value, void *cb)
17731779
return 0;
17741780
}
17751781

1782+
if (!strcmp(var, "core.virtualizeobjects")) {
1783+
core_virtualize_objects = git_config_bool(var, value);
1784+
return 0;
1785+
}
1786+
17761787
/* Add other config variables here and to Documentation/config.txt. */
17771788
return platform_core_config(var, value, cb);
17781789
}

connected.c

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#include "cache.h"
2+
#include "gvfs.h"
23
#include "object-store.h"
34
#include "run-command.h"
45
#include "sigchain.h"
@@ -30,6 +31,26 @@ int check_connected(oid_iterate_fn fn, void *cb_data,
3031
struct transport *transport;
3132
size_t base_len;
3233

34+
/*
35+
* Running a virtual file system there will be objects that are
36+
* missing locally and we don't want to download a bunch of
37+
* commits, trees, and blobs just to make sure everything is
38+
* reachable locally so this option will skip reachablility
39+
* checks below that use rev-list. This will stop the check
40+
* before uploadpack runs to determine if there is anything to
41+
* fetch. Returning zero for the first check will also prevent the
42+
* uploadpack from happening. It will also skip the check after
43+
* the fetch is finished to make sure all the objects where
44+
* downloaded in the pack file. This will allow the fetch to
45+
* run and get all the latest tip commit ids for all the branches
46+
* in the fetch but not pull down commits, trees, or blobs via
47+
* upload pack.
48+
*/
49+
if (gvfs_config_is_set(GVFS_FETCH_SKIP_REACHABILITY_AND_UPLOADPACK))
50+
return 0;
51+
if (core_virtualize_objects)
52+
return 0;
53+
3354
if (!opt)
3455
opt = &defaults;
3556
transport = opt->transport;

0 commit comments

Comments
 (0)