User search by role names instead of ids (#233)

* Search by role names instead of IDs

* Bump version

Author: slavikm

pom.xml

@@ -5,7 +5,7 @@
     <groupId>com.descope</groupId>
     <artifactId>java-sdk</artifactId>
     <modelVersion>4.0.0</modelVersion>
-    <version>1.0.50</version>
+    <version>1.0.51</version>
     <name>${project.groupId}:${project.artifactId}</name>
     <description>Java library used to integrate with Descope.</description>
     <url>https://github.com/descope/descope-java</url>

src/main/java/com/descope/model/user/request/UserSearchRequest.java

@@ -17,7 +17,8 @@
 @AllArgsConstructor
 public class UserSearchRequest {
   List<String> tenantIds;
-  List<String> roles;
+  List<String> roles; // Roles should not be used unless you have the role IDs
+  List<String> roleNames; // Search by role names
   @Builder.Default
   Integer limit = 0;
   @Builder.Default

src/test/java/com/descope/model/user/request/UserSearchRequestTest.java

@@ -22,13 +22,15 @@ public void testInstantSerialization() throws JsonProcessingException {
         .toModifiedTime(now)
         .tenantIds(Collections.singletonList("tenant1"))
         .roles(Collections.singletonList("role1"))
+        .roleNames(Collections.singletonList("rolename1"))
         .build();
 
     String json = mapper.writeValueAsString(request);
 
     long expectedMillis = now.toEpochMilli();
     String expectedJson = String.format(
-        "{\"tenantIds\":[\"tenant1\"],\"roles\":[\"role1\"],\"limit\":0,\"page\":0,\"withTestUser\":null,"
+        "{\"tenantIds\":[\"tenant1\"],\"roles\":[\"role1\"],\"roleNames\":[\"rolename1\"],\"limit\":0,\"page\":0,"
+        + "\"withTestUser\":null,"
         + "\"testUsersOnly\":null,\"customAttributes\":null,\"statuses\":null,\"emails\":null,\"phones\":null,"
         + "\"loginIds\":null,\"userIds\":null,\"ssoAppIds\":null,\"fromCreatedTime\":%d,\"toCreatedTime\":%d,"
         + "\"fromModifiedTime\":%d,\"toModifiedTime\":%d,"
@@ -44,14 +46,16 @@ public void testTenantRoleIdsAndNamesSerialization() throws JsonProcessingExcept
     UserSearchRequest request = UserSearchRequest.builder()
         .tenantIds(Collections.singletonList("tenant1"))
         .roles(Collections.singletonList("role1"))
+        .roleNames(Collections.singletonList("rolename1"))
         .tenantRoleIds(Collections.singletonMap("tenant1",
             RolesList.builder().values(Collections.singletonList("roleA")).build()))
         .tenantRoleNames(Collections.singletonMap("tenant2",
             RolesList.builder().values(Collections.singletonList("roleX")).build()))
         .build();
 
     String json = mapper.writeValueAsString(request);
-    String expectedJson = "{\"tenantIds\":[\"tenant1\"],\"roles\":[\"role1\"],\"limit\":0,\"page\":0,"
+    String expectedJson = "{\"tenantIds\":[\"tenant1\"],\"roles\":[\"role1\"],\"roleNames\":[\"rolename1\"],"
+        + "\"limit\":0,\"page\":0,"
         + "\"withTestUser\":null,\"testUsersOnly\":null,\"customAttributes\":null,\"statuses\":null,\"emails\":null,"
         + "\"phones\":null,\"loginIds\":null,\"userIds\":null,\"ssoAppIds\":null,\"fromCreatedTime\":null,"
         + "\"toCreatedTime\":null,\"fromModifiedTime\":null,\"toModifiedTime\":null,"

src/test/java/com/descope/sdk/mgmt/impl/OutboundAppsByTokenServiceImplTest.java

@@ -1,9 +1,5 @@
 package com.descope.sdk.mgmt.impl;
 
-import static com.descope.literals.Routes.ManagementEndPoints.MANAGEMENT_FETCH_OUTBOUND_APP_TENANT_TOKEN;
-import static com.descope.literals.Routes.ManagementEndPoints.MANAGEMENT_FETCH_OUTBOUND_APP_TENANT_TOKEN_LATEST;
-import static com.descope.literals.Routes.ManagementEndPoints.MANAGEMENT_FETCH_OUTBOUND_APP_USER_TOKEN;
-import static com.descope.literals.Routes.ManagementEndPoints.MANAGEMENT_FETCH_OUTBOUND_APP_USER_TOKEN_LATEST;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;