Increase coverage

Author: itaihanski

tests/management/test_audit.py

@@ -131,3 +131,110 @@ def test_create_event(self):
                 verify=True,
                 timeout=DEFAULT_TIMEOUT_SECONDS,
             )
+
+    def test_search_all_params_and_defaults(self):
+        client = DescopeClient(
+            self.dummy_project_id,
+            self.public_key_dict,
+            False,
+            self.dummy_management_key,
+        )
+
+        from_ts = datetime.fromtimestamp(1000)
+        to_ts = datetime.fromtimestamp(2000)
+
+        with patch("requests.post") as mock_post:
+            network_resp = mock.Mock()
+            network_resp.ok = True
+            # Include one record with missing fields to exercise defaults in converter
+            network_resp.json.return_value = {
+                "audits": [
+                    {
+                        "projectId": "p",
+                        "userId": "u",
+                        "action": "a",
+                        "externalIds": ["x"],
+                        "occurred": str(datetime.now().timestamp() * 1000),
+                        "device": "Desktop",
+                        "method": "otp",
+                        "geo": "US",
+                        "remoteAddress": "1.1.1.1",
+                        "tenants": ["t1"],
+                        "data": {"k": "v"},
+                    },
+                    {},
+                ]
+            }
+            mock_post.return_value = network_resp
+
+            resp = client.mgmt.audit.search(
+                user_ids=["u1"],
+                actions=["a1"],
+                excluded_actions=["a0"],
+                devices=["Mobile"],
+                methods=["totp"],
+                geos=["IL"],
+                remote_addresses=["2.2.2.2"],
+                login_ids=["e1"],
+                tenants=["t"],
+                no_tenants=True,
+                text="hello",
+                from_ts=from_ts,
+                to_ts=to_ts,
+            )
+
+            audits = resp["audits"]
+            assert len(audits) == 2
+            # Defaults for the second empty record
+            assert audits[1]["projectId"] == ""
+            assert audits[1]["userId"] == ""
+            assert audits[1]["action"] == ""
+            assert audits[1]["loginIds"] == []
+            assert audits[1]["tenants"] == []
+            assert audits[1]["data"] == {}
+
+            # Verify request body composed with all params
+            args, kwargs = mock_post.call_args
+            assert args[0] == f"{common.DEFAULT_BASE_URL}{MgmtV1.audit_search}"
+            sent = kwargs["json"]
+            assert sent["userIds"] == ["u1"]
+            assert sent["actions"] == ["a1"]
+            assert sent["excludedActions"] == ["a0"]
+            assert sent["devices"] == ["Mobile"]
+            assert sent["methods"] == ["totp"]
+            assert sent["geos"] == ["IL"]
+            assert sent["remoteAddresses"] == ["2.2.2.2"]
+            assert sent["externalIds"] == ["e1"]
+            assert sent["tenants"] == ["t"]
+            assert sent["noTenants"] is True
+            assert sent["text"] == "hello"
+            assert sent["from"] == int(from_ts.timestamp() * 1000)
+            assert sent["to"] == int(to_ts.timestamp() * 1000)
+
+    def test_create_event_minimal(self):
+        client = DescopeClient(
+            self.dummy_project_id,
+            self.public_key_dict,
+            False,
+            self.dummy_management_key,
+        )
+
+        with patch("requests.post") as mock_post:
+            network_resp = mock.Mock()
+            network_resp.ok = True
+            network_resp.json.return_value = {}
+            mock_post.return_value = network_resp
+            client.mgmt.audit.create_event(
+                action="a",
+                type="info",
+                actor_id="aid",
+                tenant_id="tid",
+            )
+            # Only the mandatory keys should appear in json body
+            sent = mock_post.call_args.kwargs["json"]
+            assert sent == {
+                "action": "a",
+                "type": "info",
+                "actorId": "aid",
+                "tenantId": "tid",
+            }