tests fix and readme

Author: ruvenzx

README.md

@@ -556,6 +556,19 @@ descope_client.mgmt.tenant.update(
     custom_attributes={"attribute-name": "value"},
 )
 
+# Managing the tenant's session settings
+# Getting the session settings
+descope_client.mgmt.tenant.load_settings(id="my-custom-id")
+
+# updating the session settings
+tenant_settings = {
+    session_settings_enabled = True,
+    self_provisioning_domains = ["ackme.com"],
+    
+}
+descope_client.mgmt.tenant.update_settings(id="my-custom-id", tenant_settings=tenant_settings)
+
+
 # Tenant deletion cannot be undone. Use carefully.
 # Pass true to cascade value, in case you want to delete all users/keys associated only with this tenant
 descope_client.mgmt.tenant.delete(id="my-custom-id", cascade=False)

descope/management/common.py

@@ -302,44 +302,6 @@ def associated_tenants_to_dict(associated_tenants: List[AssociatedTenant]) -> li
                 }
             )
     return associated_tenant_list
-
-class tenantSettings:
-    """
-    Represents tenant settings object.
-    """
-
-    def __init__(
-        self,
-        self_provisioning_domains: List[str],
-        domains: Optional[List[str]] = None,
-        auth_type: Optional[TenantAuthType] = None,
-        session_settings_enabled: Optional[bool] = False,
-        refresh_token_expiration: Optional[int] = None,
-        refresh_token_expiration_unit: Optional[SessionExiprationUnit] = None,
-        session_token_expiration: Optional[int] = None,
-        session_token_expiration_unit: Optional[SessionExiprationUnit] = None,
-        stepup_token_expiration: Optional[int] = None,
-        stepup_token_expiration_unit: Optional[SessionExiprationUnit] = None,
-        enable_inactivity: Optional[bool] = False,
-        inactivity_time: Optional[int] = None,
-        inactivity_time_unit: Optional[SessionExiprationUnit] = None,
-        JITDisabled: Optional[bool] = False,
-    ):
-        self.domains = domains
-        self.self_provisioning_domains = self_provisioning_domains
-        self.auth_type = auth_type
-        self.session_settings_enabled = session_settings_enabled
-        self.refresh_token_expiration = refresh_token_expiration
-        self.refresh_token_expiration_unit = refresh_token_expiration_unit
-        self.session_token_expiration = session_token_expiration
-        self.session_token_expiration_unit = session_token_expiration_unit
-        self.stepup_token_expiration = stepup_token_expiration
-        self.stepup_token_expiration_unit = stepup_token_expiration_unit
-        self.enable_inactivity = enable_inactivity
-        self.inactivity_time = inactivity_time
-        self.inactivity_time_unit = inactivity_time_unit
-        self.JITDisabled = JITDisabled
-
 class SAMLIDPAttributeMappingInfo:
     """
     Represents a SAML IDP attribute mapping object. use this class for mapping Descope attribute

descope/management/tenant.py

@@ -1,7 +1,7 @@
 from typing import Any, List, Optional
 
 from descope._http_base import HTTPBase
-from descope.management.common import MgmtV1, tenantSettings
+from descope.management.common import MgmtV1, TenantAuthType, SessionExiprationUnit
 
 
 class Tenant(HTTPBase):
@@ -95,7 +95,20 @@ def update(
     def update_settings(
         self,
         id: str,
-        tenant_settings: tenantSettings
+        self_provisioning_domains: List[str],
+        domains: Optional[List[str]] = None,
+        auth_type: Optional[TenantAuthType] = None,
+        session_settings_enabled: Optional[bool] = False,
+        refresh_token_expiration: Optional[int] = None,
+        refresh_token_expiration_unit: Optional[SessionExiprationUnit] = None,
+        session_token_expiration: Optional[int] = None,
+        session_token_expiration_unit: Optional[SessionExiprationUnit] = None,
+        stepup_token_expiration: Optional[int] = None,
+        stepup_token_expiration_unit: Optional[SessionExiprationUnit] = None,
+        enable_inactivity: Optional[bool] = None,
+        inactivity_time: Optional[int] = None,
+        inactivity_time_unit: Optional[SessionExiprationUnit] = None,
+        JITDisabled: Optional[bool] = None
     ):
         """
         Update an existing tenant's session settings.
@@ -107,10 +120,42 @@ def update_settings(
         Raise:
         AuthException: raised if creation operation fails
         """
+        body: dict[str, Any] = {
+            "tenantId": id,
+            "selfProvisioningDomains": self_provisioning_domains,
+        }
+        
+        if domains is not None:
+            body["domains"] = domains
+        if auth_type is not None:
+            body["authType"] = auth_type
+        if session_settings_enabled is not None:
+            body["sessionSettingsEnabled"] = session_settings_enabled
+        if refresh_token_expiration is not None:
+            body["refreshTokenExpiration"] = refresh_token_expiration
+        if refresh_token_expiration_unit is not None:
+            body["refreshTokenExpirationUnit"] = refresh_token_expiration_unit
+        if session_token_expiration is not None:
+            body["sessionTokenExpiration"] = session_token_expiration
+        if session_token_expiration_unit is not None:
+            body["sessionTokenExpirationUnit"] = session_token_expiration_unit
+        if stepup_token_expiration is not None:
+            body["stepupTokenExpiration"] = stepup_token_expiration
+        if stepup_token_expiration_unit is not None:
+            body["stepupTokenExpirationUnit"] = stepup_token_expiration_unit
+        if enable_inactivity is not None:
+            body["enableInactivity"] = enable_inactivity
+        if inactivity_time is not None:
+            body["inactivityTime"] = inactivity_time
+        if inactivity_time_unit is not None:
+            body["inactivityTimeUnit"] = inactivity_time_unit
+        if JITDisabled is not None:
+            body["JITDisabled"] = JITDisabled
+        
         self._http.post(
             MgmtV1.tenant_settings_path,
-            params={"id": id},
-            body= tenant_settings,
+            body=body,
+            params=None
         )
 
     def delete(

tests/management/test_tenant.py

@@ -388,13 +388,8 @@ def test_update_settings(self):
         # Test success flow
         with patch("requests.post") as mock_post:
             mock_post.return_value.ok = True
-            tenant_settings = {
-                "domains": ["domain1.com", "domain2.com"],
-                "authType": "oidc",
-                "sessionSettingsEnabled": True,
-            }
             self.assertIsNone(
-                client.mgmt.tenant.update_settings("t1", tenant_settings)
+                client.mgmt.tenant.update_settings("t1", self_provisioning_domains=["domain1.com"], domains=["domain1.com", "domain2.com"], auth_type="oidc", session_settings_enabled=True)
             )
             mock_post.assert_called_with(
                 f"{common.DEFAULT_BASE_URL}{MgmtV1.tenant_settings_path}",
@@ -403,10 +398,16 @@ def test_update_settings(self):
                     "Authorization": f"Bearer {self.dummy_project_id}:{self.dummy_management_key}",
                     "x-descope-project-id": self.dummy_project_id,
                 },
-                json=tenant_settings,
+                json={
+                    "tenantId": "t1",
+                    "selfProvisioningDomains": ["domain1.com"],
+                    "domains": ["domain1.com", "domain2.com"],
+                    "authType": "oidc",
+                    "sessionSettingsEnabled": True
+                },
                 allow_redirects=False,
+                params=None,
                 verify=True,
-                params={"id": "t1"},
                 timeout=DEFAULT_TIMEOUT_SECONDS,
             )