feat(dyndns): continue domain search when &hostname= is given

Author: peterthomassen

api/desecapi/tests/test_dyndns12update.py

@@ -298,6 +298,16 @@ def test_ignore_minimum_ttl(self):
             self.assertStatus(response, status.HTTP_200_OK)
             self.assertEqual(domain.rrset_set.get(subname="", type="A").ttl, 60)
 
+    def test_empty_hostname(self):
+        # Test that dynDNS updates work when &hostname= is given with username in basic auth
+        self.client.set_credentials_basic_auth(
+            self.my_domain.name.lower(), self.token.plain
+        )
+        response = self.assertDynDNS12Update(self.my_domain.name, hostname="")
+        self.assertStatus(response, status.HTTP_200_OK)
+        self.assertEqual(response.data, "good")
+        self.assertIP(ipv4="127.0.0.1")
+
     def test_identification_by_token(self):
         """
         Test if the conflict of having multiple domains, but not specifying which to update is correctly recognized.

api/desecapi/views/dyndns.py

@@ -68,18 +68,18 @@ def _find_ip(self, param_keys, separator):
 
     @cached_property
     def qname(self):
-        # hostname parameter
-        try:
-            if self.request.query_params["hostname"] != "YES":
-                return self.request.query_params["hostname"].lower()
-        except KeyError:
-            pass
-
-        # host_id parameter
-        try:
-            return self.request.query_params["host_id"].lower()
-        except KeyError:
-            pass
+        # hostname / host_id
+        for param, reserved in {
+            "hostname": ["", "YES"],
+            "host_id": [],
+        }.items():
+            try:
+                domain_name = self.request.query_params[param]
+            except KeyError:
+                pass
+            else:
+                if domain_name not in reserved:
+                    return domain_name.lower()
 
         # http basic auth username
         try: