Merge pull request #11 from deseretdigital/deadletter-permissions-fix

nathanknowles · web-flow · commit 18203b6e71ba · 2026-01-26T11:51:08.000-07:00
fix(pubsub): add explicit dependency for dead letter topic IAM permission
diff --git a/resources.tf b/resources.tf
@@ -7,6 +7,10 @@ resource "google_pubsub_subscription" "subscription" {
     dead_letter_topic     = google_pubsub_topic.dead_letter_subscription_topic.id
     max_delivery_attempts = var.max_delivery_attempts
   }
+
+  depends_on = [
+    google_pubsub_topic_iam_member.assign_pubsub_publisher
+  ]
 }
 
 resource "google_pubsub_topic" "dead_letter_subscription_topic" {

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,10 @@ resource "google_pubsub_subscription" "subscription" {`
`7`	`7`	`dead_letter_topic = google_pubsub_topic.dead_letter_subscription_topic.id`
`8`	`8`	`max_delivery_attempts = var.max_delivery_attempts`
`9`	`9`	`}`
	`10`	`+`
	`11`	`+ depends_on = [`
	`12`	`+ google_pubsub_topic_iam_member.assign_pubsub_publisher`
	`13`	`+ ]`
`10`	`14`	`}`
`11`	`15`
`12`	`16`	`resource "google_pubsub_topic" "dead_letter_subscription_topic" {`