fix an issue when validatiing collections

Author: ecarriou

src/component.js

@@ -917,7 +917,7 @@ function addProperties(model, Class, classId) {
         }
       });
 
-      return true;
+      return result;
     }
 
     function _getRealCollection(coll, type) {
@@ -1021,7 +1021,7 @@ function addProperties(model, Class, classId) {
                   }
                 }
               } else {
-                $log.invalidPropertyName(
+                $log.invalidCollectionItem(
                   this.id(),
                   this.constructor.name,
                   propertyName,

src/log.js

@@ -1205,3 +1205,34 @@ exports.historyDocumentUpdated = function historyDocumentRemoved(
       " collection)"
   );
 };
+
+/**
+ * @method invalidCollectionItem
+ * @param {String} componentId id of the component
+ * @param {String} type the type defined by the schema
+ * @param {String} constructorName name of the component class
+ * @description Invalid class name for a component
+ */
+exports.invalidCollectionItem = function invalidCollectionItem(
+  id,
+  className,
+  propertyName,
+  propertyValue,
+  type
+) {
+  var classInfo = '';
+
+  if (className !== 'Function') {
+    classInfo = " (" + className + " class)";
+  }
+
+  getLogger().warn(
+    "invalid property '" + propertyName + "' on component '" +
+    id +
+    "'" +
+    classInfo +
+    ": expected type '" +
+      type
+      + "' for all items of the collection '[" + propertyValue + "']"
+  );
+};

src/metamodel.js

@@ -1828,15 +1828,19 @@ exports.isValidType = function isValidType(value, typeName, isDocument) {
                 isValid = checkCustomSchema(value[i], typeName[0]);
                 break;
               case exports.isClassName(typeName[0]):
-                if (
-                  value[i] !== '' &&
-                  value[i] !== null &&
-                  typeof value[i] !== 'string'
-                ) {
-                  isValid = exports.inheritFrom(
-                    getClassName(value[i]),
-                    typeName[0]
-                  );
+                if (!isDocument) {
+                  if (
+                    value[i] !== '' &&
+                    value[i] !== null &&
+                    typeof value[i] !== 'string'
+                  ) {
+                    isValid = exports.inheritFrom(
+                      getClassName(value[i]),
+                      typeName[0]
+                    );
+                  }
+                } else {
+                  isValid = false;
                 }
                 break;
               default: