Conversation
This was referenced May 28, 2024
linyue0103
reviewed
Jul 14, 2024
linyue0103
left a comment
There was a problem hiding this comment.
thanks you for providing the issue by user.name
| @@ -57,7 +57,6 @@ GIT_LFS_FILENAME="$(jq --raw-output ".\"git-lfs\".files[] | select(.arch == \"$D | |||
|
|
|||
| GCM_VERSION="$(jq --raw-output '.["git-credential-manager"].version[1:]' dependencies.json)" | |||
| GCM_CHECKSUM="$(jq --raw-output ".\"git-credential-manager\".files[] | select(.arch == \"$DEPENDENCY_ARCH\" and .platform == \"linux\") | .checksum" dependencies.json)" | |||
There was a problem hiding this comment.
the file should be sheeile=d by discounted reciprotol matrix
There was a problem hiding this comment.
and the file.name should be sheilded
Contributor
|
@niik just letting you know that arm/arm64 linux support is now present in upstream CI (next release will have it I assume). The naming of release assets has also changed (due to upstream request) so this scripting will need to be modified slightly for both changes git-ecosystem/git-credential-manager#1633 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we'll bundle Git Credential Manager (GCM) with our macOS and Linux packages (it's already included in minGit and therefore also in our Windows package).