Show a creators posts & comments in their profile #93
Replies: 12 comments 5 replies
-
|
In principle the idea seems sound and ive often wondered the same. But there are 2-3 times the amount of comments vs main posts. So hopefully someone smarter then me can assess impact on performance of adding comments into the response. And how performance of this can be optimised. |
Beta Was this translation helpful? Give feedback.
-
|
@maebeam @lazynina Would appreciate a review: approval or not, would be nice to get closure here 😀 |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Not only do we need comments/replies on the user profiles but also in the following feed. This is significantly more challenging though due to the volume of comments that come through. Might have to get clever and splice them in based on diamonds/likes similar to the hot feed. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
i'd like to hear if this is or isn't possible from someone on core. i mean, it's ~ possible ~ of course, but i can understand that it may be too bone-crunching on .. i guess the nodes. what would make it much simpler? having some kind of list of the parent posthashhex's somewhere.
but yeah absolutely being able to get a separate comments feed by user and/or one that mixes them amongst posts would be great to directly come from the api! |
Beta Was this translation helpful? Give feedback.
-
|
Great Idea. There are more API routes we need to make dApps on DeSo. Let's see core team approves this DIP or not. |
Beta Was this translation helpful? Give feedback.
-
|
I think it's about time we move this forward. Let's do a $2,500 bounty for the best implementation that achieves the following:
Any takers? Let us know! |
Beta Was this translation helpful? Give feedback.
-
|
Just added two PRs to core and backend to add a "IncludeComments" boolean flag to the "get-posts-for-public-key" endpoint. |
Beta Was this translation helpful? Give feedback.
-
|
I have implemented the requirements, and it should work 👀 deso-protocol/core#418 If it is what you are looking for and I'm a "winner," I can improve the solution. Cheers. |
Beta Was this translation helpful? Give feedback.
-
|
Hey guys, great work both of you! After reviewing the code, @donhardman's implementation is the best so he wins the $2,500, but I'm going to send $500 in DESO to you as well @DeSoEngineer for the effort :) @donhardman, we need to review the code a bit more before you refine the approach so just hang tight for now. |
Beta Was this translation helpful? Give feedback.
-
|
any idea when this may get actioned and included in nodes ? |
Beta Was this translation helpful? Give feedback.

Uh oh!
There was an error while loading. Please reload this page.
-
One-Line Description
Enable posts and comments to be returned by get-posts-for-public-key endpoint
Explanation and Motivation
Currently only posts authored by a creator are displayed in their profile, any comments are only accessible thru the post they reply too.
We need an easy way to view a creators posts and comments to see all their postings.
Specification
This will require updates to the core, backend and frontend to fully implement.
I would like this CIP to focus on the core & backend changes to enable this functionality on the frontend.
A separate CIP should be created for the FE changes, which can be implemented/displayed in a number of different ways.
Data Storage Change
None
Backwards Compatibility
This will be an addition to existing functionality and as such there should be no compatibility issues.
Beta Was this translation helpful? Give feedback.
All reactions