-
Notifications
You must be signed in to change notification settings - Fork 45
Description
As Originally reported by @johanneskares in #102 (comment), the generated package is not compatible with yarn workspaces:
Now I can include it as depdendency in my monorepo. Only problem is, I manually have to change the name of the generated package, because
yarndoesn't like the name of the package.dethcrypto/eth-sdk-clientinpackage.json. When I doyarn workspace my-package add .dethcrypto/eth-sdk-clientI get
Usage Error: The .dethcrypto/eth-sdk-client string didn't match the required format (package-name@range). Did you perhaps forget to explicitly reference the package name?When I manually edit it to
dethcrypto-eth-sdk-client-generated, everything works fine.
Customizing the generated package name in the config would solve this.
Also, to use it as a standalone package in a monorepo setup - which is great if you're going to use the sdk in both the backend and front-end - it needs a version, which could either be included as a static field in the configuration, or initialized to a configurable value and then dynamically incremented in subsequent updates
The way it works today, I have to rewrite the sdk's package.json every time I update it