Support special symbols usage in calculateReceivingSignatureValue

Author: ArturAmpilogov

CHANGELOG.md

@@ -8,24 +8,32 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## Unreleased
 
 ### Added
+
 - Allow outSum to be a number or a formatted string.
 
 ### Fixed
+
 - Fixed calculating signature value with special symbols in userParams (@ in emails).
 - Renamed Email to EMail field in IRobokassaResponse.
 
 ## 1.0.1 - 2023-05-13
+
 ### Changed
+
 - Translated README.md to Russian language.
 
 ## 1.0.0 - 2023-05-12
+
 ### Added
+
 - Added `isTest` mode parameter.
 - Added `receipt` parameter to conform the fiscal policy.
 - Added unit tests.
 
 ### Changed
+
 - Rewrote the forked code to use TypeScript.
 
 ### Fixed
+
 - Semantic Version calculation errors in the old forked repositories.

src/internal/calculateReceivingSignatureValue.spec.ts

@@ -28,7 +28,7 @@ describe('#calculateReceivingSignatureValue', () => {
       });
 
       expect(result).toEqual(
-        '200.00:84:my_password2:Shp_email=test%40test.com:Shp_user_id=123',
+        '200.00:84:my_password2:Shp_email=test@test.com:Shp_user_id=123',
       );
     });
   });

src/internal/calculateReceivingSignatureValue.ts

@@ -16,9 +16,8 @@ export const buildExpectedReceivingSignatureString = ({
   );
 
   const signatureUserParams =
-    userParameters.map(
-      ([key, value]) => `${key}=${encodeURIComponent(value?.toString() ?? '')}`,
-    ) ?? [];
+    userParameters.map(([key, value]) => `${key}=${value?.toString() ?? ''}`) ??
+    [];
   // Порядок параметров важен, сортируем по алфавиту
   signatureUserParams.sort((a, b) => a.localeCompare(b));
 

src/internal/calculateSendingSignatureValue.spec.ts

@@ -34,7 +34,7 @@ describe('#calculateSendingSignatureValue', () => {
       });
 
       expect(result).toEqual(
-        'my_merchant_login:200.00:84:my_password1:Shp_email=test%40test.com:Shp_user_id=123',
+        'my_merchant_login:200.00:84:my_password1:Shp_email=test@test.com:Shp_user_id=123',
       );
     });
 

src/types/IRobokassaResponse.ts

@@ -24,7 +24,7 @@ export type IRobokassaResponse = {
   /** Контрольная сумма с Пароль#2 */
   SignatureValue: string;
 
-  /** Способ оплаты который использовал пользователь при совершении платежа. 
+  /** Способ оплаты который использовал пользователь при совершении платежа.
    * Напрмер, BankCard */
   PaymentMethod: string;