Skip to content

Commit 08e1e8e

Browse files
committed
fix(job-offers): correct job data, remove redundant code, and fix typos
1 parent 941cb2a commit 08e1e8e

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

src/components/JobOffers/CompanyCard.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,6 @@ const CompanyCard: React.FC<CompanyCardProps> = ({ company, index }) => {
4444
src={company.logo}
4545
alt={`${company.name} logo`}
4646
className="company-logo"
47-
onError={(e: { target: HTMLImageElement }) => {
48-
const target = e.target;
49-
target.src = company.logo;
50-
}}
5147
/>
5248
</Col>
5349
<Col md={7}>

src/components/JobOffers/JobOffersList.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
import React, { useEffect, useState } from "react";
22
import { Alert, Col, Container, Row } from "react-bootstrap";
3+
// @ts-expect-error some quirky
34
import { motion } from "framer-motion";
45
import { jobOffers } from "@views/JobOffers/JobsData";
56
import CompanyCard from "./CompanyCard";
67
import JobFilters from "./JobFilters";
8+
// @ts-expect-error some quirky
79
import { Company, Offer } from "@types/jobOffers";
810

911
const JobOffersList: React.FC = () => {
@@ -23,7 +25,7 @@ const JobOffersList: React.FC = () => {
2325
.map((company) => {
2426
const filteredOffers = company.offers.filter(
2527
(offer: Offer) =>
26-
offer.title.toLowerCase().includes(term) ??
28+
offer.title.toLowerCase().includes(term) ||
2729
offer.text.toLowerCase().includes(term),
2830
);
2931

@@ -115,9 +117,8 @@ const JobOffersList: React.FC = () => {
115117
onLocationChange={handleLocationChange}
116118
onClearFilters={handleClearFilters}
117119
/>
118-
119120
{noResults ? (
120-
<Alert variant="info\" className="text-center">
121+
<Alert variant="info" className="text-center">
121122
No job offers match your search criteria. Try adjusting your filters.
122123
</Alert>
123124
) : (

src/views/JobOffers/JobsData.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export const jobOffers: Company[] = [
4444
{
4545
id: "93c2f7fd-8718-4368-983e-2e8d28fdf06c",
4646
text:
47-
"AS A PRODUCTION SOFTWARE ENGINEER AT SNOWFLAKE, YOU WILL:<br/>" +
47+
"as a Production Software Engineer at Snowflake, you will:<br/>" +
4848
"* Design, lead and own significant projects with an impact felt far beyond your team. <br/>" +
4949
"* Contribute to the design and operation of our highly reliable, secure, scalable, and performant infrastructure<br/>" +
5050
"* Develop the software to grow our fleet of services and deployments<br/>" +
@@ -53,7 +53,7 @@ export const jobOffers: Company[] = [
5353
"* Plan and lead complex technical projects while partnering with a wide variety of teams within the company",
5454
url: "https://careers.snowflake.com/us/en/job/SNCOUS1B155129FA6D439B9893A51A1E6AFCA8EXTERNALENUS8C40EA83A7D34DF691A7CCB73954E02D/Production-Software-Engineer",
5555
location: "Hybrid",
56-
title: "",
56+
title: "PRODUCTION SOFTWARE ENGINEER",
5757
},
5858
{
5959
id: "d17366a8-6ab1-4908-aa8c-1ccc3897f97c",

0 commit comments

Comments
 (0)