fix: carrousel swiper was showing the same speakers every year. #708
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @anyulled, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an issue where the speaker carousel was displaying the same speakers every year. To fix this, I've made changes to how the speaker data is fetched and displayed. Specifically, I've updated the components to dynamically fetch speaker data based on the current year's configuration and enabled the carrousel for 2023.
Highlights
- Data Fetching: The
sessionizeUrlprop inSpeakersCarouselcomponent is now namedurland it's passed down to theSpeakerSwipercomponent to fetch speakers dynamically. - Component Updates: Updated
Home2023Wrapper.tsx,HomeWrapper2024.tsx, andHomeWrapper.tsxto use the correct data files and pass theisEnabledprop to theSpeakersCarouselcomponent. - Configuration: Enabled the speaker carousel for the year 2023 by updating the
src/data/2023.jsonfile. - Import Path: Updated import paths to use aliases (e.g.,
@constants/BreakPointsinstead of../../constants/BreakPoints).
Changelog
Click here to see the changelog
- src/2023/Home/Home2023Wrapper.tsx
- Updated import paths to use aliases.
- Passed
data.editionassessionizeUrlanddata.carrousel.enabledasisEnabledto theSpeakersCarouselcomponent.
- src/2024/HomeWrapper2024.tsx
- Updated import paths to use aliases.
- Passed
conferenceData.sessionizeUrlassessionizeUrlanddata.carrousel.enabledasisEnabledto theSpeakersCarouselcomponent. - Added import statement for 2023 data.
- src/components/Swiper/SpeakerSwiper.tsx
- Updated import paths to use aliases.
- Modified the component to accept
isEnabledandurlprops. - Modified the
useFetchSpeakershook to accept a URL. - Conditionally render the swiper based on the
isEnabledprop.
- src/components/Swiper/SpeakersCarousel.tsx
- Updated import paths to use aliases.
- Modified the component to accept an
isEnabledprop. - Passed the
sessionizeUrlandisEnabledprops to theSpeakerSwipercomponent.
- src/data/2023.json
- Enabled the carrousel by setting
enabledtotrue.
- Enabled the carrousel by setting
- src/hooks/useFetchSpeakers.ts
- Updated import paths to use aliases.
- src/views/Home/HomeWrapper.tsx
- Updated import paths to use aliases.
- Passed
conferenceData.sessionizeUrlassessionizeUrl,ROUTE_SPEAKERSasspeakersLinkandconferenceData.carrousel.enabledasisEnabledto theSpeakersCarouselcomponent.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A carousel of code,
Turning slow, a heavy load,
Now the speakers gleam,
A vibrant, yearly dream,
No longer the same old road.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
✅ Deploy Preview for dev-bcn ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Code Review
The pull request addresses the issue of the carousel swiper showing the same speakers every year by modifying the data source and logic for enabling the carousel. The changes involve updating imports to use aliases, modifying the sessionizeUrl prop to accept the edition, and adding an isEnabled prop to control the carousel's visibility. Overall, the changes seem reasonable, but there are a few areas that could be improved.
Summary of Findings
- Incorrect Data Source for isEnabled Prop in 2024 Wrapper: The
isEnabledprop inHomeWrapper2024.tsxis using the 2023 data instead of the 2024 data. This will cause the carousel to not be enabled/disabled correctly for the 2024 conference.
Merge Readiness
The pull request addresses the issue of the carousel swiper showing the same speakers every year. However, there is a potential issue with the isEnabled prop in HomeWrapper2024.tsx using the incorrect data source. I recommend addressing this issue before merging. I am unable to approve this pull request, and recommend that others review and approve this code before merging.
|
No description provided.