feat/open-feedback 2025 #725
Conversation
✅ Deploy Preview for dev-bcn ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @anyulled, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello! Gemini here, providing a summary of this pull request. This PR introduces support for OpenFeedback links for the 2025 conference and makes the OpenFeedback link dynamic for all years (2023, 2024, 2025) by reading the specific conference ID from the respective year's JSON data file. Additionally, it includes a refactoring of import paths across several files to use path aliases, improving code readability and maintainability.
Highlights
- Dynamic OpenFeedback Links: The OpenFeedback link in the
TalkCardcomponent is no longer hardcoded for 2024. It now dynamically constructs the URL using anopenFeedbackIdpassed down through components, allowing it to work correctly for 2023, 2024, and 2025 based on the data provided. - Conference Data Updates: The
openFeedbackIdfield has been added to the2023.json,2024.json, and2025.jsondata files, storing the unique identifier needed to construct the correct OpenFeedback URL for each conference year. - Component Prop Updates: The
TrackInformationandTalkCardcomponents have been updated to accept the newopenFeedbackIdprop, which is then used byTalkCardto generate the dynamic OpenFeedback link. - Import Alias Refactoring: Several files (
Talks2023.tsx,Talks2024.tsx,TalkCard.tsx,TrackInformation.tsx,Talks.tsx,TalkCard.tsxinviews/Talks/components) have had their relative import paths (../../...) replaced with configured path aliases (@assets/...,@components/..., etc.) for cleaner imports. - Component Export Change: The
TalkCardcomponent insrc/components/common/TalkCard.tsxhas changed from a default export to a named export, requiring corresponding updates in files that import it (TrackInformation.tsxandsrc/views/Talks/components/TalkCard.tsx).
Changelog
Click here to see the changelog
- src/2023/Talks/Talks2023.tsx
- Refactored import paths to use aliases (lines 2-7, 15, 19, 21).
- Changed single quotes to double quotes in regex replacement (line 54).
- Passed
openFeedbackIdprop toTrackInformationcomponent (line 136).
- src/2024/Talks/Talks2024.tsx
- Refactored import paths to use aliases (lines 2-7, 9, 13, 20, 22).
- Changed single quotes to double quotes in regex replacement (line 55).
- Passed
openFeedbackIdprop toTrackInformationcomponent (line 138).
- src/components/common/TalkCard.tsx
- Refactored import paths to use aliases (lines 11-12, 20-21, 25, 31).
- Added
openFeedbackIdproperty toTalkCardPropsinterface (line 46). - Added
openFeedbackIdas a prop to theTalkCardcomponent (line 77). - Updated the OpenFeedback link
hrefto use the dynamicopenFeedbackIdprop (line 117). - Removed the default export for
TalkCard(line 127).
- src/components/common/TrackInformation.tsx
- Refactored import paths to use aliases (lines 3-6, 8).
- Changed
TalkCardimport from default to named (line 2). - Added
openFeedbackIdproperty toTrackInfoPropsinterface (line 13). - Added
openFeedbackIdas a prop to theTrackInformationcomponent (line 28). - Passed the
openFeedbackIdprop down to theTalkCardcomponent (line 42).
- src/data/2023.json
- Added
openFeedbackIdfield with value "devbcn-2023" (line 24).
- Added
- src/data/2024.json
- Added
openFeedbackIdfield with value "devbcn24" (line 25).
- Added
- src/data/2025.json
- Added
openFeedbackIdfield with value "TG4hBcL7iPtV2LecVdHu" (line 24).
- Added
- src/views/Talks/Talks.tsx
- Refactored import paths to use aliases (lines 2-7, 15, 20, 21).
- Passed
openFeedbackIdprop toTrackInformationcomponent (line 170).
- src/views/Talks/components/TalkCard.tsx
- Refactored import paths to use aliases (line 5).
- Changed
CommonTalkCardimport from default to named with alias (line 3). - Minor formatting change in component definition (lines 9-11).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces the openFeedbackId to integrate an open feedback system across different conference years (2023, 2024, 2025). The changes involve updating data files and passing the new ID through relevant components to construct feedback links.
Key improvements include the consistent use of path aliases for imports, which enhances maintainability. The core logic for incorporating the openFeedbackId appears correct.
However, there's a significant concern regarding the visibility of the feedback link itself, which is detailed in a review comment. Other changes are generally positive or minor stylistic updates.
Summary of Findings
- Path Alias Standardization: The updates to use path aliases (e.g.,
@assets,@components,@hooks,@data,@styles,@constants,@views,@types,@services) across multiple files are a commendable improvement. This enhances code maintainability, readability, and makes navigating the codebase easier. - TalkCard Export Refactoring: The change from a default export to a named export for
TalkCardinsrc/components/common/TalkCard.tsx, along with the corresponding updates in importing files, is a good refactoring. Named exports are often preferred for clarity and consistency. - Configuration of
openFeedbackId: TheopenFeedbackIdhas been successfully added to the conference data files for 2023, 2024, and 2025. It's noted that the ID for 2025 (TG4hBcL7iPtV2LecVdHu) follows a different pattern than those for 2023 (devbcn-2023) and 2024 (devbcn24). This is likely by design or due to the ID generation scheme of OpenFeedback for the new year, but it's an observation. (This finding is of low severity and not commented inline due to review settings). - Stylistic Consistency: Minor stylistic changes, such as updating single quotes to double quotes in string literals within
removeParenthesesContentfunctions, contribute to overall code consistency. (This finding is of low severity and not commented inline due to review settings).
Merge Readiness
The pull request makes good progress in integrating the open feedback feature. However, the high-severity issue regarding the visibility of the feedback link needs to be addressed to ensure the feature is functional for end-users. It is recommended that this issue be resolved before merging. As a reviewer, I am not authorized to approve pull requests; further review and approval by authorized team members will be necessary.
|
No description provided.