Merge pull request #91 from dev-five-git/fix-type-checking-issue

owjs3901 · web-flow · commit 05000dd194c1 · 2025-02-01T23:16:25.000+09:00
Fix type checking issue
diff --git a/.changeset/ten-snails-fail.md b/.changeset/ten-snails-fail.md
@@ -0,0 +1,5 @@
+---
+"@devup-ui/react": patch
+---
+
+Fix TypographyKey type definition for better type checking
diff --git a/packages/react/src/types/props/text.ts b/packages/react/src/types/props/text.ts
@@ -40,4 +40,4 @@ export interface DevupUiTextProps {
 }
 
 // for skip type checking without .df
-type TypographyKey<T> = keyof T extends string ? keyof T : string
+type TypographyKey<T> = keyof T extends undefined ? string : keyof T

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@devup-ui/react": patch
 +---
++
 +Fix TypographyKey type definition for better type checking
Original file line number	Diff line number	Diff line change
`@@ -40,4 +40,4 @@ export interface DevupUiTextProps {`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`// for skip type checking without .df`
`43`		`-type TypographyKey<T> = keyof T extends string ? keyof T : string`
	`43`	`+type TypographyKey<T> = keyof T extends undefined ? string : keyof T`