Skip to content

Commit 174fb37

Browse files
committed
Fix rm global css
1 parent d3b8502 commit 174fb37

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

bindings/devup-ui-wasm/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ impl Output {
4343
import_main_css: bool,
4444
) -> Self {
4545
let mut sheet = GLOBAL_STYLE_SHEET.lock().unwrap();
46-
let default_collected = sheet.rm_global_css(&filename);
46+
let default_collected = sheet.rm_global_css(&filename, single_css);
4747
let (collected, updated_base_style) = sheet.update_styles(&styles, &filename, single_css);
4848
Self {
4949
code,

libs/sheet/src/lib.rs

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -228,18 +228,19 @@ impl StyleSheet {
228228
true
229229
}
230230

231-
pub fn rm_global_css(&mut self, file: &str) -> bool {
231+
pub fn rm_global_css(&mut self, file: &str, single_css: bool) -> bool {
232232
if !self.global_css_files.contains(file) {
233233
return false;
234234
}
235235
self.global_css_files.remove(file);
236236
self.css.remove(file);
237237

238238
self.font_faces.remove(file);
239+
let property_key = if single_css { "" } else { file }.to_string();
239240

240241
for map in self
241242
.properties
242-
.entry(file.to_string())
243+
.entry(property_key.clone())
243244
.or_default()
244245
.values_mut()
245246
{
@@ -259,11 +260,11 @@ impl StyleSheet {
259260
}
260261
if self
261262
.properties
262-
.get(file)
263+
.get(&property_key)
263264
.and_then(|v| if v.is_empty() { None } else { Some(()) })
264265
.is_none()
265266
{
266-
self.properties.remove(file);
267+
self.properties.remove(&property_key);
267268
}
268269
true
269270
}
@@ -934,11 +935,11 @@ mod tests {
934935
sheet.add_css("test2.tsx", "div {display:flex;}");
935936
assert_debug_snapshot!(sheet.create_css(None, false));
936937

937-
sheet.rm_global_css("test.tsx");
938+
sheet.rm_global_css("test.tsx", true);
938939

939940
assert_debug_snapshot!(sheet.create_css(None, false));
940941

941-
sheet.rm_global_css("wrong.tsx");
942+
sheet.rm_global_css("wrong.tsx", true);
942943

943944
assert_debug_snapshot!(sheet.create_css(None, false));
944945
}
@@ -1480,7 +1481,7 @@ mod tests {
14801481
None,
14811482
);
14821483

1483-
sheet.rm_global_css("test.tsx");
1484+
sheet.rm_global_css("test.tsx", true);
14841485
assert_debug_snapshot!(sheet.create_css(None, false));
14851486

14861487
let mut sheet = StyleSheet::default();
@@ -1511,7 +1512,7 @@ mod tests {
15111512

15121513
assert_debug_snapshot!(sheet.create_css(None, false));
15131514

1514-
sheet.rm_global_css("test.tsx");
1515+
sheet.rm_global_css("test.tsx", true);
15151516
assert_debug_snapshot!(sheet.create_css(None, false));
15161517

15171518
let mut sheet = StyleSheet::default();
@@ -1542,7 +1543,7 @@ mod tests {
15421543

15431544
assert_debug_snapshot!(sheet.create_css(None, false));
15441545

1545-
sheet.rm_global_css("test.tsx");
1546+
sheet.rm_global_css("test.tsx", true);
15461547
assert_debug_snapshot!(sheet.create_css(None, false));
15471548
}
15481549

0 commit comments

Comments
 (0)