Add coverage

Author: owjs3901

packages/eslint-plugin/src/configs/__tests__/__snapshots__/recommended.test.ts.snap

@@ -79,6 +79,7 @@ exports[`recommended > export recommended config 1`] = `
               },
               "messages": {
                 "styleOrderRange": "styleOrder prop must be a number greater than 0 and less than 255.",
+                "wrongType": "styleOrder prop must be a number or a string representing a number.",
               },
               "schema": [],
               "type": "problem",

packages/eslint-plugin/src/rules/no-duplicate-value/__tests__/index.test.ts

@@ -39,6 +39,10 @@ describe('no-duplicate-value rule', () => {
         code: 'import { css } from "other-package";\ncss()',
         filename: 'src/app/page.tsx',
       },
+      {
+        code: 'import { Box } from "@devup-ui/react";\n<Box w={[call(), null, null, 3]} />',
+        filename: 'src/app/page.tsx',
+      },
     ],
     invalid: [
       {
@@ -80,6 +84,20 @@ describe('no-duplicate-value rule', () => {
           },
         ],
       },
+      {
+        code: 'import { css } from "@devup-ui/react";\ncss({w: [1, `2`, 2, "2", 3]})',
+        output:
+          'import { css } from "@devup-ui/react";\ncss({w: [1, `2`, null, null, 3]})',
+        filename: 'src/app/page.tsx',
+        errors: [
+          {
+            messageId: 'duplicateValue',
+          },
+          {
+            messageId: 'duplicateValue',
+          },
+        ],
+      },
     ],
   })
 })

packages/eslint-plugin/src/rules/no-duplicate-value/index.ts

@@ -12,25 +12,38 @@ const createRule = ESLintUtils.RuleCreator(
     `https://github.com/dev-five-git/devup-ui/tree/main/packages/eslint-plugin/src/rules/${name}`,
 )
 
+function getValue(node: TSESTree.Literal | TSESTree.TemplateLiteral) {
+  if (node.type === AST_NODE_TYPES.Literal) {
+    return node.value?.toString()
+  }
+  return node.quasis[0].value.raw
+}
+
 function checkDuplicateValue<T extends RuleContext<string, []>>(
   node: TSESTree.ArrayExpression,
   context: T,
 ) {
   for (let i = 0; i < node.elements.length; i++) {
     const element = node.elements[i]
-    if (element?.type === AST_NODE_TYPES.Literal) {
+    if (
+      element?.type === AST_NODE_TYPES.Literal ||
+      element?.type === AST_NODE_TYPES.TemplateLiteral
+    ) {
       if (i === 0) continue
+      const elementValue = getValue(element)
+      if (elementValue === undefined) continue
+
       const prevElement = node.elements[i - 1]
       if (
-        prevElement?.type === AST_NODE_TYPES.Literal &&
-        element.value === prevElement.value &&
-        element.value !== null
+        (prevElement?.type === AST_NODE_TYPES.Literal ||
+          prevElement?.type === AST_NODE_TYPES.TemplateLiteral) &&
+        elementValue === getValue(prevElement)
       ) {
         context.report({
           node,
           messageId: 'duplicateValue',
           data: {
-            value: element.value,
+            value: elementValue,
           },
           fix(fixer) {
             return fixer.replaceText(element, 'null')

packages/eslint-plugin/src/rules/no-useless-responsive/__tests__/index.test.ts

@@ -59,6 +59,11 @@ describe('no-useless-responsive rule', () => {
         code: 'import { Box } from "@devup-ui/react";\n<Box w={[1].length === 1 ? 1 : 2} />',
         filename: 'src/app/page.tsx',
       },
+      {
+        // normal case
+        code: '<Box w={[1]} />',
+        filename: 'src/app/page.tsx',
+      },
       {
         code: 'import { css } from "@devup-ui/react";\ncss({w: 1})',
         filename: 'src/app/page.tsx',

packages/eslint-plugin/src/rules/no-useless-tailing-nulls/__tests__/index.test.ts

@@ -24,9 +24,15 @@ describe('no-useless-tailing-nulls rule', () => {
         filename: 'src/app/page.tsx',
       },
       {
+        // normal case
         code: 'import { Box } from "other-package";\n<Box w={[1, 2,]} />',
         filename: 'src/app/page.tsx',
       },
+      {
+        // normal case
+        code: 'css({ w: [1, 2, null] })',
+        filename: 'src/app/page.tsx',
+      },
     ],
     invalid: [
       {

packages/eslint-plugin/src/rules/style-order-range/__tests__/index.test.ts

@@ -344,6 +344,15 @@ describe('style-order-range rule', () => {
           },
         ],
       },
+      {
+        code: 'import { Box } from "@devup-ui/react";\n<Box styleOrder=<div /> />',
+        filename: 'src/app/page.tsx',
+        errors: [
+          {
+            messageId: 'wrongType',
+          },
+        ],
+      },
     ],
   })
 })

packages/eslint-plugin/src/rules/style-order-range/index.ts

@@ -81,6 +81,8 @@ export const styleOrderRange = createRule({
     messages: {
       styleOrderRange:
         'styleOrder prop must be a number greater than 0 and less than 255.',
+      wrongType:
+        'styleOrder prop must be a number or a string representing a number.',
     },
     type: 'problem',
     docs: {
@@ -114,18 +116,14 @@ export const styleOrderRange = createRule({
         }
       },
       Property(node) {
-        if (!devupContext) return
         if (
+          devupContext &&
           node.key.type === AST_NODE_TYPES.Identifier &&
-          node.key.name === 'styleOrder'
+          node.key.name === 'styleOrder' &&
+          node.value.type !== AST_NODE_TYPES.AssignmentPattern &&
+          node.value.type !== AST_NODE_TYPES.TSEmptyBodyFunctionExpression
         ) {
-          const value = node.value
-          if (
-            value.type !== AST_NODE_TYPES.AssignmentPattern &&
-            value.type !== AST_NODE_TYPES.TSEmptyBodyFunctionExpression
-          ) {
-            checkStyleOrderRange(value, context)
-          }
+          checkStyleOrderRange(node.value, context)
         }
       },
       JSXOpeningElement(node) {
@@ -149,13 +147,18 @@ export const styleOrderRange = createRule({
           return
         }
 
-        if (node.value.type === AST_NODE_TYPES.JSXExpressionContainer) {
-          const expression = node.value.expression
-          if (expression.type !== AST_NODE_TYPES.JSXEmptyExpression) {
-            checkStyleOrderRange(expression, context)
-          }
+        if (
+          node.value.type === AST_NODE_TYPES.JSXExpressionContainer &&
+          node.value.expression.type !== AST_NODE_TYPES.JSXEmptyExpression
+        ) {
+          checkStyleOrderRange(node.value.expression, context)
         } else if (node.value.type === AST_NODE_TYPES.Literal) {
           checkStyleOrderRange(node.value, context)
+        } else {
+          context.report({
+            node: node,
+            messageId: 'wrongType',
+          })
         }
       },
     }

packages/react/src/stores/theme-store.ts

@@ -30,9 +30,11 @@ export function createThemeStore() {
   }
 
   const mo = new MutationObserver((mutations) => {
-    for (const m of mutations)
-      if (m.type === 'attributes' && m.target instanceof HTMLElement)
-        set(m.target.getAttribute('data-theme') as Theme)
+    mutations
+      .filter((m) => m.type === 'attributes' && m.target instanceof HTMLElement)
+      .forEach((m) => {
+        set((m.target as HTMLElement).getAttribute('data-theme') as Theme)
+      })
   })
   mo.observe(el, {
     attributes: true,

packages/rsbuild-plugin/src/__tests__/plugin.test.ts

@@ -1,4 +1,4 @@
-import { existsSync } from 'node:fs'
+import { existsSync, writeFileSync } from 'node:fs'
 import { mkdir, readFile, writeFile } from 'node:fs/promises'
 import { join, resolve } from 'node:path'
 
@@ -65,6 +65,25 @@ describe('DevupUIRsbuildPlugin', () => {
     } as any)
   })
 
+  it('should write data files without theme', async () => {
+    vi.mocked(readFile).mockResolvedValueOnce(JSON.stringify({}))
+    vi.mocked(getThemeInterface).mockReturnValue('')
+    vi.mocked(existsSync).mockImplementation((path) => {
+      if (path === 'devup.json') return true
+      return false
+    })
+    const plugin = DevupUI()
+    expect(plugin).toBeDefined()
+    expect(plugin.setup).toBeDefined()
+    const transform = vi.fn()
+    const modifyRsbuildConfig = vi.fn()
+    await plugin.setup({
+      transform,
+      modifyRsbuildConfig,
+    } as any)
+    expect(writeFileSync).not.toHaveBeenCalled()
+  })
+
   it('should error when write data files', async () => {
     const originalConsoleError = console.error
     console.error = vi.fn()