Skip to content

Commit a5523ed

Browse files
authored
Merge pull request #95 from dev-five-git/fix-typing-issue
Fix theme typing
2 parents d5cd124 + e1d8d8b commit a5523ed

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

.changeset/khaki-weeks-film.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@devup-ui/react": patch
3+
---
4+
5+
Fix typing issue

packages/react/src/utils/get-theme.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import { DevupTheme } from '../types/theme'
44

5-
export function getTheme(): keyof DevupTheme | null {
5+
export function getTheme():
6+
| (keyof DevupTheme extends undefined ? string : keyof DevupTheme)
7+
| null {
68
return document.documentElement.getAttribute('data-theme') as keyof DevupTheme
79
}

packages/react/src/utils/set-theme.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22

33
import { DevupTheme } from '../types/theme'
44

5-
export function setTheme(theme: keyof DevupTheme): void {
5+
export function setTheme(
6+
theme: keyof DevupTheme extends undefined ? string : keyof DevupTheme,
7+
): void {
68
document.documentElement.setAttribute('data-theme', theme)
79
localStorage.setItem('__DF_THEME_SELECTED__', theme)
810
}

0 commit comments

Comments
 (0)