Skip to content

Commit b3bd58f

Browse files
committed
Fix naming snapshot
1 parent f74f376 commit b3bd58f

File tree

14 files changed

+25
-22
lines changed

14 files changed

+25
-22
lines changed

crates/vespertide-query/src/sql/add_constraint.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -268,10 +268,13 @@ pub fn build_add_constraint(
268268
Ok(queries)
269269
} else {
270270
// Build foreign key using ForeignKey::create
271+
let fk_name = vespertide_naming::build_foreign_key_name(
272+
table,
273+
columns,
274+
name.as_deref(),
275+
);
271276
let mut fk = ForeignKey::create();
272-
if let Some(n) = name {
273-
fk = fk.name(n).to_owned();
274-
}
277+
fk = fk.name(&fk_name).to_owned();
275278
fk = fk.from_tbl(Alias::new(table)).to_owned();
276279
for col in columns {
277280
fk = fk.from_col(Alias::new(col)).to_owned();

crates/vespertide-query/src/sql/remove_constraint.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -345,11 +345,11 @@ pub fn build_remove_constraint(
345345
Ok(queries)
346346
} else {
347347
// Build foreign key drop using ForeignKey::drop()
348-
let constraint_name = if let Some(n) = name {
349-
n.clone()
350-
} else {
351-
format!("{}_{}_fkey", table, columns.join("_"))
352-
};
348+
let constraint_name = vespertide_naming::build_foreign_key_name(
349+
table,
350+
columns,
351+
name.as_deref(),
352+
);
353353
let fk_drop = ForeignKey::drop()
354354
.name(&constraint_name)
355355
.table(Alias::new(table))
@@ -514,12 +514,12 @@ mod tests {
514514
#[case::remove_constraint_foreign_key_named_postgres(
515515
"remove_constraint_foreign_key_named_postgres",
516516
DatabaseBackend::Postgres,
517-
&["DROP CONSTRAINT \"fk_user\""]
517+
&["DROP CONSTRAINT \"fk_users__fk_user\""]
518518
)]
519519
#[case::remove_constraint_foreign_key_named_mysql(
520520
"remove_constraint_foreign_key_named_mysql",
521521
DatabaseBackend::MySql,
522-
&["DROP FOREIGN KEY `fk_user`"]
522+
&["DROP FOREIGN KEY `fk_users__fk_user`"]
523523
)]
524524
#[case::remove_constraint_foreign_key_named_sqlite(
525525
"remove_constraint_foreign_key_named_sqlite",

crates/vespertide-query/src/sql/snapshots/vespertide_query__sql__add_constraint__tests__add_constraint@add_constraint_add_constraint_foreign_key_mysql.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
source: crates/vespertide-query/src/sql/add_constraint.rs
33
expression: "result.iter().map(|q| q.build(backend)).collect::<Vec<String>>().join(\"\\n\")"
44
---
5-
ALTER TABLE `users` ADD CONSTRAINT `fk_user` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`) ON DELETE CASCADE ON UPDATE RESTRICT
5+
ALTER TABLE `users` ADD CONSTRAINT `fk_users__fk_user` FOREIGN KEY (`user_id`) REFERENCES `users` (`id`) ON DELETE CASCADE ON UPDATE RESTRICT

crates/vespertide-query/src/sql/snapshots/vespertide_query__sql__add_constraint__tests__add_constraint@add_constraint_add_constraint_foreign_key_postgres.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
source: crates/vespertide-query/src/sql/add_constraint.rs
33
expression: "result.iter().map(|q| q.build(backend)).collect::<Vec<String>>().join(\"\\n\")"
44
---
5-
ALTER TABLE "users" ADD CONSTRAINT "fk_user" FOREIGN KEY ("user_id") REFERENCES "users" ("id") ON DELETE CASCADE ON UPDATE RESTRICT
5+
ALTER TABLE "users" ADD CONSTRAINT "fk_users__fk_user" FOREIGN KEY ("user_id") REFERENCES "users" ("id") ON DELETE CASCADE ON UPDATE RESTRICT

crates/vespertide-query/src/sql/snapshots/vespertide_query__sql__remove_constraint__tests__remove_constraint@remove_constraint_remove_constraint_foreign_key_named_mysql.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
source: crates/vespertide-query/src/sql/remove_constraint.rs
33
expression: "result.iter().map(|q| q.build(backend)).collect::<Vec<String>>().join(\"\\n\")"
44
---
5-
ALTER TABLE `users` DROP FOREIGN KEY `fk_user`
5+
ALTER TABLE `users` DROP FOREIGN KEY `fk_users__fk_user`

crates/vespertide-query/src/sql/snapshots/vespertide_query__sql__remove_constraint__tests__remove_constraint@remove_constraint_remove_constraint_foreign_key_named_postgres.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
source: crates/vespertide-query/src/sql/remove_constraint.rs
33
expression: "result.iter().map(|q| q.build(backend)).collect::<Vec<String>>().join(\"\\n\")"
44
---
5-
ALTER TABLE "users" DROP CONSTRAINT "fk_user"
5+
ALTER TABLE "users" DROP CONSTRAINT "fk_users__fk_user"

crates/vespertide-query/src/sql/snapshots/vespertide_query__sql__remove_constraint__tests__remove_constraint_foreign_key_with_index@remove_foreign_key_with_index_MySql.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
source: crates/vespertide-query/src/sql/remove_constraint.rs
33
expression: sql
44
---
5-
ALTER TABLE `posts` DROP FOREIGN KEY `fk_user`
5+
ALTER TABLE `posts` DROP FOREIGN KEY `fk_posts__fk_user`

crates/vespertide-query/src/sql/snapshots/vespertide_query__sql__remove_constraint__tests__remove_constraint_foreign_key_with_index@remove_foreign_key_with_index_Postgres.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
source: crates/vespertide-query/src/sql/remove_constraint.rs
33
expression: sql
44
---
5-
ALTER TABLE "posts" DROP CONSTRAINT "fk_user"
5+
ALTER TABLE "posts" DROP CONSTRAINT "fk_posts__fk_user"

crates/vespertide-query/src/sql/snapshots/vespertide_query__sql__remove_constraint__tests__remove_constraint_foreign_key_with_other_constraints@remove_foreign_key_with_other_constraints_MySql.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
source: crates/vespertide-query/src/sql/remove_constraint.rs
33
expression: sql
44
---
5-
ALTER TABLE `posts` DROP FOREIGN KEY `fk_user`
5+
ALTER TABLE `posts` DROP FOREIGN KEY `fk_posts__fk_user`

crates/vespertide-query/src/sql/snapshots/vespertide_query__sql__remove_constraint__tests__remove_constraint_foreign_key_with_other_constraints@remove_foreign_key_with_other_constraints_Postgres.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
source: crates/vespertide-query/src/sql/remove_constraint.rs
33
expression: sql
44
---
5-
ALTER TABLE "posts" DROP CONSTRAINT "fk_user"
5+
ALTER TABLE "posts" DROP CONSTRAINT "fk_posts__fk_user"

0 commit comments

Comments
 (0)