Skip to content

Commit 5a17343

Browse files
authored
defer関数の引数名をGo命名規約に準拠するよう修正 (#232)
* defer関数の引数名をGo命名規約に準拠するよう修正 defer関数の引数名を`Body`から`readCloser`に変更: - Go言語の命名規約に従い、エクスポートされない変数は小文字始まりに統一 - 型を明確に表す`readCloser`に変更 - 対象ファイル: cmd/health_check/main.go, lib/amesh/amesh.go, lib/misskey/bot.go * readCloser -> body
1 parent f9faf76 commit 5a17343

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

cmd/health_check/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ func main() {
2727
if err != nil {
2828
panic(errors.Wrap(err, "Failed to httpclient.ExecuteHTTPRequest"))
2929
}
30-
defer func(Body io.ReadCloser) {
31-
if closeErr := Body.Close(); closeErr != nil {
30+
defer func(body io.ReadCloser) {
31+
if closeErr := body.Close(); closeErr != nil {
3232
panic(errors.Wrap(closeErr, "Failed to Close"))
3333
}
3434
}(resp.Body)

lib/amesh/amesh.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -517,8 +517,8 @@ func downloadTile(ctx context.Context, client *http.Client, tileURL string) (img
517517
if err != nil {
518518
return nil, errors.Wrap(err, "Failed to ExecuteHTTPRequest")
519519
}
520-
defer func(Body io.ReadCloser) {
521-
if closeErr := Body.Close(); closeErr != nil {
520+
defer func(body io.ReadCloser) {
521+
if closeErr := body.Close(); closeErr != nil {
522522
err = errors.Wrap(closeErr, "Failed to Close")
523523
}
524524
}(resp.Body)

lib/misskey/bot.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ func (bot *Bot) CreateNote(ctx context.Context, params *CreateNoteParams) (err e
7070
if err != nil {
7171
return errors.Wrap(err, "Failed to apiRequest")
7272
}
73-
defer func(Body io.ReadCloser) {
74-
if closeErr := Body.Close(); closeErr != nil {
73+
defer func(body io.ReadCloser) {
74+
if closeErr := body.Close(); closeErr != nil {
7575
err = errors.Wrap(closeErr, "Failed to Close")
7676
}
7777
}(resp.Body)
@@ -125,8 +125,8 @@ func (bot *Bot) UploadFile(ctx context.Context, reader io.Reader, fileName strin
125125
if err != nil {
126126
return nil, errors.Wrap(err, "Failed to executeHTTPRequest")
127127
}
128-
defer func(Body io.ReadCloser) {
129-
if closeErr := Body.Close(); closeErr != nil {
128+
defer func(body io.ReadCloser) {
129+
if closeErr := body.Close(); closeErr != nil {
130130
err = errors.Wrap(closeErr, "Failed to Close")
131131
}
132132
}(resp.Body)
@@ -151,8 +151,8 @@ func (bot *Bot) AddReaction(ctx context.Context, noteID, reaction string) (err e
151151
if err != nil {
152152
return errors.Wrap(err, "Failed to apiRequest")
153153
}
154-
defer func(Body io.ReadCloser) {
155-
if closeErr := Body.Close(); closeErr != nil {
154+
defer func(body io.ReadCloser) {
155+
if closeErr := body.Close(); closeErr != nil {
156156
err = errors.Wrap(closeErr, "Failed to Close")
157157
}
158158
}(resp.Body)

0 commit comments

Comments
 (0)