-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
enhancementNew feature or requestNew feature or request
Description
#if !(defined(_MSC_VER) && _MSC_VER >= 1910 && ((defined(_MSVC_LANG) && _MSVC_LANG > 201402)) || (__cplusplus > 201402))
#error "Library SUTFCPP requires a compiler that supports C++ 17!"
#endifI found such a check in your code.
I think it's much better to check for library feature macros and compiler feature macros for what you exactly used.
I had a lot of problems in my past, checking for __cplusplus and then having issues in Linux, when compiler and STL version are not in sync (imagine using clang 10 with libstdc++6 for example).
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request