Allow to execute a job if remaining day time equals interval (quartznet#2726)

Co-authored-by: Nikolai Orekhov <[email protected]>

Author: sherlock1982

src/Quartz.Tests.Unit/DailyTimeIntervalScheduleBuilderTest.cs

@@ -1,4 +1,4 @@
-#region License
+#region License
 
 /*
  * All content copyright Marko Lahma, unless otherwise indicated. All rights reserved.
@@ -296,6 +296,31 @@ public void TestEndingAtAfterCountEndTimeOfDayValidation()
             Assert.DoesNotThrow(trigger.Validate, "We should accept EndTimeOfDay specified by EndingDailyAfterCount(x).");
         }
 
+        [Test]
+        public void TestEndingAtAfterCountEndTimeOfDayLastIntervalValidation()
+        {
+            Assert.DoesNotThrow(() => TriggerBuilder.Create()
+                .WithIdentity("testTrigger")
+                .ForJob("testJob")
+                .WithDailyTimeIntervalSchedule(x =>
+                    x.StartingDailyAt(TimeOfDay.HourAndMinuteOfDay(23, 59))
+                        .EndingDailyAfterCount(1))
+                .Build(), "We should accept if remaining time equals to the interval of 1 minute");
+        }
+
+        [Test]
+        public void TestEndingAtAfterCountEndTimeOfDayLastIntervalValidationFailed()
+        {
+            Assert.Throws<ArgumentException>(() => TriggerBuilder.Create()
+                .WithIdentity("testTrigger")
+                .ForJob("testJob")
+                .WithDailyTimeIntervalSchedule(x =>
+                    x.StartingDailyAt(TimeOfDay.HourMinuteAndSecondOfDay(23, 59, 59))
+                        .WithInterval(1, IntervalUnit.Minute)
+                        .EndingDailyAfterCount(1))
+                .Build(), "We should not accept if remaining time less than the interval of 1 minute");
+        }
+
         [Test]
         public void TestCanSetTimeZone()
         {

src/Quartz/DailyTimeIntervalScheduleBuilder.cs

@@ -1,4 +1,4 @@
-#region License
+#region License
 
 /*
  * All content copyright Marko Lahma, unless otherwise indicated. All rights reserved.
@@ -366,14 +366,14 @@ public DailyTimeIntervalScheduleBuilder EndingDailyAfterCount(int count)
 
             DateTimeOffset today = SystemTime.UtcNow();
             DateTimeOffset startTimeOfDayDate = startTimeOfDayUtc.GetTimeOfDayForDate(today);
-            DateTimeOffset maxEndTimeOfDayDate = TimeOfDay.HourMinuteAndSecondOfDay(23, 59, 59).GetTimeOfDayForDate(today);
+            DateTimeOffset tomorrow = startTimeOfDayDate.AddDays(1).UtcDateTime.Date;
 
             //apply proper offsets according to timezone
             TimeZoneInfo targetTimeZone = timeZone ?? TimeZoneInfo.Local;
             startTimeOfDayDate = new DateTimeOffset(startTimeOfDayDate.DateTime, TimeZoneUtil.GetUtcOffset(startTimeOfDayDate.DateTime, targetTimeZone));
-            maxEndTimeOfDayDate = new DateTimeOffset(maxEndTimeOfDayDate.DateTime, TimeZoneUtil.GetUtcOffset(maxEndTimeOfDayDate.DateTime, targetTimeZone));
+            tomorrow = new DateTimeOffset(tomorrow.DateTime, TimeZoneUtil.GetUtcOffset(tomorrow.DateTime, targetTimeZone));
 
-            TimeSpan remainingMillisInDay = maxEndTimeOfDayDate - startTimeOfDayDate;
+            TimeSpan remainingMillisInDay = tomorrow - startTimeOfDayDate;
             TimeSpan intervalInMillis;
             if (intervalUnit == IntervalUnit.Second)
             {
@@ -406,7 +406,7 @@ public DailyTimeIntervalScheduleBuilder EndingDailyAfterCount(int count)
             TimeSpan incrementInMillis = TimeSpan.FromTicks((count - 1) * intervalInMillis.Ticks);
             DateTimeOffset endTimeOfDayDate = startTimeOfDayDate.Add(incrementInMillis);
 
-            if (endTimeOfDayDate > maxEndTimeOfDayDate)
+            if (endTimeOfDayDate >= tomorrow)
             {
                 throw new ArgumentException("The given count " + count + " is too large! The max you can set is " + maxNumOfCount);
             }