From 8d62073c0ed9eca6e8be7d25864c586bba2f625e Mon Sep 17 00:00:00 2001
From: Jani <43068636+myllyja@users.noreply.github.com>
Date: Thu, 25 Jul 2019 16:44:09 +0300
Subject: [PATCH 1/3] Fixed Get-NSLBVirtualServerBinding to also retrieve
 service_binding objects

Get-NSLBVirtualServerBinding was looking for lbvserver_servicegroup_binding and lbvserver_service_binding objects when called with the name parameter. Without the parameter is was only returning lbvserver_servicegroup_binding objects.
---
 .../Public/Get-NSLBVirtualServerBinding.ps1   | 23 +++++++++++--------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/NetScaler/Public/Get-NSLBVirtualServerBinding.ps1 b/NetScaler/Public/Get-NSLBVirtualServerBinding.ps1
index 101d940..da59c44 100644
--- a/NetScaler/Public/Get-NSLBVirtualServerBinding.ps1
+++ b/NetScaler/Public/Get-NSLBVirtualServerBinding.ps1
@@ -71,16 +71,21 @@ function Get-NSLBVirtualServerBinding {
         } else {
             $vServers = Get-NSLBVirtualServer -Session $Session -Verbose:$false
             foreach ($item in $vServers) {
-                $response = _InvokeNSRestApi -Session $Session -Method Get -Type lbvserver_servicegroup_binding -Resource $item.name
-                if ($response.errorcode -ne 0) { throw $bindings }
-                if ($response.PSobject.Properties.name -contains 'lbvserver_servicegroup_binding') {
-                    $result += $response.lbvserver_servicegroup_binding
-                }
-                if ($response.PSobject.Properties.name -contains 'lbvserver_service_binding') {
-                    $result += $response.lbvserver_service_binding
-                }
+                $response = @()
+                $response += _InvokeNSRestApi -Session $Session -Method Get -Type lbvserver_servicegroup_binding -Resource $item.name
+                if ($response.errorcode -ne 0) { throw $response }
+                $response += _InvokeNSRestApi -Session $Session -Method Get -Type lbvserver_service_binding -Resource $item.name
+
+                foreach ($entry in $response) {
+					if ($entry.PSobject.Properties.name -contains 'lbvserver_servicegroup_binding') {
+						$result += $entry.lbvserver_servicegroup_binding
+					}
+					if ($entry.PSobject.Properties.name -contains 'lbvserver_service_binding') {
+						$result += $entry.lbvserver_service_binding
+					}
+				}
             }
         }
         return $result
     }
-}
\ No newline at end of file
+}

From dac62055796e332dd51d341debd078798b8f21c0 Mon Sep 17 00:00:00 2001
From: Jani <43068636+myllyja@users.noreply.github.com>
Date: Fri, 26 Jul 2019 09:17:15 +0300
Subject: [PATCH 2/3] Fixed tabs to spaces

---
 NetScaler/Public/Get-NSLBVirtualServerBinding.ps1 | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/NetScaler/Public/Get-NSLBVirtualServerBinding.ps1 b/NetScaler/Public/Get-NSLBVirtualServerBinding.ps1
index da59c44..2b7fc61 100644
--- a/NetScaler/Public/Get-NSLBVirtualServerBinding.ps1
+++ b/NetScaler/Public/Get-NSLBVirtualServerBinding.ps1
@@ -77,13 +77,13 @@ function Get-NSLBVirtualServerBinding {
                 $response += _InvokeNSRestApi -Session $Session -Method Get -Type lbvserver_service_binding -Resource $item.name
 
                 foreach ($entry in $response) {
-					if ($entry.PSobject.Properties.name -contains 'lbvserver_servicegroup_binding') {
-						$result += $entry.lbvserver_servicegroup_binding
-					}
-					if ($entry.PSobject.Properties.name -contains 'lbvserver_service_binding') {
-						$result += $entry.lbvserver_service_binding
-					}
-				}
+                    if ($entry.PSobject.Properties.name -contains 'lbvserver_servicegroup_binding') {
+                        $result += $entry.lbvserver_servicegroup_binding
+                    }
+                    if ($entry.PSobject.Properties.name -contains 'lbvserver_service_binding') {
+                        $result += $entry.lbvserver_service_binding
+                    }
+                }
             }
         }
         return $result

From 491767a0d45964951514aa8f45cc5950d79e88b6 Mon Sep 17 00:00:00 2001
From: Jani <43068636+myllyja@users.noreply.github.com>
Date: Wed, 21 Aug 2019 13:47:51 +0300
Subject: [PATCH 3/3] Updated changelog

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index a87a287..a85cf16 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -27,6 +27,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
   * Bug fixes
     * Fixed bug where extraneous Out-Null files were created when calling some functions (via @iainbrighton)
+    * Fixed bug where Get-NSLBVirtualServerBinding didn't return lbvserver_service_binding objects (via @myllyja)
 
 ## 1.7.0 (2018-07-02)
   * Features