fix: build

Author: devchenyan

packages/neuron-ui/.eslintrc.js

@@ -96,6 +96,7 @@ module.exports = {
         allowExpressions: true,
       },
     ],
+    '@typescript-eslint/ban-types': 'off',
     'import/no-unresolved': [2, { ignore: ['.svg'] }],
   },
 }

packages/neuron-ui/package.json

@@ -18,7 +18,7 @@
     "start": "cross-env DISABLE_ESLINT_PLUGIN=true vite",
     "lint": "eslint --fix --ext .tsx,.ts,.js src",
     "test": "vitest --environment=jsdom --run --watch=false",
-    "build": "cross-env DISABLE_ESLINT_PLUGIN=true vite build",
+    "build": "cross-env DISABLE_ESLINT_PLUGIN=true tsc && vite build",
     "clean": "npx rimraf build",
     "precommit": "lint-staged",
     "storybook": "storybook dev -p 9009",

packages/neuron-ui/src/components/ErrorBoundary/index.tsx

@@ -5,7 +5,7 @@ import { handleViewError } from 'services/remote'
 
 const handleError = (error: Error) => {
   handleViewError(error.toString())
-  if (process.env.NODE_ENV !== 'development') {
+  if (import.meta.env.MODE !== 'development') {
     window.location.reload()
   }
   return { hasError: true }

packages/neuron-ui/src/components/SendFieldset/index.tsx

@@ -5,7 +5,7 @@ import TextField from 'widgets/TextField'
 import Button from 'widgets/Button'
 import Trash from 'widgets/Icons/Trash.svg?react'
 import Attention from 'widgets/Icons/ExperimentalAttention.svg?react'
-import TimeClock from 'widgets/Icons/TimeClock.svg?react'
+import TimeClock from 'widgets/Icons/TimeClock.svg'
 
 import { formatDate } from 'widgets/DatetimePickerDialog'
 import { localNumberFormatter, isSecp256k1Address, clsx } from 'utils'

packages/neuron-ui/src/components/WalletWizard/index.tsx

@@ -151,7 +151,7 @@ const Welcome = ({ rootPath = '/wizard/', wallets = [], dispatch }: WizardElemen
 
   return (
     <div className={styles.welcome}>
-      <img src={`${process.env.PUBLIC_URL}/icon.png`} width="58px" className={styles.logo} alt="logo" />
+      <img src="/icon.png" width="58px" className={styles.logo} alt="logo" />
       <span className={styles.slogan}>{t('wizard.welcome-to-nervos-neuron')}</span>
       <Button
         type="default"

packages/neuron-ui/src/types/global/index.d.ts

@@ -1,3 +1,5 @@
+/// <reference types="vite-plugin-svgr/client" />
+
 declare interface Window {
   electron: {
     clipboard: any
@@ -13,6 +15,11 @@ declare module '*.json' {
   export default value
 }
 
+declare module '*.svg' {
+  const content: string
+  export default content
+}
+
 declare module '*.svg?react' {
   const value: string
   export const ReactComponent: React.FC<React.SVGProps<SVGSVGElement>>

packages/neuron-ui/src/widgets/Tabs/index.tsx

@@ -73,9 +73,9 @@ export const Tabs = <T extends {}, E extends {} = DefaultVariantProps>({
 
   const combinedOnTabChange = useCallback<VariantProps<T>['onTabChange']>(
     id => {
-      const selectedTab = tabs.find(tab => tab.id === id) ?? tabs[0]
-      setSelectedTabId(selectedTab.id)
-      onTabChange?.(selectedTab)
+      const foundTab = tabs.find(tab => tab.id === id) ?? tabs[0]
+      setSelectedTabId(foundTab.id)
+      onTabChange?.(foundTab)
     },
     [onTabChange, tabs]
   )

packages/neuron-ui/tsconfig.json

@@ -8,8 +8,13 @@
     "isolatedModules": true,
     "noEmit": true,
     "jsx": "preserve",
-    "types": ["@types/jest", "vitest/globals", "@testing-library/jest-dom"],
-    "typeRoots": ["src/types", "node_modules/@nervosnetwork/ckb-types", "node_modules/@types"],
+    "typeRoots": [
+      "src/types",
+      "node_modules/@nervosnetwork/ckb-types",
+      "node_modules/@types",
+      "node_modules/@testing-library",
+      "node_modules/vite"
+    ],
     "allowJs": true,
     "allowSyntheticDefaultImports": true
   },

packages/neuron-ui/vite-env.d..ts

@@ -0,0 +1 @@
+/// <reference types="vite/client" />

packages/neuron-ui/vite.config.js

@@ -18,9 +18,12 @@ export default defineConfig({
     postcss({
       autoprefixer: false,
     }),
-    svgr({ include: '**/*.svg?react' }),
+    svgr({
+      include: '**/*.svg?react',
+    }),
     ...[process.env.DISABLE_ESLINT_PLUGIN === 'true' ? [] : [eslintPlugin()]],
   ],
+  assetsInclude: ['**/*.svg'],
   base: './',
   root: './',
   resolve: {